Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759839AbXFVQnp (ORCPT ); Fri, 22 Jun 2007 12:43:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753697AbXFVQnP (ORCPT ); Fri, 22 Jun 2007 12:43:15 -0400 Received: from smtp2.linux-foundation.org ([207.189.120.14]:54416 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758541AbXFVQnN (ORCPT ); Fri, 22 Jun 2007 12:43:13 -0400 Date: Fri, 22 Jun 2007 09:40:45 -0700 (PDT) From: Linus Torvalds To: Hugh Dickins cc: Christoph Lameter , Nicolas Ferre , ARM Linux Mailing List , Linux Kernel list , Marc Pignat , Andrew Victor , Pierre Ossman , Andrew Morton , Russell King Subject: Re: Oops in a driver while using SLUB as a SLAB allocator In-Reply-To: Message-ID: References: <467A4532.40301@rfo.atmel.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1361 Lines: 36 On Fri, 22 Jun 2007, Hugh Dickins wrote: > > On Thu, 21 Jun 2007, Christoph Lameter wrote: > > > Maybe this will address the issue on ARM? > > Looks like it would indeed address the immediate issue on ARM - > IF they've no particular reason to be using kmalloc there. I think the right thing to do is do both of these things. I already applied Hugh's patch - it seemed like a total nobrainer to do at this stage in the 2.6.22 -rc series. But that doesn't mean that we should not _also_ look at "flush_dcache_page()" users. I do think that even just the name (the ".._page()" part) makes it obvious that it was designed for page-level allocations, not kmalloc(). So I think Christoph's patch makes sense in that context. At the same time, I do think that the whole notion of flushing the D$ is certainly something that makes sense for kmalloc() allocations also, and maybe people do actually do small DMA allocations and Christophs patch would break that. End result: for 2.6.22, I think the patch from Hugh that I already applied is the right thing. But as to 2.6.23 and onward.. I dunno. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/