Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b9fc8a52-74b5-2f78-fbf6-8b473c6a8a36@amd.com>
Date:   Tue, 27 Sep 2022 16:16:42 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [RFC 0/6] migrate_pages(): batch TLB flushing
Content-Language: en-US
To:     "Huang, Ying" <ying.huang@intel.com>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Zi Yan <ziy@nvidia.com>, Yang Shi <shy828301@gmail.com>,
        Baolin Wang <baolin.wang@linux.alibaba.com>,
        Oscar Salvador <osalvador@suse.de>,
        Matthew Wilcox <willy@infradead.org>
References: <20220921060616.73086-1-ying.huang@intel.com>
 <477e50ab-9045-0ca2-6979-e2dca71be263@amd.com>
 <87bkr6jzmz.fsf@yhuang6-desk2.ccr.corp.intel.com>
From:   Bharata B Rao <bharata@amd.com>
In-Reply-To: <87bkr6jzmz.fsf@yhuang6-desk2.ccr.corp.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bmxMTzhoZFI3RW9JaXpIS2c0QmpoSWUwVHJhanR4ZGQydjNrRTA0YzF4cXZO?=
 =?utf-8?B?OERzNGJWbHdCS203Z3FJVXpySXF1UVIwMmtyT01CRkRPSndxYS9UREFFU0Nx?=
 =?utf-8?B?NXBBclc2aGpIM3VydGNhOS9YcmZTbWJpcHNua1dSNzJEbXU4SVYwSkhPRlBM?=
 =?utf-8?B?K2RsSlZpVjlRMzJhM1pOL21MbStwalVuNWNiNGgra3RnbGNVdXYwSm14TUR2?=
 =?utf-8?B?NGx6eU9xRGdYU1hScm12YVA2ZHlPMVozdHZNSGdybkJsRFI4VHBibzJZbGZP?=
 =?utf-8?B?ckVKWjN0STJUQTE1clRXRHlkR0RxVWFhL0RmM3ZTUmlROXhBYmZjNUs0Wisv?=
 =?utf-8?B?Z01oN1QwSndwUkFtRkR4M3lIWVM4ejFXcUZKZXdyN0dHaHRvQ2tTWitSaDFx?=
 =?utf-8?B?bW5Wd3FUdnpWV0JvZlJEdllrbm1wdWl6RHNMd01yY01oUVI2OGx1RzBMbEhS?=
 =?utf-8?B?OUlSc1RpQk9JMUkxNTNrY2g3Ujg5NUUzZmNRVFZSaTZEVUFxbmp6dzN2eGdP?=
 =?utf-8?B?WGtCRXB6TWk0SHkwcnh2cnVuMnpBdEUyK3pxWE53VCtZVTJTU2tqMGdhRUtq?=
 =?utf-8?B?T29VM2xQeGpUUkhvMGt2cEVhazMrUG9tM3ZkdFppUG1mdnFkdE5qOTNOaDc0?=
 =?utf-8?B?TS9yL0tVcDh0YjExRlZhb3RJeGFqaUI2ZEFqekhBRVI0YnlDMnA3UzZXbHdN?=
 =?utf-8?B?WlBjUGxKUDh1NXN4TFFyZVJEWklLWGkwcGw3eEZibmlvTmd2aW52YlFsa29F?=
 =?utf-8?B?a3FSN21nYVpPNVFwVE1lcU8rUXhhd0RrNVRiT3BKMWJ4ODQyNjVob2RLUTRC?=
 =?utf-8?B?Y0RvVGxSOWYvcUJST1VtbUQ2eDhncnRvZUFxaDVIeVdJUHVWVUxzK2QwbUtZ?=
 =?utf-8?B?MVROdllFYUNUemUwdldEMENYbFJ0UHlhYS9TV1ltV2lxWG9WREZLa1BGOCtX?=
 =?utf-8?B?TGVXZ2cyZ3BrQVY1ck02RWtsTXRiU0JKZU5Uc0RVVlRMWUFHRjkvbitKVzRK?=
 =?utf-8?B?bXg0cXh5N2UxcTkrYUpMZkU2Y2xzMDRKMlZySHk3WDhpVTVHMVZDcFRhQUhZ?=
 =?utf-8?B?US9uVXdBZXhJdUVXNGhIa3p3bk9JcUxiMUtEUjNtdGRpZmsvWkxsYTFlWGVo?=
 =?utf-8?B?bktvVGRBVXNLYlFyaUJKczlRUXFxK3pFRXNuZC9TVmw3RlMzTmh1RTNvRFRX?=
 =?utf-8?B?UFQ0U1NzU1BjMXFIbCt0U2c5dkg0VFZVeDhlb0dRS250a21XT0NJd1BCTm94?=
 =?utf-8?B?ank0dll3Qk4venQ2clRKMGJ0TzA3S2Z2YlBxNEoyQzc5NDZHcTY2cUJzTU9D?=
 =?utf-8?B?SmQxMWNTdVJMMDNXK0VyT05TRmdyY3JJK3pYZ3I1V2xva1c4RnEzdEFyS1JI?=
 =?utf-8?B?eGhjTU5qM3BOYW5TS3BEL3BFUFdSRzZaZ0VYMklKRUhZQWlrdzVzRWExUHBj?=
 =?utf-8?B?WVV0NXFzUUZMbFdyTExQclN2NVRuaDA1QkhRNy9NZnBsQ2RqSk5VTS9ETUJY?=
 =?utf-8?B?eDlDeTEwOXZEdEZoYmJjSkdyTTlkNlJ0Y0ZuL0M4Z0w1R05NU0liSDYyZS81?=
 =?utf-8?B?cXZ0N1RmaHNxVGNzWloyczNWSlJ4TENBcGo3S3F1VVNJRUx0ZitwbEdkUk52?=
 =?utf-8?B?UWdKblNJWGw0RDJpWFc2Znh5WDBaSkVqRHoxRWFqOFB5MXVwMWNEWHQ1d0dV?=
 =?utf-8?B?dTlXaitSYlhQNWZWelVRRSs4ck5lVVFRSjZoamtyTWdBT2VFbE9UWlNseEJP?=
 =?utf-8?B?YTVYWEpEMGRweXVZMml6aldpR2k2N21RVm1XMGswQVF2NEhRMHpsSGRCTkEr?=
 =?utf-8?B?RS8vUmJUaHNydVNqS2gvbGd4T0lTaFdnRTFKN280MVd3OThzV0Q5MWpsRE9h?=
 =?utf-8?B?VWtaeDBhRkhzV213b2NuT3h2WldleTltUTVQRmhCWkdVR3VTN05wUHQyamln?=
 =?utf-8?B?NlFYTjl1NVlVMEZuNHVwSFJJNUdUN3VERHpRSVl1dW5hMW5oRmtZbi9MbVpP?=
 =?utf-8?B?SmRNZVorbEQxN042UEVLT3BkNm9uK3RyeVFzYjYrMVBsL1RkRmhTUWM3ajRH?=
 =?utf-8?B?LzN1MVpaNVFzc3JLSWljVkpPQVN1M0lWSVJLQ084bW5kV0VwMmx6Vk15ay96?=
 =?utf-8?Q?gi+r6ceKGaDrVuR3w+DxFNb1k?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8246bae2-56c6-4589-1574-08daa075974a
X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6434.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 10:46:53.9772
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9Q0pd8/Ier515usNJbF6VqytpTOF76rLKKWah89uUF1Dny7+ZERujVVG+szpTy6YGzKeDeA8zRTn+Ly2Yr+B1w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7620
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 9/23/2022 1:22 PM, Huang, Ying wrote:
> Bharata B Rao <bharata@amd.com> writes:
>>
>> Thanks for the patchset. I find it hitting the following BUG() when
>> running mmtests/autonumabench:
>>
>> kernel BUG at mm/migrate.c:2432!
>>
>> This is BUG_ON(!list_empty(&migratepages)) in migrate_misplaced_page().
> 
> Thank you very much for reporting!  I haven't reproduced this yet.  But
> I will pay special attention to this when develop the next version, even
> if I cannot reproduce this finally.

The following change fixes the above reported BUG_ON().

diff --git a/mm/migrate.c b/mm/migrate.c
index a0de0d9b4d41..c11dd82245e5 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -1197,7 +1197,7 @@ static int migrate_page_unmap(new_page_t get_new_page, free_page_t put_new_page,
         * references and be restored.
         */
        /* restore the page to right list. */
-       if (rc != -EAGAIN)
+       if (rc == -EAGAIN)
                 ret = NULL;
 
        migrate_page_undo_page(page, page_was_mapped, anon_vma, locked, ret);

The pages that returned from unmapping stage with -EAGAIN used to
end up on "ret" list rather than continuing on the "from" list.

Regards,
Bharata.