Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH v5 2/5] Revert "frontswap: simplify
 frontswap_register_ops"
To:     Christoph Hellwig <hch@lst.de>
References: <20220915035003.3347466-1-liushixin2@huawei.com>
 <20220915035003.3347466-3-liushixin2@huawei.com>
 <20220920121305.GA4237@lst.de>
 <2b469a5c-7960-ca6a-9360-c7d3aa26e8ae@huawei.com>
 <20220927072754.GB16710@lst.de>
CC:     Seth Jennings <sjenning@redhat.com>,
        Dan Streetman <ddstreet@ieee.org>,
        Vitaly Wool <vitaly.wool@konsulko.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Nathan Chancellor <nathan@kernel.org>, <linux-mm@kvack.org>,
        <linux-kernel@vger.kernel.org>,
        Kefeng Wang <wangkefeng.wang@huawei.com>
From:   Liu Shixin <liushixin2@huawei.com>
Message-ID: <986efc9f-0deb-f705-dff1-f4d5992c2b8d@huawei.com>
Date:   Tue, 27 Sep 2022 19:12:58 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <20220927072754.GB16710@lst.de>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2022/9/27 15:27, Christoph Hellwig wrote:
> On Wed, Sep 21, 2022 at 09:42:41AM +0800, Liu Shixin wrote:
>> This revert makes code complicated, but I think it's necessary. When
>> enable zswap, I expect it to work for all swap devices as much as
>> possible.
> But why would expect something to work on a device that has been
> swapped on before?  That's not usually how things work.
>
> .
If not do this, while some user enable swap device first and then enable zswap,
zswap will not take effect. The user need to re-enable the swap device which is
inconvenient.
>