Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 27 Sep 2022 07:37:07 -0400
Message-ID: <86tu4t6obg.wl-maz@kernel.org>
From:   Marc Zyngier <maz@kernel.org>
To:     "Arnd Bergmann" <arnd@arndb.de>
Cc:     "Huacai Chen" <chenhuacai@loongson.cn>,
        "Thomas Gleixner" <tglx@linutronix.de>, loongarch@lists.linux.dev,
        linux-kernel@vger.kernel.org, "Xuefeng Li" <lixuefeng@loongson.cn>,
        "Huacai Chen" <chenhuacai@gmail.com>,
        "Jiaxun Yang" <jiaxun.yang@flygoat.com>
Subject: Re: [PATCH] irqchip: Make irqchip_init() usable on pure ACPI systems
In-Reply-To: <e0efb8a9-b4b0-47bf-ab84-ea71c3630f9d@www.fastmail.com>
References: <20220927045514.2762299-1-chenhuacai@loongson.cn>
        <e0efb8a9-b4b0-47bf-ab84-ea71c3630f9d@www.fastmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1
 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Tue, 27 Sep 2022 03:51:04 -0400,
"Arnd Bergmann" <arnd@arndb.de> wrote:
> 
> On Tue, Sep 27, 2022, at 6:55 AM, Huacai Chen wrote:
> 
> > @@ -28,7 +28,9 @@ extern struct of_device_id __irqchip_of_table[];
> > 
> >  void __init irqchip_init(void)
> >  {
> > +#ifdef CONFIG_OF_IRQ
> >  	of_irq_init(__irqchip_of_table);
> > +#endif
> >  	acpi_probe_device_table(irqchip);
> >  }
> 
> I think that #ifdef should be in the include/linux/of_irq.h
> header, with an empty inline function in the #else path.

Agreed. Please keep the C code free of #ifdefs if at all possible.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.