Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 27 Sep 2022 14:00:39 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
Cc:     Juri Lelli <juri.lelli@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Ricardo Neri <ricardo.neri@intel.com>,
        "Ravi V. Shankar" <ravi.v.shankar@intel.com>,
        Ben Segall <bsegall@google.com>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Len Brown <len.brown@intel.com>, Mel Gorman <mgorman@suse.de>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Tim Chen <tim.c.chen@linux.intel.com>,
        Valentin Schneider <vschneid@redhat.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org, "Tim C . Chen" <tim.c.chen@intel.com>
Subject: Re: [RFC PATCH 17/23] thermal: intel: hfi: Enable the Intel Thread
 Director
Message-ID: <YzLl5+yMUrrGiphr@hirez.programming.kicks-ass.net>
References: <20220909231205.14009-1-ricardo.neri-calderon@linux.intel.com>
 <20220909231205.14009-18-ricardo.neri-calderon@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220909231205.14009-18-ricardo.neri-calderon@linux.intel.com>
Precedence: bulk

On Fri, Sep 09, 2022 at 04:11:59PM -0700, Ricardo Neri wrote:

> +config INTEL_THREAD_DIRECTOR
> +	bool "Intel Thread Director"
> +	depends on INTEL_HFI_THERMAL
> +	depends on SMP
> +	select SCHED_TASK_CLASSES
> +	help
> +	  Select this option to enable the Intel Thread Director. If selected,
> +	  hardware classifies tasks based on the type of instructions they
> +	  execute. It also provides performance capabilities for each class of
> +	  task. On hybrid processors, the scheduler uses this data to place
> +	  tasks of classes of higher performance on higher-performnance CPUs.

Do we really need yet another CONFIG symbol for all this!? AFAICT this
Thread Director crud simply extends the HFI table and doesn't actually
carry that much code with it.

Best to always have it on when HFI is on, no?