Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 27 Sep 2022 13:59:15 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
Cc:     Juri Lelli <juri.lelli@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Ricardo Neri <ricardo.neri@intel.com>,
        "Ravi V. Shankar" <ravi.v.shankar@intel.com>,
        Ben Segall <bsegall@google.com>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Len Brown <len.brown@intel.com>, Mel Gorman <mgorman@suse.de>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Tim Chen <tim.c.chen@linux.intel.com>,
        Valentin Schneider <vschneid@redhat.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org, "Tim C . Chen" <tim.c.chen@intel.com>
Subject: Re: [RFC PATCH 15/23] thermal: intel: hfi: Report per-cpu
 class-specific performance scores
Message-ID: <YzLlk8NL5qkOOxzX@hirez.programming.kicks-ass.net>
References: <20220909231205.14009-1-ricardo.neri-calderon@linux.intel.com>
 <20220909231205.14009-16-ricardo.neri-calderon@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220909231205.14009-16-ricardo.neri-calderon@linux.intel.com>
Precedence: bulk

On Fri, Sep 09, 2022 at 04:11:57PM -0700, Ricardo Neri wrote:
> Support the arch_get_task_class_score() interface of the scheduler. Use the
> data that Intel Thread Director provides to inform the scheduler the
> performance of a class of tasks when placed on a given CPU.
> 

> +static void get_one_hfi_cap(struct hfi_instance *hfi_instance, s16 index,
> +			    struct hfi_cpu_data *hfi_caps, int class)
> +{
> +	struct hfi_cpu_data *caps;
> +
> +	/* Find the capabilities of @cpu */
> +	caps = hfi_instance->data + index * hfi_features.cpu_stride +
> +	       class * hfi_features.class_stride;
> +	memcpy(hfi_caps, caps, sizeof(*hfi_caps));
> +}
> +
> +int intel_hfi_get_task_class_score(int class, int cpu)
> +{
> +	struct hfi_cpu_info *info = &per_cpu(hfi_cpu_info, cpu);
> +	struct hfi_instance *instance;
> +	struct hfi_cpu_data caps;
> +	unsigned long flags;
> +	int cap;
> +
> +	if (cpu < 0 || cpu >= nr_cpu_ids)
> +		return -EINVAL;
> +
> +	if (class == TASK_CLASS_UNCLASSIFIED)
> +		return -EINVAL;
> +
> +	if (class >= (int)hfi_features.nr_classes)
> +		return -EINVAL;
> +
> +	instance = info->hfi_instance;
> +	if (!instance)
> +		return -ENOENT;
> +
> +	raw_spin_lock_irqsave(&instance->table_lock, flags);
> +	get_one_hfi_cap(instance, info->index, &caps, class);
> +	cap = caps.perf_cap;
> +	raw_spin_unlock_irqrestore(&instance->table_lock, flags);
> +
> +	return cap;
> +}

Does any of that data actually ever change? Isn't the class score fixed
per CPU type?