Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp833001rwb; Tue, 27 Sep 2022 05:23:25 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4vHk9OmXTQDXgmO24ZdZU4fOAp4Shr2bZVhjAfYorytfNyZ/9bfq9A7uULlp+aNqt4SxyM X-Received: by 2002:a17:906:9bd3:b0:778:c8e0:fcee with SMTP id de19-20020a1709069bd300b00778c8e0fceemr22831705ejc.275.1664281405461; Tue, 27 Sep 2022 05:23:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664281405; cv=none; d=google.com; s=arc-20160816; b=GUHvqHvLoUCGsPAHUWaxcw4XrrtJBmmdSBSyH+sx3TFfHrb1LMgtRILmVRBp1gkdmf hXtCg/BKuAX/X7BCeWyOyuhwt1hAsbQV13iINn5o2CWWdR/SzGkPtsbtIIhAyydiKPlv GCW2EozKvbwSb47DKrjv/2XrJuJaXD+dXOHUV1gZmsvBIKw2CcVBthwL+K/js30jR1YH 1QVIAogkBOSJYagpbIIEPhD2c4Za483cm2TyEQ/10fwjyG6gQW79PZalj+APNP1Y0Fvy yI1GQfm/Jb2usUi4TjGaK984nkY5MTyy6eYCQIGE3P8A4ihdrReYpiB+UyZUssEzogP5 IOfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=sh92KicTDh4caqpKkqA808K5SVahDD/Q8fFa9qaLWr4=; b=lQhtFJzlAhfdOh53nQepXr2zM8gRTVt14VvmQZ42oSwb5QUeAfTMjjtL+WWPXM0hwS WqBfIhkiHyiTrn2gD1CvZEVqiA3cEuzTwdtvStaBad2rIgxBTEMyxtRFA2dNaI8daTes AOpciMAciWL4mrShBQHTaIORNRasSCUMuUggfdL5sKgO26ruAOSxHFgjBGIuOApNtMKr Q9LjW2K60WakOHa71YfHOCWihve53Z+RvSFvyGhxh5T1kSg8PTKGwDwWXSb0hQELAgbq CaWAbL36ezpq0ifJdJI8LgULN35XaJNinvDFGlxFTZNGZUxIch8/tR7uzAFQRr54o4yn 01hg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=NgY0WzvQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dn12-20020a17090794cc00b00783023bb7b9si1365284ejc.72.2022.09.27.05.23.00; Tue, 27 Sep 2022 05:23:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=NgY0WzvQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231868AbiI0LUh (ORCPT + 99 others); Tue, 27 Sep 2022 07:20:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231906AbiI0LUN (ORCPT ); Tue, 27 Sep 2022 07:20:13 -0400 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81D0A46D85 for ; Tue, 27 Sep 2022 04:19:45 -0700 (PDT) Received: from zn.tnic (p200300ea9733e757329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e757:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id B70F61EC058B; Tue, 27 Sep 2022 13:19:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1664277579; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=sh92KicTDh4caqpKkqA808K5SVahDD/Q8fFa9qaLWr4=; b=NgY0WzvQkkzu5MW68ZDDIcuV4ZDbsPWHe6Ea6G6DMmWyYU9vEc9VIxat/9KrpbSzohoO4T I890t20ZAuG8NWX0e5bK82z7sN0jhVlFGhMPVsNeuLbkOhNcCTcI1IH2WjJPtBVx56jzmL C+FFp+HdbIyl//i7IKrn1bjLTVyW1Gc= Date: Tue, 27 Sep 2022 13:19:36 +0200 From: Borislav Petkov To: Juergen Gross Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" Subject: Re: [PATCH v3 08/10] x86/mtrr: let cache_aps_delayed_init replace mtrr_aps_delayed_init Message-ID: References: <20220908084914.21703-1-jgross@suse.com> <20220908084914.21703-9-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 27, 2022 at 12:14:42PM +0200, Juergen Gross wrote: > Yes: cpu hotplug. You might need to elaborate here. Because I see mtrr_ap_init() on the AP hotplug path: native_cpu_up-> do_boot_cpu-> start_secondary-> smp_callin-> smp_store_cpu_info-> identify_secondary_cpu-> mtrr_ap_init Which then means that we could check in mtrr_ap_init() if we're on the hotplug path and still get rid of that stupid bool... Close? -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette