Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759824AbXFVR1D (ORCPT ); Fri, 22 Jun 2007 13:27:03 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753775AbXFVR0y (ORCPT ); Fri, 22 Jun 2007 13:26:54 -0400 Received: from netops-testserver-4-out.sgi.com ([192.48.171.29]:36288 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751065AbXFVR0y (ORCPT ); Fri, 22 Jun 2007 13:26:54 -0400 Date: Fri, 22 Jun 2007 10:26:52 -0700 (PDT) From: Christoph Lameter X-X-Sender: clameter@schroedinger.engr.sgi.com To: Linus Torvalds cc: Hugh Dickins , Nicolas Ferre , ARM Linux Mailing List , Linux Kernel list , Marc Pignat , Andrew Victor , Pierre Ossman , Andrew Morton , Russell King Subject: Re: Oops in a driver while using SLUB as a SLAB allocator In-Reply-To: Message-ID: References: <467A4532.40301@rfo.atmel.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1193 Lines: 23 On Fri, 22 Jun 2007, Linus Torvalds wrote: > > Looks like it would indeed address the immediate issue on ARM - > > IF they've no particular reason to be using kmalloc there. > > I think the right thing to do is do both of these things. I already > applied Hugh's patch - it seemed like a total nobrainer to do at this > stage in the 2.6.22 -rc series. But that doesn't mean that we should not > _also_ look at "flush_dcache_page()" users. Hugh's patch not address the complete issue. It only works right now because the size of the allocation is page size and fits right into a slab page. If debugging is enabled then the slab size will increase and the "pages" will be misaligned which will lead to other sorts of funky behavior. kmalloc allocations are only guaranteed to be aligned to ARCH_KMALLOC_MINALIGN which is 4 to 8 bytes. If one must have a page aligned entity out of a slab allocator then a custom slab needs to be created. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/