Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp857553rwb; Tue, 27 Sep 2022 05:40:40 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6WIwHCSbJZUTM7LydmRm+Ki4OXjVJPjGRKOfDnvCW57Xjzljby2EUo+Me/Tmb9d+kIKUME X-Received: by 2002:a17:906:9b8b:b0:782:20fd:8597 with SMTP id dd11-20020a1709069b8b00b0078220fd8597mr22877650ejc.423.1664282438805; Tue, 27 Sep 2022 05:40:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664282438; cv=none; d=google.com; s=arc-20160816; b=NIja21KNbcME+eV7HbGXQktCJgErjS6EdQgSeg0ZrHCGrs5OAow5dc6ca0g6PUseCZ OEdHKZECGKdVrpkNkuSwBPnykhWGjkRQQCHcAIKRMyaJyG4t41vR2qmQpJW+ccVKbE5A 6Jakc++/ixdR5fw6fSUBAS0rmr7KMpAWpwRb6kMM/TFSvmArFjEuylNhIv6H9QiaFHZF wQEdjYkn2jg5ZOLbMRLlBcFxpH81m8rF8+hlX+N50vhLT1a/VtsWbF/0OpFl6FAWynno 2TbtNEnyZ6mD4LYb7HFcE/GVFDc7oD2ykc1+VD7bA/+PtXGReb1xp0pcgsDfbk7DTUjG XztA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=yVHW0yWvGrjjQAAvgwp/z0jQIf7u4pf8n1V+7zmn+d0=; b=yZr0S2nKFtIPNFidUluekZg3jdYyqkrOR6U+RxkmlUDibXs9kNJenxOiM9Mh08Dho1 IY4KCmLRqesZKmigoi7n7foAnFaTpT2goK+Bf4KDAKVdoUJ/y1ZYl/ZS6QSGq/lfMwOq dNRiuVPczlUqTNJlRaNNNQUzpwbUqyRuAidrB7Pxrp1Y2s9RVsUp1Yp2PNwU8G96qc9o eKJD+q9nKfv3puKpYI+jM21ve4f49eXITx57QstYmd3/t7zJad4THlrezfa3mmDwbYbu zgCXsungCOcLZ0lVqnMEJqa081nk8PGdhz0OZS743iGgQEvOj4GlUOjUYD6OBgthj3LW pzMw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g12-20020a056402320c00b004523826ed4asi1491661eda.572.2022.09.27.05.40.12; Tue, 27 Sep 2022 05:40:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232020AbiI0Mbl (ORCPT + 99 others); Tue, 27 Sep 2022 08:31:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45314 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230482AbiI0Mbg (ORCPT ); Tue, 27 Sep 2022 08:31:36 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AFE5B6EF00 for ; Tue, 27 Sep 2022 05:31:34 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id AFF0868AFE; Tue, 27 Sep 2022 14:31:30 +0200 (CEST) Date: Tue, 27 Sep 2022 14:31:30 +0200 From: Christoph Hellwig To: Liu Shixin Cc: Christoph Hellwig , Seth Jennings , Dan Streetman , Vitaly Wool , Andrew Morton , Nathan Chancellor , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kefeng Wang Subject: Re: [PATCH v5 2/5] Revert "frontswap: simplify frontswap_register_ops" Message-ID: <20220927123130.GA5549@lst.de> References: <20220915035003.3347466-1-liushixin2@huawei.com> <20220915035003.3347466-3-liushixin2@huawei.com> <20220920121305.GA4237@lst.de> <2b469a5c-7960-ca6a-9360-c7d3aa26e8ae@huawei.com> <20220927072754.GB16710@lst.de> <986efc9f-0deb-f705-dff1-f4d5992c2b8d@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <986efc9f-0deb-f705-dff1-f4d5992c2b8d@huawei.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 27, 2022 at 07:12:58PM +0800, Liu Shixin wrote: > If not do this, while some user enable swap device first and then enable zswap, > zswap will not take effect. The user need to re-enable the swap device which is > inconvenient. So load the module before swapping on, just like you'd load any driver before you expect to use it.