Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH v4 3/8] scsi: pm8001: use sas_find_attached_phy() instead
 of open coded
To:     John Garry <john.garry@huawei.com>, <martin.petersen@oracle.com>,
        <jejb@linux.ibm.com>
CC:     <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <hare@suse.com>, <hch@lst.de>, <bvanassche@acm.org>,
        <jinpu.wang@cloud.ionos.com>, <damien.lemoal@opensource.wdc.com>,
        Jack Wang <jinpu.wang@ionos.com>
References: <20220927032605.78103-1-yanaijie@huawei.com>
 <20220927032605.78103-4-yanaijie@huawei.com>
 <9e9f8384-0662-73ef-ab17-8420c94762fb@huawei.com>
From:   Jason Yan <yanaijie@huawei.com>
Message-ID: <cc8a0c09-03a2-c7e2-5f1a-c9b740315b70@huawei.com>
Date:   Tue, 27 Sep 2022 19:25:39 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <9e9f8384-0662-73ef-ab17-8420c94762fb@huawei.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 2022/9/27 16:34, John Garry wrote:
> On 27/09/2022 04:26, Jason Yan wrote:
>> +++ b/drivers/scsi/pm8001/pm8001_sas.c
>> @@ -645,22 +645,16 @@ static int pm8001_dev_found_notify(struct 
>> domain_device *dev)
>>       pm8001_device->dcompletion = &completion;
>>       if (parent_dev && dev_is_expander(parent_dev->dev_type)) {
>>           int phy_id;
>> -        struct ex_phy *phy;
>> -        for (phy_id = 0; phy_id < parent_dev->ex_dev.num_phys;
>> -        phy_id++) {
>> -            phy = &parent_dev->ex_dev.ex_phy[phy_id];
>> -            if (SAS_ADDR(phy->attached_sas_addr)
>> -                == SAS_ADDR(dev->sas_addr)) {
>> -                pm8001_device->attached_phy = phy_id;
>> -                break;
>> -            }
>> -        }
>> -        if (phy_id == parent_dev->ex_dev.num_phys) {
>> +
>> +        phy_id = sas_find_attached_phy(&parent_dev->ex_dev, dev);
>> +        if (phy_id == -ENODEV) {
>>               pm8001_dbg(pm8001_ha, FAIL,
>>                      "Error: no attached dev:%016llx at ex:%016llx.\n",
>>                      SAS_ADDR(dev->sas_addr),
>>                      SAS_ADDR(parent_dev->sas_addr));
>>               res = -1;
> 
> I think that you can just pass the linux error code (-ENODEV) back here.
> 
> And for hisi_sas we change to -EINVAL for this code. I don't think it's 
> required, so I think that we can pass -ENODEV back there also. Using 
> -EINVAL seems to come from when the code was originally added in 
> abda97c2fe874 and from a quick glance libsas does not seem to have 
> special processing for -EINVAL.
> 

Yes, libsas does not have any special processing for the return value, 
so there is no difference in what value we return here. But I agree with 
you that return -ENODEV is better here because we can keep it consistent 
with the return value of sas_find_attached_phy().

Will update.

Thanks,
Jason

> Thanks,
> John
> 
>> +        } else {
>> +            pm8001_device->attached_phy = phy_id;
>>           }
>>       } else {
>>           if (dev->dev_type == SAS_SATA
> 
> .