Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 27 Sep 2022 19:16:18 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     Hui Tang <tanghui20@huawei.com>
Cc:     naoya.horiguchi@nec.com, linmiaohe@huawei.com,
        akpm@linux-foundation.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/hwpoison: fix build error without
 CONFIG_MEMORY_FAILURE
Message-ID: <YzLpkmPrw0tbIo1W@debian.me>
References: <20220927102946.98622-1-tanghui20@huawei.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="7Fj09Ln2Ru7zIzIm"
Content-Disposition: inline
In-Reply-To: <20220927102946.98622-1-tanghui20@huawei.com>
Precedence: bulk


--7Fj09Ln2Ru7zIzIm
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Sep 27, 2022 at 06:29:46PM +0800, Hui Tang wrote:
> Building without CONFIG_MEMORY_FAILURE will fail:
>=20
> mm/memory-failure.o: In function `action_result':
> memory-failure.c: undefined reference to `memblk_nr_poison_inc'
> mm/memory-failure.o: In function `page_handle_poison':
> memory-failure.c: undefined reference to `memblk_nr_poison_inc'
> mm/memory-failure.o: In function `__get_huge_page_for_hwpoison':
> memory-failure.c: undefined reference to `memblk_nr_poison_inc'
> mm/memory-failure.o: In function `unpoison_memory':
> memory-failure.c: undefined reference to `memblk_nr_poison_sub'
> mm/memory-failure.o: In function `num_poisoned_pages_inc':
> memory-failure.c: undefined reference to `memblk_nr_poison_inc'
>=20
> Add CONFIG_MEMORY_FAILURE wrapper for invoking memblk_nr_poison_{inc|sub}.
>=20

Better say "Guard memblk_nr_poison_{inc,sub} under CONFIG_MEMORY_FAILURE".

--=20
An old man doll... just what I always wanted! - Clara

--7Fj09Ln2Ru7zIzIm
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCYzLpjQAKCRD2uYlJVVFO
o9YBAQD/LB+J7Ig7JbBnO41XhpCDYSN+JBqJiiG4joXsED0x/QEA5/tSHh66ldz1
3wWSJzbXTRZedc5ywsbxCA8SFsrLowE=
=+nSn
-----END PGP SIGNATURE-----

--7Fj09Ln2Ru7zIzIm--