Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp942581rwb; Tue, 27 Sep 2022 06:36:21 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4iJmMBbb4V2UZQcNYoFi6SInq8JVP073snA6TMVdbuEJga8c9DVxLDZvA6NmRXI9E9SVOv X-Received: by 2002:a17:902:c792:b0:178:2bd6:c429 with SMTP id w18-20020a170902c79200b001782bd6c429mr28221936pla.52.1664285781333; Tue, 27 Sep 2022 06:36:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664285781; cv=none; d=google.com; s=arc-20160816; b=swGc7zrNdrVvfaGgokSN+vr3oJgy8e5sXQnPRehuwP4dKIIzGwqRgKaqdAnwOhgB0s N929nHE7Gsn11nrOF9/H/FnTsP5JspSLwlDLoHxegZFGr2qcv9Tb85PPiW50MGzewUNT x0J3oZ79u/JHJ7/zcW+fbu1WPR/gpVKJW/SK2pBxUPPzUghxwjFofjTkYoP6rjUdRqxB Lq61/c6cqkcWetdnOHfUOhsqyBzjD65x+cqPsDWUjYm4xElSXeoNKqQU0KM263bTwznb b8WUuZGQ0lxkFPjHfgt2vTDqU8+zVb5pETQ/PBqOjncD2ng7rE3XciLyhsgrndR1BulB racQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=yfSPlcgi6Q06vy6sPZEaAaL6ZPWe4RIV8ryZHQWV7SU=; b=Z01jRSJLf6aqG/q1RsjsR23EuNw8vLShw7rT/FoboFLzo3Hh3V62VVNPDT2VUbhnwf SdaKu0cVwo0o3radLfm6WBQWvkSsOentYlP1RodSX5Sm6QX0TJKQPJiGGpuUb1sjv2v/ N/mIOOdNHNgRaBT9zxXGY8J5FwHqRUgFloJoB4Jqsw305eMJ92Wb01dX3Fsz0CbsPcpG sNLhiTxK8q/a3W0ustB1TUzWm59iYbfteQv/dG/1PRWnSlr/ZKJ9z3CWGQb/I/ii2W7q +8ggEXWIdTEiD7nIVY4HqDsTXIQfzirhyI/b6tXPiadTvnWfTpj5MdVAv5S7l6kMJ1Hf xBMw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="MPDcL/6x"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t3-20020a170902d20300b0017802d550b0si1752397ply.206.2022.09.27.06.36.08; Tue, 27 Sep 2022 06:36:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="MPDcL/6x"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231691AbiI0MXz (ORCPT + 99 others); Tue, 27 Sep 2022 08:23:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230446AbiI0MXt (ORCPT ); Tue, 27 Sep 2022 08:23:49 -0400 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E133246602; Tue, 27 Sep 2022 05:23:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664281428; x=1695817428; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=CjNzelJJb+xIQRdT8dfjXlqIMCpEnV3/rYeQ0cYNAdo=; b=MPDcL/6xA3IyvblIO0sMqv0OOTEfY7UcXLOn/NIrwah5t+q85loJyZqN 715qLlelFW63x5KD54Ax2IOTqyAH8ZqmvPWmTEsEiFuONpbSefSoKWpJ8 Y/ifjiTE4DgZKON5Q8Du4uVl4/BxdV10ExRN5+xNJo4+6tbuL93CWo2yp zJauxYrD9jptAkY9DNUpMypxCq1b4wohnDOdIm92Rw5mdJKZPQ2S1a7Fv 7XzogBgRwjyEnu02a9TATFyJUJ+GDxeoPyzLAz43NfBJPqX7mN4kbhPyu It3zThe2xU9YuF8xKKpkVsAylchsUeiJI/nNbHwfDVyLy4M/Xw1lzsuTC A==; X-IronPort-AV: E=McAfee;i="6500,9779,10482"; a="327659585" X-IronPort-AV: E=Sophos;i="5.93,349,1654585200"; d="scan'208";a="327659585" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Sep 2022 05:23:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10482"; a="621502083" X-IronPort-AV: E=Sophos;i="5.93,349,1654585200"; d="scan'208";a="621502083" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga002.jf.intel.com with ESMTP; 27 Sep 2022 05:23:45 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1od9cl-008ROg-1z; Tue, 27 Sep 2022 15:23:43 +0300 Date: Tue, 27 Sep 2022 15:23:43 +0300 From: Andy Shevchenko To: Dmitry Torokhov Cc: Jonathan Cameron , Lee Jones , Wim Van Sebroeck , Guenter Roeck , Lars-Peter Clausen , Tony Lindgren , linux-iio@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] watchdog: twl4030_wdt: add missing of.h include Message-ID: References: <20220927052217.2784593-1-dmitry.torokhov@gmail.com> <20220927052217.2784593-2-dmitry.torokhov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220927052217.2784593-2-dmitry.torokhov@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 26, 2022 at 10:22:14PM -0700, Dmitry Torokhov wrote: > The driver is using of_device_id and therefore needs to include > of.h header. This is incorrect. For of_device_id the mod_devicetable.h should be used. > We used to get this definition indirectly via inclusion > of matrix_keypad.h from twl.h, but we are cleaning up matrix_keypad.h > from unnecessary includes. -- With Best Regards, Andy Shevchenko