Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220927114515.GA22344@hcl-ThinkPad-T495>
In-Reply-To: <20220927114515.GA22344@hcl-ThinkPad-T495>
From:   Joel Stanley <joel@jms.id.au>
Date:   Tue, 27 Sep 2022 12:05:14 +0000
Message-ID: <CACPK8XdHaExSzdHpCXNzSEK7L-QDDSkz2rud3OynBC-KhEApFA@mail.gmail.com>
Subject: Re: [PATCH v6] ARM: dts: aspeed: Yosemite V2: Enable OCP debug card
To:     Karthikeyan Pasupathi <pkarthikeyan1509@gmail.com>
Cc:     Rob Herring <robh+dt@kernel.org>, Andrew Jeffery <andrew@aj.id.au>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
        openbmc@lists.ozlabs.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, 27 Sept 2022 at 11:45, Karthikeyan Pasupathi
<pkarthikeyan1509@gmail.com> wrote:
>
> Added IPMB-13 channel for Debug Card communication.
> which improves the readability of the machine and makes
> it easier to debug the server and it will display some
> pieces of information about the server like "system info",
> "Critical sensors" and "critical sel".
>
> Signed-off-by: Karthikeyan Pasupathi <pkarthikeyan1509@gmail.com>

Thanks, I've queued this.

Thanks Zev for your help reviewing.

> ---
> v6:
>  -Fix the commit format
>
> v5:
>  -Updated commit message
>
> v4:
>  -Resolved syntax error
>
> v3:
>  -Updated the title and commit
>
> v2:
>  -Updated the title
>
> v1:
>  - Initial draft
> ---
> ---
>  arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> index 8864e9c312a8..84236df522dc 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> @@ -215,6 +215,17 @@
>         };
>  };
>
> +&i2c13 {
> +       status = "okay";
> +       // Debug Card
> +       multi-master;
> +       ipmb13@10 {
> +               compatible = "ipmb-dev";
> +               reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
> +               i2c-protocol;
> +       };
> +};
> +
>  &pwm_tacho {
>         status = "okay";
>         //FSC
> --
> 2.17.1
>