Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp958894rwb; Tue, 27 Sep 2022 06:48:14 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7yzUxKAx6mU4W8RxAT/3eZIeDTDjAdAg8ispISu/mStCpZa+aHITp4PnCFLF3SeTCvUzGW X-Received: by 2002:a05:6a00:10c2:b0:547:4991:c984 with SMTP id d2-20020a056a0010c200b005474991c984mr29642646pfu.6.1664286494692; Tue, 27 Sep 2022 06:48:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664286494; cv=none; d=google.com; s=arc-20160816; b=iKrgyk09sN1JXHTNZ/HEtHlYB+OoJvGjnVnwUWBc58yirjGqgYDpmls5nP0ghBgCHg pNqJ2awbbMsZd+XUPCbrZIpQsSUIeQ0zUBlx6jlCy3pEykI+M/FesNEfNP/Zc2mSgQ0d FJzT8m3id6eelSLJnAzkkx5l8vdZWVr45vm4TKzb/Mvfp9y+V97+LzUt2d/mGKK6WEI3 0I34N4WkUfcV1HCbmcyOKEtvZ6HU+vXb3BBfCSh56EGl5ym5cHXOCdH5ARBIcKsmoPbH kbe8oUnERaiSPWQ1p1aNMD2SgJb5s4CX+kDgf2vIIYKRjeD2BZXrxzHlkFBDksL3+eE4 Ts1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=oCxezGhTS6BtnP7HEOFJ06Whai72Mr4vBMUR7ulIdWc=; b=rJ3pCAA3HGDK/S6Ht4JRhCesRxpVARQ4UKQnhO7/czBk4ds1/cdgU+oimUmpP4P1GF OU2mkzo0igbfa1JXPMsSeBhfjkVM4KUBWSA0CaWzVMBzj7hxJRPtLKaWIGfRIeGLpip2 wsYmCFmw2BX+YWPbU5DlUXKr5l9tE/kV1JzRFwzEayLJoILhhuIr9Xpfh/UqTR21t5Jm Y9QWxg5wS5Qvv5tbVqBipQ0k8mcksH2HhR/PHfJb4wEbINsCU/uVTgOV45Qo6qQ1xM5m L7vG/2lO/MKTaf+zB1mUv8BNbjKTuXxYZZe34QDnfgJsm1gKSSeNHS6D82xi2vNqACo7 wu5A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i4-20020a17090a65c400b001fad0e954cesi1946303pjs.32.2022.09.27.06.48.01; Tue, 27 Sep 2022 06:48:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231773AbiI0MSI (ORCPT + 99 others); Tue, 27 Sep 2022 08:18:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36612 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232254AbiI0MRd (ORCPT ); Tue, 27 Sep 2022 08:17:33 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40E0444574; Tue, 27 Sep 2022 05:17:31 -0700 (PDT) Received: from canpemm500004.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4McJTQ3FJYzpTqZ; Tue, 27 Sep 2022 20:14:34 +0800 (CST) Received: from huawei.com (10.175.127.227) by canpemm500004.china.huawei.com (7.192.104.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 27 Sep 2022 20:17:29 +0800 From: Jason Yan To: , CC: , , , , , , , , Jason Yan Subject: [PATCH v5 7/8] scsi: libsas: use sas_phy_addr_match() instead of open coded Date: Tue, 27 Sep 2022 20:39:25 +0800 Message-ID: <20220927123926.953297-8-yanaijie@huawei.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220927123926.953297-1-yanaijie@huawei.com> References: <20220927123926.953297-1-yanaijie@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.127.227] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To canpemm500004.china.huawei.com (7.192.104.92) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The sas address comparison of expander phys is open coded. Now we can replace it with sas_phy_addr_match(). Signed-off-by: Jason Yan Reviewed-by: Damien Le Moal --- drivers/scsi/libsas/sas_expander.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/libsas/sas_expander.c b/drivers/scsi/libsas/sas_expander.c index 9393ab83358c..38ed42b14fa0 100644 --- a/drivers/scsi/libsas/sas_expander.c +++ b/drivers/scsi/libsas/sas_expander.c @@ -2058,8 +2058,7 @@ static int sas_rediscover(struct domain_device *dev, const int phy_id) if (i == phy_id) continue; - if (SAS_ADDR(phy->attached_sas_addr) == - SAS_ADDR(changed_phy->attached_sas_addr)) { + if (sas_phy_addr_match(phy, changed_phy)) { last = false; break; } -- 2.31.1