Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220927045514.2762299-1-chenhuacai@loongson.cn>
 <e0efb8a9-b4b0-47bf-ab84-ea71c3630f9d@www.fastmail.com> <86tu4t6obg.wl-maz@kernel.org>
In-Reply-To: <86tu4t6obg.wl-maz@kernel.org>
From:   Huacai Chen <chenhuacai@gmail.com>
Date:   Tue, 27 Sep 2022 20:32:11 +0800
Message-ID: <CAAhV-H4shgJZ9_zazOVBpKVDw-x_d55Hwk0Muwqokt-W8-nLCQ@mail.gmail.com>
Subject: Re: [PATCH] irqchip: Make irqchip_init() usable on pure ACPI systems
To:     Marc Zyngier <maz@kernel.org>
Cc:     Arnd Bergmann <arnd@arndb.de>,
        Huacai Chen <chenhuacai@loongson.cn>,
        Thomas Gleixner <tglx@linutronix.de>,
        loongarch@lists.linux.dev, linux-kernel@vger.kernel.org,
        Xuefeng Li <lixuefeng@loongson.cn>,
        Jiaxun Yang <jiaxun.yang@flygoat.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Sep 27, 2022 at 7:37 PM Marc Zyngier <maz@kernel.org> wrote:
>
> On Tue, 27 Sep 2022 03:51:04 -0400,
> "Arnd Bergmann" <arnd@arndb.de> wrote:
> >
> > On Tue, Sep 27, 2022, at 6:55 AM, Huacai Chen wrote:
> >
> > > @@ -28,7 +28,9 @@ extern struct of_device_id __irqchip_of_table[];
> > >
> > >  void __init irqchip_init(void)
> > >  {
> > > +#ifdef CONFIG_OF_IRQ
> > >     of_irq_init(__irqchip_of_table);
> > > +#endif
> > >     acpi_probe_device_table(irqchip);
> > >  }
> >
> > I think that #ifdef should be in the include/linux/of_irq.h
> > header, with an empty inline function in the #else path.
>
> Agreed. Please keep the C code free of #ifdefs if at all possible.
OK, I will send V2 for that.

Huacai
>
> Thanks,
>
>         M.
>
> --
> Without deviation from the norm, progress is not possible.
>