Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <cfe05eec-f3bc-36bc-405f-b3355945ec51@quicinc.com>
Date:   Tue, 27 Sep 2022 18:50:43 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v8 6/7] remoteproc: qcom: Add efuse evb selection control
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        <linux-remoteproc@vger.kernel.org>, <agross@kernel.org>,
        <andersson@kernel.org>, <lgirdwood@gmail.com>,
        <broonie@kernel.org>, <robh+dt@kernel.org>,
        <quic_plai@quicinc.com>, <bgoswami@quicinc.com>, <perex@perex.cz>,
        <tiwai@suse.com>, <srinivas.kandagatla@linaro.org>,
        <quic_rohkumar@quicinc.com>, <linux-arm-msm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <swboyd@chromium.org>,
        <judyhsiao@chromium.org>, <devicetree@vger.kernel.org>
References: <1663938340-24345-1-git-send-email-quic_srivasam@quicinc.com>
 <1663938340-24345-7-git-send-email-quic_srivasam@quicinc.com>
 <da5902dd-1a2d-7669-fb91-c7df5bb1addb@linaro.org>
From:   Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
Organization: Qualcomm
In-Reply-To: <da5902dd-1a2d-7669-fb91-c7df5bb1addb@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 9/23/2022 10:55 PM, Krzysztof Kozlowski wrote:
Thanks for Your time Krzyszto!!!
> On 23/09/2022 15:05, Srinivasa Rao Mandadapu wrote:
>> Add efuse evb selection control and enable it for starting ADSP.
>>
>> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
>> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
>> Reviewed-by: Sibi Sankar <quic_sibis@quicinc.com>
>> ---
> Thank you for your patch. There is something to discuss/improve.
>
>> @@ -543,6 +549,17 @@ static int adsp_init_mmio(struct qcom_adsp *adsp,
>>   		return PTR_ERR(adsp->qdsp6ss_base);
>>   	}
>>   
>> +	efuse_region = platform_get_resource(pdev, IORESOURCE_MEM, 1);
>> +	if (!efuse_region) {
>> +		adsp->lpass_efuse = NULL;
>> +		dev_dbg(adsp->dev, "failed to get efuse memory region\n");
>> +	} else {
> This needs bindings updates in all users.

Actually this is being used in SC7280 platform only. I am not sure if it 
applicable for other platforms.

If required, it can be posted as new series after this series got main 
lined.

>
> Best regards,
> Krzysztof
>