Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220805154231.31257-2-ojeda@kernel.org> <Yu2cYShT1h8gquW8@yadro.com>
 <202208171235.52D14C2A@keescook> <Yv4AaeUToxSJZK/v@yadro.com> <202208180902.48391E94@keescook>
In-Reply-To: <202208180902.48391E94@keescook>
From:   Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Date:   Tue, 27 Sep 2022 14:48:19 +0200
Message-ID: <CANiq72nQJe4gHa2od3+MuRDbTQU7vvO1o9v1mHgmJcPST9VJZA@mail.gmail.com>
Subject: Re: [PATCH v9 01/27] kallsyms: use `sizeof` instead of hardcoded size
To:     Kees Cook <keescook@chromium.org>
Cc:     Konstantin Shelekhin <k.shelekhin@yadro.com>, ojeda@kernel.org,
        boqun.feng@gmail.com, gregkh@linuxfoundation.org,
        jarkko@kernel.org, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org, patches@lists.linux.dev,
        rust-for-linux@vger.kernel.org, torvalds@linux-foundation.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Aug 18, 2022 at 6:03 PM Kees Cook <keescook@chromium.org> wrote:
>
> Oh, that's an excellent point; I forgot it'll actually compile-time
> error if the var is a pointer. +1

In this case it doesn't, because `scripts/kallsyms.c` defines its own
`ARRAY_SIZE` that doesn't have the `__must_be_array`.

I have changed it for v10 anyway, since that way we may benefit in the
future if the `ARRAY_SIZE` here gains the check.

Cheers,
Miguel