Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 27 Sep 2022 07:22:49 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Christian Langrock <christian.langrock@secunet.com>
Cc:     Steffen Klassert <steffen.klassert@secunet.com>,
        <herbert@gondor.apana.org.au>, <davem@davemloft.net>,
        <edumazet@google.com>, <pabeni@redhat.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-ipsec v2] xfrm: replay: Fix ESN wrap around for GSO
Message-ID: <20220927072249.0e16c09f@kernel.org>
In-Reply-To: <fe554921-104e-2365-a09b-812a1cedac65@secunet.com>
References: <fe554921-104e-2365-a09b-812a1cedac65@secunet.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, 27 Sep 2022 14:59:50 +0200 Christian Langrock wrote:
> When using GSO it can happen that the wrong seq_hi is used for the last
> packets before the wrap around. This can lead to double usage of a
> sequence number. To avoid this, we should serialize this last GSO
> packet.

Does not build but please wait for reviews before reposting:

net/xfrm/xfrm_replay.c:773:6: error: conflicting types for =E2=80=98xfrm_re=
play_overflow_check=E2=80=99; have =E2=80=98bool(struct xfrm_state *, struc=
t sk_buff *)=E2=80=99 {aka =E2=80=98_Bool(struct xfrm_state *, struct sk_bu=
ff *)=E2=80=99}
  773 | bool xfrm_replay_overflow_check(struct xfrm_state *x, struct sk_buf=
f *skb)
      |      ^~~~~~~~~~~~~~~~~~~~~~~~~~