Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp1043595rwb; Tue, 27 Sep 2022 07:45:57 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5iqTH4mfycXgIUYU2NCD0bFoT561+nclFya6rZLgYaHtlfbZmQlqIU6XSUwi+FB5VH8UTm X-Received: by 2002:a50:d79a:0:b0:457:d209:c09c with SMTP id w26-20020a50d79a000000b00457d209c09cmr901473edi.14.1664289956998; Tue, 27 Sep 2022 07:45:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664289956; cv=none; d=google.com; s=arc-20160816; b=aewj4KpXHIWV8L6r/pucclapiaBBq8ayHxNF4CmiMPwhh6DVUjloh8a/grqTmaoYy8 cPcNfC6s0ncQAYsEIRE4In0Z92UkhqgdTMJEEWKSYReiw41ypITYQDtTpIEAMXec00x1 NEOOOK2c6kVlz/tNsfG8t7NANGAVuvop52+s5BOacJaGAGj9Nq09jBUlj7o2slz9ItAo 6OG7NDxhdeSCF/2xW+6OPV9HtTslCC8Qh064cal2l/b0RRM8gi4kmDDBT0EtJeGsOK21 UJ4L9GW1L7h9Tt44a47C021XBlL9O4u9Xh5p63mvE6VEG4vdIInX/GGouN3q52VMj6Ag Pqfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=7gCyUz8tGUngYdmFRNWTPdCGvdUrFoEBtlzOr30DYNY=; b=s3lS7j8B9+Mi01We0OsI5/1QspYWdzH/c7Z/xUyk+GN+gK09CcAgxZazekkP1l4bjI PoYoRTQRy4yoIryrIypxiNTYXxk9/SP6JjQh1z07Zmk8NMoOGFSyWuw/wA2m1l/Q52Ig 0Jl8+opO6UowBdiCqHgp4bogHsh090eOnDdNOq4jQ6qmgGIRrh78HrSxnY++7xvRoCC/ xPTwq+LSpxSezkNLY0YFEfuxAvnjWUWqzUzByFb4WygTZMlZhnMDhUFCYUySzjL48+JE oYDvrQSu+aRfNHkWJoqcTT22LdW77p+Uqgh5sW/Lls/fro3EtUG+UoP/xI2LKPAS2RDm r0hQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b="UW2s/qZB"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hv13-20020a17090760cd00b0077c2e4f3c39si1450886ejc.26.2022.09.27.07.45.29; Tue, 27 Sep 2022 07:45:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b="UW2s/qZB"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232345AbiI0NjK (ORCPT + 99 others); Tue, 27 Sep 2022 09:39:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231536AbiI0NjI (ORCPT ); Tue, 27 Sep 2022 09:39:08 -0400 Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54B29DC11E for ; Tue, 27 Sep 2022 06:39:06 -0700 (PDT) Received: by mail-qk1-x732.google.com with SMTP id y2so5984225qkl.11 for ; Tue, 27 Sep 2022 06:39:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=7gCyUz8tGUngYdmFRNWTPdCGvdUrFoEBtlzOr30DYNY=; b=UW2s/qZBxAVBGY+MFSKKB5elf/hxzNdxBsNu20+T2SpgNTk67eMpYqkVugVG8U3ylX Dy49yhrWIyG/5IBkTHkiPk+ctwBFvXRLHRxsCVfR7TEksPXPSHOdlu1oDx/AgLViyYXH uJ73vl2c9EXmpWHAvRiCoStt8OXSWmgBRRGijYllDfwhoeszoyccGU7fA9EecgvrZDQC uAe0PlyDotDavra+zymnGBl0zzPYdwN4911g2e3eyc+J9rvUASGza5w0dA5jRkU9NPmD 2AUa+Zkkjm255oqJLY073Sp3quQww+2aPFuAhW9KZlCPII/WPaP4LXob958tDx3sVWoI I1FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=7gCyUz8tGUngYdmFRNWTPdCGvdUrFoEBtlzOr30DYNY=; b=nAkz+5qV+7RNbMW38n1hSK1P95nG8HpMWeQjtj03E3K/qvun/t24yct27/PvJx0naM uHEVqtjl9ALMiu33jFCW9dfeyeel0DDQHNk2Ppc8G5gmN/4FXG6eBME42vhhYWZF7cUv C+WtcPVa2+kIT4C3YsD36Z8kaKn0QyvtvsGST5sRkm+36ex7XEklL/Zl9GtYozEzfPii oLWW52m8vpqtI/k3Gp9zKuBufKoyVIT8f9iP8NuX2UKmPhxx/vj+X1YZgt0jH4Ly8XHf y/3oZtW2pk0ss+w4tOxRzeB8gHgNEFj5BpdKfUJrJuIY4wLTk4rZAF8LqMyZBz7OrvXY AxDQ== X-Gm-Message-State: ACrzQf0GwIwi5EYf0KO9tydAQUVgKQU8m0nBrYhDp8LOSkETpFJ1p+1q du1s0ERT6NQdeZsydqDfYxbPOA== X-Received: by 2002:a05:620a:2043:b0:6ce:6035:9f51 with SMTP id d3-20020a05620a204300b006ce60359f51mr18004440qka.18.1664285945538; Tue, 27 Sep 2022 06:39:05 -0700 (PDT) Received: from localhost (2603-7000-0c01-2716-9175-2920-760a-79fa.res6.spectrum.com. [2603:7000:c01:2716:9175:2920:760a:79fa]) by smtp.gmail.com with ESMTPSA id bp12-20020a05620a458c00b006b9c9b7db8bsm955223qkb.82.2022.09.27.06.39.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Sep 2022 06:39:04 -0700 (PDT) Date: Tue, 27 Sep 2022 09:39:03 -0400 From: Johannes Weiner To: Chengming Zhou Cc: surenb@google.com, mingo@redhat.com, peterz@infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sched/psi: Use task->psi_flags to clear in CPU migration Message-ID: References: <20220926081931.45420-1-zhouchengming@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220926081931.45420-1-zhouchengming@bytedance.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 26, 2022 at 04:19:31PM +0800, Chengming Zhou wrote: > The commit d583d360a620 ("psi: Fix psi state corruption when schedule() > races with cgroup move") fixed a race problem by making cgroup_move_task() > use task->psi_flags instead of looking at the scheduler state. > > We can extend task->psi_flags usage to CPU migration, which should be > a minor optimization for performance and code simplicity. > > Signed-off-by: Chengming Zhou Nice one! Acked-by: Johannes Weiner