Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp1059218rwb; Tue, 27 Sep 2022 07:58:13 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5Sm9ulCa61mSJBrHDGD9i8QoyiKirXhKOzxKPI55NtmxJvnGnZ0Ny07pg/DY4wPlK+kzeP X-Received: by 2002:a17:907:3f99:b0:782:4605:530e with SMTP id hr25-20020a1709073f9900b007824605530emr23790360ejc.108.1664290692853; Tue, 27 Sep 2022 07:58:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664290692; cv=none; d=google.com; s=arc-20160816; b=YTHM0CvXUsjSifweJ2i5uzBW6frxBWJ+ajDQfnjB3KHXPVud8Hd6wqxn3EAjznhI1c QxHBabN9+Eff6odYzV5pGHQfEccziGoN0EnyxtxlHRs9m+l0V96R4VfltL4N4DAuDUtG K7cEQTwP54APsK2T8/P9yOyIqmPPXCqjfjbhVhiINiCSdO2T5Tu8ny+RfoHhvWyyJj2v G+/VPlAFxn4dwwF1sGz/u3R4oxlC1Bg/IoWyqDh6c65oxwf+TTSCjp/7ge+DUJ7AG4NB 2ggfAbLwf1zPaQByvwGXBkorx/UlbPb+osoCc7SoEPYfbGwxeEl9rpfH2/4Pe6zDVbL3 aWEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=DyaVo3+lMzTcUfudleYugyX5eghJmiI4XJiWCxqbggY=; b=vBhCgLUL/WPbBBXGM09jbsOoehhnG7rqmDpQG9ygsOG1DPphc1eh+xQEIzUtYMr/rf /f6Q/VDOb3cbWkVngz4mpV/5mDShmdQcdqrAqASUF2CdrE4jN0YGNqMp7XbV07iMONfV 13ZWfWyBHyPu+onbu4eDVCSFI1XrVEgj70UCuznnvwSD0Gfk6hMsSFgGCvpL+MuUDloy uP43qhZyHKuh+6bx9psKLBhs8GA5yOFX0IcbGnzLWvS78V8DBkH8Zax77gSwlkBf46D8 Z2YJ83ygxdPvcj+cs+EvvDozVyWYLqa5ioImvC2rvwS6LMkek1/GmNUeh8FQScBHRaTu RQqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="LHvf/mqn"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t9-20020aa7db09000000b0045729070194si1660973eds.517.2022.09.27.07.57.46; Tue, 27 Sep 2022 07:58:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="LHvf/mqn"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232936AbiI0OC1 (ORCPT + 99 others); Tue, 27 Sep 2022 10:02:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232947AbiI0OB5 (ORCPT ); Tue, 27 Sep 2022 10:01:57 -0400 Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9C77AED8F; Tue, 27 Sep 2022 07:01:12 -0700 (PDT) Received: by mail-io1-xd33.google.com with SMTP id r134so7785141iod.8; Tue, 27 Sep 2022 07:01:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=DyaVo3+lMzTcUfudleYugyX5eghJmiI4XJiWCxqbggY=; b=LHvf/mqnPOMJ9jL0cy3ik7mshxI0ktIgXgIZoGbE6+/5menga1hXjWEhRj3thykjNN sRWPJ1QHAGtJOAHY8uu3J1KEyWSoo5h/5Wfzh3VzCDHmwddRTwI/r+shjRPDZe63NXtz xOg9cMpBfPxLEM3CjTMDUZ+xL8OP6MJe8V0SPvic6/XvtQBRGHfzXXSvV8qRklW5DPjN /E6CZhL9ixRoUP+7fH0XSAU0Ur9A40X2dPhWAF0NvnpM6pLtlWYWVXbfJFD68kHAvHXf K57n4DCCeruRap/T2pjq2IvqrdBsPEcQAXBpo+W0sF/8xKkMtlQ/bKLv6l4kEey7ziTw WIQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=DyaVo3+lMzTcUfudleYugyX5eghJmiI4XJiWCxqbggY=; b=DitJuluI12am1Vw2VGxPhxib0JoBIKddDhidoHE2xulPiCRJktWta5xvUnVZ0PxdrW B+X7sCt+2OzJKzzsFpBbUMTmNOrXi1O8AfdyIPuWemEEpWXbXS9IzA9vB6aHFcDDPkTa GkpixVTnvzH8jg2qLggwMX3NDvf+Xt+Y1cM4s2cSaqlbALXfkWQtTyOqPSRf0DobmqT4 x2sJgRT9vSUsyU/cawtC0vZ/V33KzLENg54D4gi06ohV/zCuV6CbLwdXQhzZh3o3Ylmp UULL2vY809G40P/9Yy/RPyPhNqrPD64Cae+GgHKRWvpl58a/Dr5K/e4ffLEDlS+2KtW3 yLtg== X-Gm-Message-State: ACrzQf00MSgUIbkDQaWv9VzOo8D4SvmkBYrooXDDoH7zhYL6A9CPP7Ih /Ylvlhena5fe0uj77LKeBAkqH5Z6ShHk/ExLGo0= X-Received: by 2002:a6b:6f11:0:b0:69f:db1b:f4a7 with SMTP id k17-20020a6b6f11000000b0069fdb1bf4a7mr11582661ioc.177.1664287271842; Tue, 27 Sep 2022 07:01:11 -0700 (PDT) MIME-Version: 1.0 References: <20220927131518.30000-1-ojeda@kernel.org> <20220927131518.30000-11-ojeda@kernel.org> In-Reply-To: From: Miguel Ojeda Date: Tue, 27 Sep 2022 16:01:00 +0200 Message-ID: Subject: Re: [PATCH v10 10/27] rust: add `macros` crate To: Konstantin Shelekhin Cc: Miguel Ojeda , Linus Torvalds , Greg Kroah-Hartman , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, patches@lists.linux.dev, Jarkko Sakkinen , Alex Gaynor , Finn Behrens , Adam Bratschi-Kaye , Wedson Almeida Filho , Sumera Priyadarsini , Gary Guo , Matthew Bakhtiari , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Boqun Feng Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 27, 2022 at 3:48 PM Konstantin Shelekhin wrote: > > I remember that there was a switch from &u8 to &str on master branch a > while ago. Why this patch was reverted? Strings are really better here. It was not reverted; but it was merged right after v8. Then v9 was a trimmed v8 and v10 is intended to resolve a few last nits from v9. In other words, there are many changes (including the vast majority of the `kernel` crate) that will come afterwards. Please see the cover letter(s) for details. Cheers, Miguel