Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 27 Sep 2022 16:11:27 +0200
Message-ID: <87ill8gb5c.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Brent Lu <brent.lu@intel.com>
Cc:     alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Kai Vehmanen <kai.vehmanen@linux.intel.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        Mohan Kumar <mkumard@nvidia.com>,
        Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= 
        <ville.syrjala@linux.intel.com>, Yong Zhi <yong.zhi@intel.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/hdmi: run eld notify in delay work
In-Reply-To: <20220927135807.4097052-1-brent.lu@intel.com>
References: <20220927135807.4097052-1-brent.lu@intel.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Tue, 27 Sep 2022 15:58:07 +0200,
Brent Lu wrote:
> 
> During resolution change, display driver would disable HDMI audio then
> enable it in a short time. There is possibility that eld notify for
> HDMI audio enable is called when previous runtime suspend is still
> running. In this case, the elf nofity just returns and not updating the
> status of corresponding HDMI pin/port. Here we move the eld nofity to
> a delay work so we don't lose it.
> 
> Signed-off-by: Brent Lu <brent.lu@intel.com>

We have already a dedicated per-pin work for the delayed ELD check.
Can we reuse it instead of inventing yet another work?
More work needs more cares, and better to avoid unless really needed
(e.g. you forgot cleanup at suspend/removal in this patch).


thanks,

Takashi