Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b7cc392b-448d-ad40-f915-4b4e4b8c232b@gmail.com>
Date:   Tue, 27 Sep 2022 09:57:50 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH net-next v2 07/13] sunhme: Convert FOO((...)) to FOO(...)
Content-Language: en-US
To:     David Laight <David.Laight@ACULAB.COM>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc:     Nick Bowler <nbowler@draconx.ca>,
        Rolf Eike Beer <eike-kernel@sf-tec.de>,
        Zheyu Ma <zheyuma97@gmail.com>,
        open list <linux-kernel@vger.kernel.org>
References: <20220924015339.1816744-1-seanga2@gmail.com>
 <20220924015339.1816744-8-seanga2@gmail.com>
 <9412f706a4934d218019d74c5f4b74ae@AcuMS.aculab.com>
From:   Sean Anderson <seanga2@gmail.com>
In-Reply-To: <9412f706a4934d218019d74c5f4b74ae@AcuMS.aculab.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/27/22 03:58, David Laight wrote:
> From: Sean Anderson
>> Sent: 24 September 2022 02:54
>>
>> With the power of variadic macros, double parentheses are unnecessary.
>>
>> Signed-off-by: Sean Anderson <seanga2@gmail.com>
>> ---
>>
>> Changes in v2:
>> - sumhme -> sunhme
>>
>>   drivers/net/ethernet/sun/sunhme.c | 272 +++++++++++++++---------------
>>   1 file changed, 136 insertions(+), 136 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/sun/sunhme.c b/drivers/net/ethernet/sun/sunhme.c
>> index 7d6825c573a2..77a2a192f2ce 100644
>> --- a/drivers/net/ethernet/sun/sunhme.c
>> +++ b/drivers/net/ethernet/sun/sunhme.c
>> @@ -134,17 +134,17 @@ static __inline__ void tx_dump_log(void)
>>   #endif
>>
>>   #ifdef HMEDEBUG
>> -#define HMD(x)  printk x
>> +#define HMD printk
> 
> That probably ought to be:
> 	#define HMD(...) printk(__VA_ARGS__)
> 
> (and followed through all the other patches)

The final macro is

#define hme_debug(fmt, ...) pr_debug("%s: " fmt, __func__, ##__VA_ARGS__)
#define HMD hme_debug

so I think that satisfies your comment.

--Sean