Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp1075304rwb; Tue, 27 Sep 2022 08:07:41 -0700 (PDT) X-Google-Smtp-Source: AMsMyM58gTePOlSFu5aMHWkgU42UGrzfsHN3AkG/qBp9aPPQ/No9IqT269QdQHHgUSv2Hg67ASSg X-Received: by 2002:a17:906:478d:b0:783:2270:e85a with SMTP id cw13-20020a170906478d00b007832270e85amr12624029ejc.371.1664291260894; Tue, 27 Sep 2022 08:07:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664291260; cv=none; d=google.com; s=arc-20160816; b=Om0fsq710298eu75cnmQ/coWtNS333iQm7CY2479F3tmu8/HU/clCGvxIjxtyCL/lh da/ZySb6trGw0LzizOM92vA9ZILTGLRnT/LuqZ4qbCTvChmZNXcCDocct854v81pKU9V A0ZAfHQuUwSpYL46oisj+KMatCKNzr4dropS7pgZolhWBsg7wEseg01K6OYKnR0BFs4D dkzxsYQMUtDo9QZ9DaHs3QWoV5WwED1V93LhOAkXgN7I5DYygJlWHivnNwhrYTf1C4cd JXlp35REhU+v0Bw3MQEAWnfzhGI1YKY5bGCR0WQOll93E7iN5Mw+Ogc7VA3aKlCvqjkZ 1qog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=PZNlZ2C756uJRJMDH4/KGIIuWeg1+p17CQ3SGX5Tyo0=; b=dIJegnWXul9Gum9mJHCDtlK0cZCprEzkoPAn13+yCZgnuf9SyWBKpUMF4GYwkyMHy+ 1uwbenuVNDzIlIoYK6CaRcTvAyCjhLo0O6r7BC/X8LHSzsW6v7Q4C4V/qa73sgcdWYzA diwGiLOxPJTYtZkXenfTELtR0zT3rhyPfPQxM6lpwrj3mU3Xf+DUE1pl5yaWZ57Iy5Ya IM9nc2zYDrMU0pQ3kVF+c9Ni9Cw9SRmh2h2+0UQrHGRLuNEAnJrfZhcGjJ0AQQzEpwvR zgf540A86TLDc7rs8e36xL74fOS2tqU2hDU6WS6D0ng4XP/G8ham60kHvRD+dyjCXros nPmw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lo23-20020a170906fa1700b007708400bee5si1244262ejb.1003.2022.09.27.08.07.11; Tue, 27 Sep 2022 08:07:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231797AbiI0PEd (ORCPT + 99 others); Tue, 27 Sep 2022 11:04:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231802AbiI0PE0 (ORCPT ); Tue, 27 Sep 2022 11:04:26 -0400 Received: from sym2.noone.org (sym.noone.org [IPv6:2a01:4f8:120:4161::3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FE33E7E33; Tue, 27 Sep 2022 08:04:23 -0700 (PDT) Received: by sym2.noone.org (Postfix, from userid 1002) id 4McNFK30KPzvjfm; Tue, 27 Sep 2022 17:04:21 +0200 (CEST) Date: Tue, 27 Sep 2022 17:04:21 +0200 From: Tobias Klauser To: Jiri Slaby Cc: gregkh@linuxfoundation.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] tty: serial: unify TX space reads under altera_jtaguart_tx_space() Message-ID: <20220927150420.nqzvgbs43etwpuxd@distanz.ch> References: <20220927111819.18516-1-jslaby@suse.cz> <20220927111819.18516-3-jslaby@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220927111819.18516-3-jslaby@suse.cz> User-Agent: NeoMutt/20170113 (1.7.2) X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,SPF_HELO_NONE,SPF_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022-09-27 at 13:18:18 +0200, Jiri Slaby wrote: > TX space reads from the control register are performed in various forms > on 4 places in altera_jtaguart. Unify all those and do the read and > masking on a single place. > > The new helper altera_jtaguart_tx_space() uses FIELD_GET(), so we can > drop ALTERA_JTAGUART_CONTROL_WSPACE_OFF now. > > Cc: Tobias Klauser > Signed-off-by: Jiri Slaby Acked-by: Tobias Klauser Thanks