Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 27 Sep 2022 08:05:23 -0700
From:   Richard Cochran <richardcochran@gmail.com>
To:     Bo Liu <liubo03@inspur.com>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ptp: Remove usage of the deprecated ida_simple_xxx API
Message-ID: <YzMRM0jwh+fauIWz@hoboy.vegasvil.org>
References: <20220926012744.3363-1-liubo03@inspur.com>
 <YzMQSJtLA1LDMGOm@hoboy.vegasvil.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YzMQSJtLA1LDMGOm@hoboy.vegasvil.org>
Precedence: bulk

On Tue, Sep 27, 2022 at 08:01:28AM -0700, Richard Cochran wrote:
> On Sun, Sep 25, 2022 at 09:27:44PM -0400, Bo Liu wrote:
> > Use ida_alloc_xxx()/ida_free() instead of
> > ida_simple_get()/ida_simple_remove().
> > The latter is deprecated and more verbose.
> 
> I can't say that I am excited about this.  It seems like a way to
> create a regression.  I don't see any need to change.  After all,
> there are many "deprecated" interfaces in use.

/git/linux$ git grep ida_simple_get | wc -l
119

~/git/linux$ git grep ida_simple_remove | wc -l
169

Please go take care of the other 100+ users of this API first, then
come bother me again.

Thanks,
Richard