Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp1139731rwb; Tue, 27 Sep 2022 08:56:30 -0700 (PDT) X-Google-Smtp-Source: AMsMyM60M36D9PgPOyLb1N2Mo2KRlt/rLqJB/JOkePLItZFv74V8s54PPL7+55tMxr+oxov92mVa X-Received: by 2002:a17:90b:3745:b0:205:e53a:41d8 with SMTP id ne5-20020a17090b374500b00205e53a41d8mr1140263pjb.11.1664294190613; Tue, 27 Sep 2022 08:56:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664294190; cv=none; d=google.com; s=arc-20160816; b=zAuCGwhStFc3L3aicPhZqLk8o8xkYh7TYohMnhH5vzPqjmj27NnKTVilQ6mnjN93Dl N1j0Fza8ZkSPnhRW8Z0duQSq/XFJhKnZVtcq8k0v5qfO8HfNP/pv23UwB4fH/KhOdtLx EKM9IVFNglUVO0SlfpszCrdJfDBJyxB+P+4qg1cURHLS+g5FJInfvyzMpSnEbSHq4vvE gvwdlhVOCbH2CSeZfnZueyFfA9w96D00kBjZn8xZGGb8ytSi/dMnEhx2Qqvdx8eApx+D InHXQIw+pH+pw1w11SKU4bA05ZZ7FuwSXqqdfoxKrf5Jhu5FwqK7ku/6AasCJxtFYVNf iQzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=H3yluee7rCYkUwaM/DwwBarglWSaBMbcI728FxgdQJI=; b=siJIig1Tq/VvWgvS4BH+UXmm2FpcoF2x0Av3FOD1Mz+adB2JH0ZV7yOhUlIsHF9dVT Fro3nhs7XZWpZqvHc897I+5fBdqsZsR7YQoDfhMK/KpPB6YhuJx292VJwcxrygbrolc+ VE5Nx5eKESahAlew/CWmPxRrh1+tfj3FCo6R9BuK6pmHzyv+pJBEDAxwQT6BcXZJt336 /5OhSsw5V4afHGtIIbCNA4kF0uaX+kE08o8wvPe+wJzzGYuzK8fajcyuyD5cVCfWaigE p7imnn9THvSs+Ejf8+EU/v1A+OfzBAy07nyqEKCBpJMPhqHs5gA7Fr3NNxobRWjdXGVK nycw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 17-20020a631851000000b004344ef377a6si2067028pgy.660.2022.09.27.08.56.17; Tue, 27 Sep 2022 08:56:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230305AbiI0O7f (ORCPT + 99 others); Tue, 27 Sep 2022 10:59:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229453AbiI0O7d (ORCPT ); Tue, 27 Sep 2022 10:59:33 -0400 Received: from sym2.noone.org (sym.noone.org [178.63.92.236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AFC514F6A6; Tue, 27 Sep 2022 07:59:29 -0700 (PDT) Received: by sym2.noone.org (Postfix, from userid 1002) id 4McN7g3kfyzvjfm; Tue, 27 Sep 2022 16:59:27 +0200 (CEST) Date: Tue, 27 Sep 2022 16:59:27 +0200 From: Tobias Klauser To: Jiri Slaby Cc: gregkh@linuxfoundation.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] tty: serial: do unlock on a common path in altera_jtaguart_console_putc() Message-ID: <20220927145926.o7j5ga5u3tq7hlxg@distanz.ch> References: <20220927111819.18516-1-jslaby@suse.cz> <20220927111819.18516-4-jslaby@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220927111819.18516-4-jslaby@suse.cz> User-Agent: NeoMutt/20170113 (1.7.2) X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,SPF_HELO_NONE,SPF_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022-09-27 at 13:18:19 +0200, Jiri Slaby wrote: > port->lock is unlocked in each branch in altera_jtaguart_console_putc(), > so do it before the "if". "status" needs not be under the lock, as the > register was already read. > > Cc: Tobias Klauser > Signed-off-by: Jiri Slaby Acked-by: Tobias Klauser Thanks