Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH net-next v5 1/9] dt-bindings: net: Expand pcs-handle to an
 array
To:     Rob Herring <robh@kernel.org>
Cc:     "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Madalin Bucur <madalin.bucur@nxp.com>,
        Camelia Alexandra Groza <camelia.groza@nxp.com>,
        netdev@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Russell King <linux@armlinux.org.uk>,
        "linuxppc-dev @ lists . ozlabs . org" <linuxppc-dev@lists.ozlabs.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        devicetree@vger.kernel.org
References: <20220926190322.2889342-1-sean.anderson@seco.com>
 <20220926190322.2889342-2-sean.anderson@seco.com>
 <20220927153331.GA4057163-robh@kernel.org>
From:   Sean Anderson <sean.anderson@seco.com>
Message-ID: <44db6758-2f81-0374-809f-9db0cf2f2e33@seco.com>
Date:   Tue, 27 Sep 2022 12:27:35 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
In-Reply-To: <20220927153331.GA4057163-robh@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aStVZkZsRmlyNzAzRG5CZzZ2eWd2ZitabVd4YjcvME9hVWhpVFNYWmxMUDFZ?=
 =?utf-8?B?SU9CU0xlK1Ivb1IrUnd2MGhyWksvVUhIa1JLaUdzYmkydUZIYVZmNjExcVpu?=
 =?utf-8?B?K0l1c1ZvV0ovSjZsQVFFMUUzZU1QOG4rVVlDMWlaTHRtdzNJR0VwdkZiQ2xq?=
 =?utf-8?B?MFgwUG1pZ2pVdTBZTGt4dzd2TGNMZmcxNHkwWnNhTko3V044cGhNRVlldWg2?=
 =?utf-8?B?M1RuMXFuWlBPUHNrandtTGVNVVZxL1JXUm1jMEdvdTAwWE93VVJuSGhEbzU3?=
 =?utf-8?B?NVUzMEJYSU9qSWVLQ0J0RDRlOXZzNEJCWE1ZUlkzaGRNOTBXRFAzaXFCakND?=
 =?utf-8?B?Wmp1R1lmQnRveDlFUEl1QzBmaEpHU3ZLaURDTU1YRFNJaEJMMk15aFRvYTFW?=
 =?utf-8?B?YWxpOUlrN3YrZStxZHRpQkFDKzRIZ3VCdkxzaEFjUURxOE1iekVLeTl5OEtG?=
 =?utf-8?B?b3FWeHBTSG1iaDIwc1F3djNTSDVoQUx4eXd6TGcwWVU1ZC8yQ3o3WnVXc2V0?=
 =?utf-8?B?bHFjaUd4RHd5RGlGMEJhU21ycVp1NVZ3WGdmRXVjS0pWWGtKU09TMjQyS1Yw?=
 =?utf-8?B?VVI5SUM0MDFVVmdTNkdTU256bW1mcDhNUG1tenZrZEdQRy83a2gxTXRKc1hn?=
 =?utf-8?B?Z3J0eFlsblFWamdtTDZEbVlJcXRQUkNFYVNzVXkxazFGaUtCa2ljVXowK1Rw?=
 =?utf-8?B?YmV2ZVZrVTR3dU1FS1F4ZmVjeVJ0c1k5M3FIYU83cG5HTHJFR2QxSEM3VDFO?=
 =?utf-8?B?WVpIK0JYaWo1WFZIWUhhNVVHYmZWQzRKK2lZSW90bnZLd1E2dG5sVThVL1ky?=
 =?utf-8?B?NE1jKzB1WTUvWDNXQjdEYjdBa1M4Q1N1SFFnMzRXK2ZxTDhtM3QxeE44UVB3?=
 =?utf-8?B?KzBnZTBucWVzcmxtekJjYm03U0pnU3IwQlQ3MFFtQjAyRTNITWNrazFiYVBL?=
 =?utf-8?B?Mnp0endaeEJCb2k5Vk5BajlwTkE1UVNqcDI1OWlTU3NuVFhpS1JCNHBmM0hO?=
 =?utf-8?B?S1NKNko1dkVtWFFqYyt0UW5MaGNpdTByWURrRm9WK3lKM2NqSDQySFFRaTVL?=
 =?utf-8?B?dG9ucFV6RmR6V2I3bnlDSHFxZmE2b2ZLcEEvUm01THp6Qlg1ZExvODdnTTBE?=
 =?utf-8?B?ajgxSVFGK3pwajljMDZ1VStjNEt0ZGV2czhzQjZtZ2I1dk5neGhxNlowQmpv?=
 =?utf-8?B?Y0o2SjNMQnhLakZ5a3RLQVl6ZHBoV0ZNRkoybDg4SVMwR21QR0NzVFpPWXM1?=
 =?utf-8?B?aHorRHR6MTRWRXlpQTJEaVVPSVBjNGZJRGhtN1JTQkhiYmZ2cUdEQ1JZWjAr?=
 =?utf-8?B?NnRMcVFpUXJ5THFOKzR4Vy90cUk1eWtXQkpIcGx5MDk4YTBjNzdjVDhKakhR?=
 =?utf-8?B?aGV0MGtvVUlZMm16N2RuSm9lRGIzNGNkVGZZV05IeWxLL3FMaW9jZzRGbWtl?=
 =?utf-8?B?V2pUWlZraGIzRXhIM3grRWdWeW8wYVUrQmE4bnAvVzQ1elpIcWV5MEhOaW1M?=
 =?utf-8?B?UXVQeXBtSzRNMC9ZZjVkVytGYWg1dmRaYmpuWFB0bHRidmw0REswSmJrTFdC?=
 =?utf-8?B?L2V3YlNLNWhjUFh6V0paTllIQlRYbWhIUCtxcGR3M1FDTWhtSkp2RzFwc1E5?=
 =?utf-8?B?bEs0ZW9GUnN3bEwrODNQR3Z6L1Y4Qld2RHd3V2xKblEvTG9KZWZMc1d3dis1?=
 =?utf-8?B?OE4vQlNnN3NtWkRsQ1BNUm5mS3M1STUwQ1B6ZzBWaWlHckZzRVQzZWlWV1gy?=
 =?utf-8?B?dnZjSmV6ajJXNHBNUmljT0FNYlYreDhKV2ZEOUtoUFJwNE5yQ1VxWkxDYVRi?=
 =?utf-8?B?ZmNRYzRzcjBRU05wbVFiMTBoV3N3TUV2QUZYYkovdVVQVUNlT2RpMVMrTUJt?=
 =?utf-8?B?QStUSjZhLzA4OUZ5emtmNVlxOHpLdVBmVlRmTWJ0NldpdWxpNnpOZ2RhUFda?=
 =?utf-8?B?MU10U203UHI0ekF0L2p2cGVkU3pKNEhaWHM0WGUvVHFENVdFQ283UnU0NFZD?=
 =?utf-8?B?T1g1Q1k2MTFjaXh1bFJERkRrLzJJalAwNFp5WVNKREtmTEc5VkJIbkNtdnNn?=
 =?utf-8?B?WEpBS25rQThTZjdsaXNuQnc2L0pDWHhxOVlRK1NTTlUzaDB4cmhyK3pSK3l4?=
 =?utf-8?B?QUVRb3RFdFlsczBHcE5OV09lQ3BwdmxVQUdGMnhqNkl3Y0tqTFNXajNCUnZP?=
 =?utf-8?B?Znc9PQ==?=
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7dfcdfcf-0284-40ca-afaf-08daa0a5323e
X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4972.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 16:27:40.0925
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NST3vpq+ps/r8O2nvfn8yYbX8fMrzORyM2vGjAnRttogrzXn4CD181X9AssqvvjmN/ZGkpIXpKfGANGJ+tKs3A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR03MB6890
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 9/27/22 11:33 AM, Rob Herring wrote:
> On Mon, Sep 26, 2022 at 03:03:13PM -0400, Sean Anderson wrote:
>> This allows multiple phandles to be specified for pcs-handle, such as
>> when multiple PCSs are present for a single MAC. To differentiate
>> between them, also add a pcs-handle-names property.
>> 
>> Signed-off-by: Sean Anderson <sean.anderson@seco.com>
>> ---
>> This was previously submitted as [1]. I expect to update this series
>> more, so I have moved it here. Changes from that version include:
>> - Add maxItems to existing bindings
>> - Add a dependency from pcs-names to pcs-handle.
>> 
>> [1] https://lore.kernel.org/netdev/20220711160519.741990-3-sean.anderson@seco.com/
>> 
>> (no changes since v4)
>> 
>> Changes in v4:
>> - Use pcs-handle-names instead of pcs-names, as discussed
>> 
>> Changes in v3:
>> - New
>> 
>>  .../bindings/net/dsa/renesas,rzn1-a5psw.yaml           |  1 +
>>  .../devicetree/bindings/net/ethernet-controller.yaml   | 10 +++++++++-
>>  .../devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml    |  2 +-
>>  3 files changed, 11 insertions(+), 2 deletions(-)
>> 
>> diff --git a/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml b/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml
>> index 7ca9c19a157c..a53552ee1d0e 100644
>> --- a/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml
>> +++ b/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml
>> @@ -74,6 +74,7 @@ properties:
>>  
>>          properties:
>>            pcs-handle:
>> +            maxItems: 1
> 
> Forgot to remove the $ref here.
> 
>>              description:
>>                phandle pointing to a PCS sub-node compatible with
>>                renesas,rzn1-miic.yaml#
>> diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet-controller.yaml
>> index 4b3c590fcebf..5bb2ec2963cf 100644
>> --- a/Documentation/devicetree/bindings/net/ethernet-controller.yaml
>> +++ b/Documentation/devicetree/bindings/net/ethernet-controller.yaml
>> @@ -108,11 +108,16 @@ properties:
>>      $ref: "#/properties/phy-connection-type"
>>  
>>    pcs-handle:
>> -    $ref: /schemas/types.yaml#/definitions/phandle
>> +    $ref: /schemas/types.yaml#/definitions/phandle-array
> 
> 'phandle-array' is really a matrix, so this needs a bit more:
> 
> items:
>   maxItems: 1
> 
> Which basically says this is phandles with no arg cells.
> 
>>      description:
>>        Specifies a reference to a node representing a PCS PHY device on a MDIO
>>        bus to link with an external PHY (phy-handle) if exists.
>>  
>> +  pcs-handle-names:
>> +    $ref: /schemas/types.yaml#/definitions/string-array
> 
> No need for a type as *-names already has a type.
> 
>> +    description:
>> +      The name of each PCS in pcs-handle.
>> +
>>    phy-handle:
>>      $ref: /schemas/types.yaml#/definitions/phandle
>>      description:
>> @@ -216,6 +221,9 @@ properties:
>>          required:
>>            - speed
>>  
>> +dependencies:
>> +  pcs-handle-names: [pcs-handle]
>> +
>>  allOf:
>>    - if:
>>        properties:
>> diff --git a/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml b/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml
>> index 7f620a71a972..600240281e8c 100644
>> --- a/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml
>> +++ b/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml
>> @@ -31,7 +31,7 @@ properties:
>>    phy-mode: true
>>  
>>    pcs-handle:
>> -    $ref: /schemas/types.yaml#/definitions/phandle
>> +    maxItems: 1
>>      description:
>>        A reference to a node representing a PCS PHY device found on
>>        the internal MDIO bus.
>> -- 
>> 2.35.1.1320.gc452695387.dirty
>> 
>> 
> 

OK, I've added these changes for v6.

--Sean