Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   David Laight <David.Laight@ACULAB.COM>
To:     'YingChi Long' <me@inclyc.cn>
CC:     "bp@alien8.de" <bp@alien8.de>,
        "chang.seok.bae@intel.com" <chang.seok.bae@intel.com>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "hpa@zytor.com" <hpa@zytor.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "ndesaulniers@google.com" <ndesaulniers@google.com>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "x86@kernel.org" <x86@kernel.org>
Subject: RE: [PATCH v2] x86/fpu: use _Alignof to avoid UB in TYPE_ALIGN
Thread-Topic: [PATCH v2] x86/fpu: use _Alignof to avoid UB in TYPE_ALIGN
Thread-Index: AQHY0oauCPu6lqkmBkuKoE4b1f9eoq3zbbUQ
Date:   Tue, 27 Sep 2022 15:58:33 +0000
Message-ID: <38114d1b752c497eba1640360daf5b9e@AcuMS.aculab.com>
References: <20220925153151.2467884-1-me@inclyc.cn>
 <20220927153338.4177854-1-me@inclyc.cn>
In-Reply-To: <20220927153338.4177854-1-me@inclyc.cn>
Accept-Language: en-GB, en-US
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

From: YingChi Long
> Sent: 27 September 2022 16:34
> 
> WG14 N2350 made very clear that it is an UB having type definitions with
> in "offsetof". This patch change the implementation of macro
> "TYPE_ALIGN" to builtin "_Alignof" to avoid undefined behavior.

Interesting - what justification do they give?
Linux kernel requires that the compiler add no unnecessary padding
so that structure definitions are well defined.

IIRC that standard allows arbitrary padding between members.
So using a type definition inside offsetof() won't give a
useful value - but it still isn't really UB.

...
>  #define CHECK_MEMBER_AT_END_OF(TYPE, MEMBER) \
> -	BUILD_BUG_ON(sizeof(TYPE) != ALIGN(offsetofend(TYPE, MEMBER), \
> -					   TYPE_ALIGN(TYPE)))
> +	BUILD_BUG_ON(sizeof(TYPE) !=         \
> +		     ALIGN(offsetofend(TYPE, MEMBER), _Alignof(TYPE)))

Has that ever worked?
Given:
	struct foo {
		int a;
		char b;
		char c;
	};
I think CHECK_MEMBER_AT_END_OF_TYPE(struct foo, b) is true.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)