Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Nadav Amit <namit@vmware.com>
To:     Chih-En Lin <shiyn.lin@gmail.com>
CC:     Andrew Morton <akpm@linux-foundation.org>,
        Qi Zheng <zhengqi.arch@bytedance.com>,
        David Hildenbrand <david@redhat.com>,
        Matthew Wilcox <willy@infradead.org>,
        Christophe Leroy <christophe.leroy@csgroup.eu>,
        LKML <linux-kernel@vger.kernel.org>,
        Linux MM <linux-mm@kvack.org>,
        Luis Chamberlain <mcgrof@kernel.org>,
        Kees Cook <keescook@chromium.org>,
        Iurii Zaikin <yzaikin@google.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        William Kucharski <william.kucharski@oracle.com>,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        Peter Xu <peterx@redhat.com>,
        Suren Baghdasaryan <surenb@google.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Tong Tiangen <tongtiangen@huawei.com>,
        Pasha Tatashin <pasha.tatashin@soleen.com>,
        Li kunyu <kunyu@nfschina.com>,
        Anshuman Khandual <anshuman.khandual@arm.com>,
        Minchan Kim <minchan@kernel.org>,
        Yang Shi <shy828301@gmail.com>, Song Liu <song@kernel.org>,
        Miaohe Lin <linmiaohe@huawei.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Andy Lutomirski <luto@kernel.org>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Dinglan Peng <peng301@purdue.edu>,
        Pedro Fonseca <pfonseca@purdue.edu>,
        Jim Huang <jserv@ccns.ncku.edu.tw>,
        Huichun Feng <foxhoundsk.tw@gmail.com>
Subject: Re: [RFC PATCH v2 5/9] mm, pgtable: Add a refcount to PTE table
Thread-Topic: [RFC PATCH v2 5/9] mm, pgtable: Add a refcount to PTE table
Thread-Index: AQHY0o4iCb7noslDKUGe08SM0U1/R63zkJmA
Date:   Tue, 27 Sep 2022 17:59:16 +0000
Message-ID: <8C7248F0-55E4-4813-9167-C8CD2D02F1D0@vmware.com>
References: <20220927162957.270460-1-shiyn.lin@gmail.com>
 <20220927162957.270460-6-shiyn.lin@gmail.com>
In-Reply-To: <20220927162957.270460-6-shiyn.lin@gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YbtszomyIM+FXZS5IQ92p/CaDdtIEOIyMb98i8XMg7USbcO5gADr+9d1WAtR?=
 =?us-ascii?Q?SRJTMPjfhfQTH5SXuJN2EEEDW4AmHP/jj1I6QworD/He8ahJzbs1HJO9ibB1?=
 =?us-ascii?Q?dqkgyk9SUxwTSbb5knFUrtoC3ySGAVofMm6iRLaRTH288V83fQNXi62j9U8L?=
 =?us-ascii?Q?3xpLDd0bl04uKt26Sov4XxYbzlNqIpG7DqSPJDF3YKAxlACBNw9ZFR10hQvS?=
 =?us-ascii?Q?XUeFUYi+Z3wyn6ixTxSDlMW0J/74yJLd1PEROf6pVjlY37MRDWueNBfidtc4?=
 =?us-ascii?Q?eZrrCtBo9zdlZMIvD8pGCHn8Tmf9WPP+u7NIlV5SsNhb5Cea7ATAEISsHtnd?=
 =?us-ascii?Q?3mIn3lJDk48xcNa9UGmaN2W6BmSsxe1qM/SzKEtQvk0Ro4YCtB3doPeJ6BMz?=
 =?us-ascii?Q?kzGeEqQe2Hmtcch1Ju3yWJYlxrCw2n3cCy6XwElpmFuHeJ0aiEfHmK3gjsnS?=
 =?us-ascii?Q?adKqalLsYVGSX8BGWGcOecrMY7TKDcPE4GD9aW75oIvBCZV+ABlOUiOLJC4H?=
 =?us-ascii?Q?hjw0NYmDC5Vz5DdPKgVQRH4dQ/B0/Cu9LSOf2Pf7HPyPx/JTxFyroqZu7tSK?=
 =?us-ascii?Q?FQc/CmIY0ZLJfzmYLKxQtboD8m/XkGJg0uUuqZjo04ppUwETi0Rm+NycxMcb?=
 =?us-ascii?Q?oENQx4WcNuRJYrgFIh0uiqRBt6oqudieGDxFgD1bZK25powGEMrRIp/fbSlu?=
 =?us-ascii?Q?82Q3tgk3Fxo1sXsniYV+GF02/PIm1LZs95+YCMjsW89AeDpl3+2bBtxTMxgQ?=
 =?us-ascii?Q?GIXZowD7Xh8xhL4/GS47XsiLljp5g82otoFzK8Uh16FOXfShz21tzZycdirJ?=
 =?us-ascii?Q?8nX9j5NDMj6RXUV9q+PmBegLU/E0rS9cNRfQfMGBU77c309k5md3JSOjuyjv?=
 =?us-ascii?Q?777a54WOY8QYDziGFEAYWMVN8JkA6hqPEbg9O0+R5B0JsHG9NXOq466WEBVy?=
 =?us-ascii?Q?iV/+PQwPM7wCviTBV/DzIvmHhGzmI4jyMnfEQY2LYiYHZY0pRg3U2v37MfAG?=
 =?us-ascii?Q?GvamFvfYM9D9wrdIJEJScq33P0WfCLlHf8p9s2bFegcgm5cVtIMu/dhLOOMp?=
 =?us-ascii?Q?OFc31bCYNHVGPpf5pJ+IbWRL60Ff+Y1azJsf9t8rFZMG0JJ0N+kf6bq3P39Q?=
 =?us-ascii?Q?NTF69aGo9A/emfhjnn8hCNnA/mhvftJCFtlKBd+lSll7DkvmpRiBliHf0uVL?=
 =?us-ascii?Q?km3H6DcxrFHcdZ1/Vj68KVL4XXEhpJmE5gI4PbfG/s3x4a0sU/3g5f6v6TVI?=
 =?us-ascii?Q?nI8SLhZqhYOsAW+hLa0fn0GOGW++mwieeWwbaOQNJA9HEjbt/IUtHzrK1FIP?=
 =?us-ascii?Q?wEdGE0N2PSeg18TDgX7QgAJugQnlUsZyBM9kapOxI4FQgUtu8hSY1eQBFOch?=
 =?us-ascii?Q?IRmhKurmLsRFSxP5b//v+GQdXFR1CY3EjHHW8ZO6cVd8DxeeSYud4Ffey+Qz?=
 =?us-ascii?Q?7aBC9kM49b1hyENmQNM1Or5JRX1zC3Hkj2L+MA1/CRwrBBDHl1G2YY4i29H/?=
 =?us-ascii?Q?hocwd5HzaY5jrI9hsr8OKNuJ8v+m5STYNeWBKR8dbSfyaIlwdQPRPRRMZWyV?=
 =?us-ascii?Q?WVkCC7tiS9gWNLEQKpAg2bYd3/jTUh6l/F/WxmLc?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <9E223F6012C9A341910FA66A9FAE7922@namprd05.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: vmware.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY3PR05MB8531.namprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ad29cf66-03e9-4c57-d2af-08daa0b1fe58
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Sep 2022 17:59:16.2610
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: bURh3q1Ede9Ob6RLQPIWRC46ToOLd4yuKJ/D+ZPEly/DzPMEZ4GB3Eb1b9YIvVQ+ugK/HCcS0lLN9vUsVT/4nw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR05MB6944
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_NONE autolearn=no
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sep 27, 2022, at 9:29 AM, Chih-En Lin <shiyn.lin@gmail.com> wrote:

> Reuse the _refcount in struct page for the page table to maintain the
> number of process references to COWed PTE table. Before decreasing the
> refcount, it will check whether refcount is one or not for reusing
> shared PTE table.
>=20
> Signed-off-by: Chih-En Lin <shiyn.lin@gmail.com>
> ---
> include/linux/mm.h      |  1 +
> include/linux/pgtable.h | 28 ++++++++++++++++++++++++++++
> mm/memory.c             |  1 +
> 3 files changed, 30 insertions(+)
>=20
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index 965523dcca3b8..bfe6a8c7ab9ed 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -2290,6 +2290,7 @@ static inline bool pgtable_pte_page_ctor(struct pag=
e *page)
> 	__SetPageTable(page);
> 	inc_lruvec_page_state(page, NR_PAGETABLE);
> 	page->cow_pte_owner =3D NULL;
> +	set_page_count(page, 1);
> 	return true;
> }
>=20
> diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h
> index 25c1e5c42fdf3..8b497d7d800ed 100644
> --- a/include/linux/pgtable.h
> +++ b/include/linux/pgtable.h
> @@ -9,6 +9,7 @@
> #ifdef CONFIG_MMU
>=20
> #include <linux/mm_types.h>
> +#include <linux/page_ref.h>
> #include <linux/bug.h>
> #include <linux/errno.h>
> #include <asm-generic/pgtable_uffd.h>
> @@ -628,6 +629,33 @@ static inline bool cow_pte_owner_is_same(pmd_t *pmd,=
 pmd_t *owner)
> 	return smp_load_acquire(&pmd_page(*pmd)->cow_pte_owner) =3D=3D owner;
> }
>=20
> +static inline int pmd_get_pte(pmd_t *pmd)
> +{
> +	return page_ref_inc_return(pmd_page(*pmd));
> +}
> +
> +/*
> + * If the COW PTE refcount is 1, instead of decreasing the counter,
> + * clear write protection of the corresponding PMD entry and reset
> + * the COW PTE owner to reuse the table.
> + * But if the reuse parameter is false, do not thing. This help us
> + * to handle the situation that PTE table we already handled.
> + */
> +static inline int pmd_put_pte(struct vm_area_struct *vma, pmd_t *pmd,
> +			      unsigned long addr, bool reuse)
> +{
> +	if (!page_ref_add_unless(pmd_page(*pmd), -1, 1) && reuse) {
> +		cow_pte_fallback(vma, pmd, addr);

Is there some assumption that pmd_get_pte() would not be called between the
page_ref_add_unless() and cow_pte_fallback()?

Hard to know without comments or context.=