Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1ee8f429-bc79-c984-29a2-f131c750551f@redhat.com>
Date:   Tue, 27 Sep 2022 13:52:31 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [Resend PATCH v2] tracing: Disable interrupt or preemption before
 acquiring arch_spinlock_t
Content-Language: en-US
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
        Boqun Feng <boqun.feng@gmail.com>, linux-kernel@vger.kernel.org
References: <20220922133158.1731333-1-longman@redhat.com>
 <20220922145622.1744826-1-longman@redhat.com>
 <9c798af6-aa2c-5f76-7a50-ef1983f9bdcd@redhat.com>
 <20220927131221.1b3a736b@gandalf.local.home>
From:   Waiman Long <longman@redhat.com>
In-Reply-To: <20220927131221.1b3a736b@gandalf.local.home>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/27/22 13:12, Steven Rostedt wrote:
> On Tue, 27 Sep 2022 11:28:13 -0400
> Waiman Long <longman@redhat.com> wrote:
>
>> On 9/22/22 10:56, Waiman Long wrote:
>>> It was found that some tracing functions in kernel/trace/trace.c acquire
>>> an arch_spinlock_t with preemption and irqs enabled. An example is the
>>> tracing_saved_cmdlines_size_read() function which intermittently causes
>>> a "BUG: using smp_processor_id() in preemptible" warning when the LTP
>>> read_all_proc test is run.
>>>
>>> That can be problematic in case preemption happens after acquiring the
>>> lock. Add the necessary preemption or interrupt disabling code in the
>>> appropriate places before acquiring an arch_spinlock_t.
>>>
>>> The convention here is to disable preemption for trace_cmdline_lock and
>>> interupt for max_lock.
>>>
>>> Fixes: a35873a0993b ("tracing: Add conditional snapshot")
>>> Fixes: 939c7a4f04fc ("tracing: Introduce saved_cmdlines_size file")
>>> Suggested-by: Steven Rostedt <rostedt@goodmis.org>
>>> Signed-off-by: Waiman Long <longman@redhat.com>
>>> ---
>>>    kernel/trace/trace.c | 23 +++++++++++++++++++++++
>>>    1 file changed, 23 insertions(+)
>> Ping!
>>
>> Any comment on this patch?
> You may have noticed (from today's emailing) I applied the patch ;-)

Yes, I saw it after I sent this mail :-)

Thanks,
Longman