Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Himanshu Madhani <himanshu.madhani@oracle.com>
To:     Rafael Mendonca <rafaelmendsr@gmail.com>
CC:     Nilesh Javali <njavali@marvell.com>,
        GR-QLogic-Storage-Upstream <GR-QLogic-Storage-Upstream@marvell.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        Martin Petersen <martin.petersen@oracle.com>,
        Himanshu Madhani <himanshu.madhani@cavium.com>,
        Quinn Tran <quinn.tran@cavium.com>,
        linux-scsi <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scsi: qla2xxx: Fix serialization of DCBX TLV data request
Thread-Topic: [PATCH] scsi: qla2xxx: Fix serialization of DCBX TLV data
 request
Thread-Index: AQHY0fwnkq/kzu1Kn0GHnztdbOJSZq3zmUUA
Date:   Tue, 27 Sep 2022 18:26:12 +0000
Message-ID: <185F81ED-2471-44EA-90D5-08503A719426@oracle.com>
References: <20220926230245.790508-1-rafaelmendsr@gmail.com>
In-Reply-To: <20220926230245.790508-1-rafaelmendsr@gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ZjtmYZLTGXQOT4dz07fjZNyCEzql6GfwCQS6rjl5XouAQN0TwrQsOK/JtazC?=
 =?us-ascii?Q?Wbz6iOQ2WxcjnrHMim58jfVaibIslcZZk8l3vwUMyPHmCIqkoSXOuyA0cpFs?=
 =?us-ascii?Q?ocbpnziCffSJquAcYSgQcH8Fepc/PR7ltL5XD1OrQ/C1G1DPFVpjLKVaGo/P?=
 =?us-ascii?Q?gRc9Ed/qJPuD5M1gNgQq0ZvIWA4YcW8wRXyRLPJ029Td32YzD0dmvcjKsVpM?=
 =?us-ascii?Q?dqCLkLUfWSlXc/8uOTRqZmDlf51IgOZuMNfIpVq5er4Ut4PM5zyMfoyNteMt?=
 =?us-ascii?Q?1EzkJQVnu2Ei1qqhvq7uJaiEXTPMaf47/3pO6qKMlsbGXU38ita+SJnuaY9D?=
 =?us-ascii?Q?v0GXlcW9SCpxLYI4EcMuvCZOAE50T+XwinIBVB7pyKrDqsLbNwc9GrTSM2FZ?=
 =?us-ascii?Q?w9L4Z1f9/UWF515Md9a364jlIrR0W4iugYNS7Z+H+rN+hKBgSoUBuV4ZWhCM?=
 =?us-ascii?Q?1sTNeEmOaDQJKNiLD1dOA3Gq2yp9n8IslICPVctMx9h4UhYhJetK5ILR+u1A?=
 =?us-ascii?Q?qC5wqAnu+LoXUBYh2OeI5pLeTMCFv47/ve4mWIpXh502v/JnwT/zEFWXJ6ae?=
 =?us-ascii?Q?amGASH1Qp/H/xXiEumm2aNC3v9eXqNS0KyyI5v6ptSPmTY4/JNyPCG/4dWJC?=
 =?us-ascii?Q?sqjxFB9RF0X3A8osiBbNiB4EPQN1V6vmzVKCtsRTyhr67ACIQO//w3w/0VkC?=
 =?us-ascii?Q?znZo2nA8/182H+FH6mpV0Anq19eO3ufsQIPSBjwA+wly+0suT5dCtN36PeTw?=
 =?us-ascii?Q?w0affBJJ+fNjC/m4Iq6vMn/cfDkH2oo/Fe8QbzTkS/2wcyO/xkWsPCb3JdsU?=
 =?us-ascii?Q?f4wo/IgJVLp4K1weKMLJxw/C6tZdnjugC7TAZq5cRgpglJjOQGrf0WSQih+G?=
 =?us-ascii?Q?c3NCYXeAKFVMGv3ctoCTGyBb6CumcoIpseIEqAoYYMe63w34rGoP/fgdopFY?=
 =?us-ascii?Q?djdPj0cqPlVa7s1u2S7VmCeO5rN1lY1I+HBEGkyZ+PCow9/nVyd6bjMy8uD7?=
 =?us-ascii?Q?HEujn/vqBr+/1EvaVZ+oOZ0h0pm+71p21PTE8Ddk6TH+H5wsISYpBnhvtD4F?=
 =?us-ascii?Q?PRnEVmXrYqJXA/qGpDjJVNM+ky/DrrKdhw6Yk1wxeksT1KuIyoi9PehE+zVF?=
 =?us-ascii?Q?ITeaFaV3maAYbf92cesXMR2yBoh2VcP7XbT+Wiv679OAU3Bdf4wykPcrHNCe?=
 =?us-ascii?Q?tlx9Wd+PtJ6bqC9rzKnPRHgPtTttkQIvjnhhnrWWxXCfumX6IYT5mwkfhc5y?=
 =?us-ascii?Q?cN2rL/W4YW5EQ6kIybUX51L+Nd3MKC1C9iFzBv4NOCAau49/Zgq+LJdO166v?=
 =?us-ascii?Q?NsciOkFwC6w445ExV49MUfZ848SRxkrgZEQegyzEtR6OEPqm3RmrNo7dtdDF?=
 =?us-ascii?Q?pfhzwOcGleAMYHkD5AenVQm+s6AXzm/PpoRcBk/5zT0bj8YjStRSK+aT/NZS?=
 =?us-ascii?Q?9RLdlUzsFXyz2NwgdT6L4pv8nJhbzZ6wspwnHWC6RKTHl9tN+031P8x1aePG?=
 =?us-ascii?Q?3RwlsGkE67ZeXWGJ4ANQFoW4L7oT6+5UkMZvFyO+QaZto2sNSw342jiXduV5?=
 =?us-ascii?Q?LVRdVWAlGHWvqLTzOd7tpNeR6riU7AYTMRCcThIiA/FfXXhR4Kpix/qyf1cC?=
 =?us-ascii?Q?KQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1C38C826A78F6B4E86F02CD930DA58BC@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB2943.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b30828df-d013-4cd0-09dc-08daa0b5c1f7
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Sep 2022 18:26:12.9907
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3jingRad2wT81bw9gOgb9D9M0zqPS3RFtdrttgBxYhR12PNao/7gLHxKey9jB48UXF52omvb6Lezq3azyV7HBrDU0RBheYvQGEkrFLZdxdk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR10MB6659
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-09-27_09,2022-09-27_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 malwarescore=0
 suspectscore=0 adultscore=0 mlxscore=0 spamscore=0 bulkscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2209270115
X-Proofpoint-ORIG-GUID: PYqUGj9-3HjUgmrhu6_ilxFL5ZotpsnI
X-Proofpoint-GUID: PYqUGj9-3HjUgmrhu6_ilxFL5ZotpsnI
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Sep 26, 2022, at 4:02 PM, Rafael Mendonca <rafaelmendsr@gmail.com> wro=
te:
>=20
> Commit b6faaaf796d7 ("scsi: qla2xxx: Serialize mailbox request") serializ=
ed
> mailbox requests from userspace using the 'optrom' mutex. However, in the
> case of DCBX TLV data, if the memory for it is already allocated, then th=
e
> mailbox request ends up not being serialized because it is done without
> holding the 'optrom' mutex.
>=20
> Fixes: b6faaaf796d7 ("scsi: qla2xxx: Serialize mailbox request")
> Signed-off-by: Rafael Mendonca <rafaelmendsr@gmail.com>
> ---
> drivers/scsi/qla2xxx/qla_attr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/scsi/qla2xxx/qla_attr.c b/drivers/scsi/qla2xxx/qla_a=
ttr.c
> index fa1fcbfb946f..c2bc7f9c728a 100644
> --- a/drivers/scsi/qla2xxx/qla_attr.c
> +++ b/drivers/scsi/qla2xxx/qla_attr.c
> @@ -951,9 +951,9 @@ qla2x00_sysfs_read_dcbx_tlv(struct file *filp, struct=
 kobject *kobj,
> 	if (!capable(CAP_SYS_ADMIN) || off !=3D 0 || count > DCBX_TLV_DATA_SIZE)
> 		return 0;
>=20
> +	mutex_lock(&vha->hw->optrom_mutex);
> 	if (ha->dcbx_tlv)
> 		goto do_read;
> -	mutex_lock(&vha->hw->optrom_mutex);
> 	if (qla2x00_chip_is_down(vha)) {
> 		mutex_unlock(&vha->hw->optrom_mutex);
> 		return 0;
> --=20
> 2.34.1
>=20

Looks Good.=20

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>

--=20
Himanshu Madhani	Oracle Linux Engineering