Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Asmaa Mnebhi <asmaa@nvidia.com>
To:     Wolfram Sang <wsa+renesas@sang-engineering.com>
CC:     "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Khalil Blaiech <kblaiech@nvidia.com>
Subject: RE: [PATCH v6 4/5] i2c: i2c-mlxbf.c: support BlueField-3 SoC
Thread-Topic: [PATCH v6 4/5] i2c: i2c-mlxbf.c: support BlueField-3 SoC
Thread-Index: AQHY0eCKUkSbmtpER0C5L/KgR0/Yua3zsdIAgAAA8TA=
Date:   Tue, 27 Sep 2022 19:56:58 +0000
Message-ID: <CH2PR12MB38955850E07D41FC6947443DD7559@CH2PR12MB3895.namprd12.prod.outlook.com>
References: <20220926194507.24786-1-asmaa@nvidia.com>
 <20220926194507.24786-5-asmaa@nvidia.com> <YzNUrsFbG0vfP1Rx@shikoro>
In-Reply-To: <YzNUrsFbG0vfP1Rx@shikoro>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1EUYh3BCxaNzrk8bdM6jlk95AVb1XXf9FsaiFRk0TPfGjWMYDUGBUvJFWB57?=
 =?us-ascii?Q?viZbZLzbB9pTVMzefRWmRE4l6JM77iN34RHo634+CjUHpwBpUNh5KekQWefo?=
 =?us-ascii?Q?ONEx9JXs8gcinORSWe7vrIBPwQzHQXgvlxBgUF4omSfdpSJNyyLh+Ensd3fi?=
 =?us-ascii?Q?Zk4q05N4AcPOqeepQD5rxI3puElzxP7VBTVuN4XumVre7aESxRybBnfMzKQ3?=
 =?us-ascii?Q?Xg2v/rSA/f2F8NZadGmn0d/uoVWB0EyddHgIAbLEDa3SNohS7gLVhauj5kx7?=
 =?us-ascii?Q?izE86bCbFQ4gkjG81IDT/pgnPY1NjSzc5+7Wkkft8QqbRvzpV7CbTA0Pq5Rb?=
 =?us-ascii?Q?g0HmwSSdUhry73V/cFSW7ZeYjLKD6XxKk0Asy29DxnTJYfuqIjP5igiknu5t?=
 =?us-ascii?Q?gFdtBrptZ9OzoSxDlr5AAIjrezUtZVfOekqlTCUw8NEA60ZRvZyZdVgVezF4?=
 =?us-ascii?Q?YGCyuiXbm2dHNQGZDBy7mm0Fs5UtBLZQGud0dteAwXq53l6iR/WWil+M3oRL?=
 =?us-ascii?Q?HBGtIfgnCc8/hNgMiq9oJfPP84E1qc+ZijaXnwMS9r79DjgiC7QBR4Hk5azV?=
 =?us-ascii?Q?llBXh+dY6zE3bX+5SlyZVom1K/5z2L9gMMLCAdLMY8SpAn5Z55DUnqYyJZXu?=
 =?us-ascii?Q?E9kI8TUd2v+MMXldQMVefxF2rpZl7v7EfAnwotH+/EsC84NaN0vg5J5DMeLb?=
 =?us-ascii?Q?iHnPGPFPhIKXrIgsPyOrQwrbJObA2EOz+Emxvt7P+NabtwKffG3vrl+7UoVb?=
 =?us-ascii?Q?f0byTXrO9/8BwW3W+i/CJTz5j1kN8rXqzHZY1y72PITkW5nsvrypolJ6xDqE?=
 =?us-ascii?Q?MVacyDScvG2URSvMt1Zb7/RGIsFSHYBaszl43LtsLoEO5d8o0RXkPtFTOA8D?=
 =?us-ascii?Q?UhNTKp/mvevKvY214oeeHziTxccQSd4zCpLlrC62cl+Yv0P6Gl2RDHi3mTo+?=
 =?us-ascii?Q?gHyXlcjYvMYKFEscHkfLCTNDrdcjrYu/czrNfBcytZJTwenhDd2FxOuBvsGE?=
 =?us-ascii?Q?2/E7W5jSrTtlHVSsjBoW7wNzyp6S3ZV2s5krE4HWfUYJW0dOtOinvzG9YzLD?=
 =?us-ascii?Q?CkEVCN4/ZjIq5k2fpM9ChEEPsjcERPB3B2HK/G9QEKZVpdWKKBZprZ2es+VI?=
 =?us-ascii?Q?/BDGKul22MB05z/8NyzGyuI0HVgjL0sYpOZbO1u6lW5HljbsBoXEYvoQ/Py+?=
 =?us-ascii?Q?I3jxEb1lXjHEUBbgu9eKEply8/d1o2Wvs6qKMdYds+uMEW2WhV2LVn9Infc2?=
 =?us-ascii?Q?CQQAK54xcKNwuRGxnplnnSqBTU1CV+LCO01ZufVe9sOcNgtfHKTR5mcdN1qb?=
 =?us-ascii?Q?42uhKS0MIW9T2Vys1yPyRgC44OwBMuVO1JLQbptF6lSJZ0BaP03HDOEeP4kQ?=
 =?us-ascii?Q?RdfJJ1/xPBHxfEZPDsvltcW3R90YKMnZVs0CRcc7bQm0oio5m1wg3qQubcAq?=
 =?us-ascii?Q?CmfyIus0K9CQRfJ0CY5o0PYtFSLGuVSv3rIBJkD8ICAV6UxKQlUvf97A494l?=
 =?us-ascii?Q?UJBAELdaVt/h+9tffoX4e72WhdBeeqT7hH2FOZcc3mhm0TfZgkPx8jUvpM6s?=
 =?us-ascii?Q?LJeAcRfrgBtPqr8zDSE=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3895.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d1a51b1b-d3f0-4ed7-36a7-08daa0c26fd5
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Sep 2022 19:56:58.6377
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: UcIVVeMhKLCldp6bApNNqmafRoTaTUp04eylqT1Ep+qPiFNG8qP44G1xhQdgKqFVmaQC0wJLK+yNYEjrssWVlw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7662
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> +		ret =3D mlxbf_i2c_init_resource(pdev, &priv->smbus,
> +					      MLXBF_I2C_SMBUS_RES);

Did you maybe forget to check 'ret' here?

Yes will do!
> +		priv->timer->io =3D priv->smbus->io;
> +		priv->mst->io =3D priv->smbus->io + MLXBF_I2C_MST_ADDR_OFFSET;
> +		priv->slv->io =3D priv->smbus->io + MLXBF_I2C_SLV_ADDR_OFFSET;