Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Jakub Kicinski <kuba@kernel.org>
CC:     Vladimir Oltean <olteanv@gmail.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
        Rui Sousa <rui.sousa@nxp.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        Horatiu Vultur <horatiu.vultur@microchip.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Michael Walle <michael@walle.cc>,
        Vinicius Costa Gomes <vinicius.gomes@intel.com>,
        Maxim Kochetkov <fido_max@inbox.ru>,
        Colin Foster <colin.foster@in-advantage.com>,
        Richie Pearn <richard.pearn@nxp.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Gerhard Engleder <gerhard@engleder-embedded.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 net-next 01/12] net/sched: taprio: allow user input of
 per-tc max SDU
Thread-Topic: [PATCH v2 net-next 01/12] net/sched: taprio: allow user input of
 per-tc max SDU
Thread-Index: AQHYz2o0SHeyglH9xEqJb2YB0CkMDK3yMQqAgAE2X4CAADdFAIAAMTeA
Date:   Tue, 27 Sep 2022 21:23:19 +0000
Message-ID: <20220927212319.pc75hlhsw7s6es6p@skbuf>
References: <20220923163310.3192733-1-vladimir.oltean@nxp.com>
 <20220923163310.3192733-2-vladimir.oltean@nxp.com>
 <20220926133829.6bb62b8a@kernel.org> <20220927150921.ffjdliwljccusxad@skbuf>
 <20220927112710.5fc7720f@kernel.org>
In-Reply-To: <20220927112710.5fc7720f@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?pCcCHYsQl0F8oPuF7TYWOX5+I/la3uolMNKLfGbWLKLrfh2wIFkEetwntvPx?=
 =?us-ascii?Q?LyU7eyak8sdZqgVF7E74suNOJegpEj97DHs8Mz5vPl6Tz7rCSo9mQAh8J3uY?=
 =?us-ascii?Q?ay+ONkU6VMf3G+WQO2LsHBBcSDMYNh9T5VnF/Bpa9dxoICu1F8ER8pkhCVjE?=
 =?us-ascii?Q?ObGv0imnV1RbgqBBQuUq3Rr2p45aIqKfl/WDFnvdv237n0S6mbTBYhF/nY6Y?=
 =?us-ascii?Q?KcARzJEnxOc2HKQPB3H3hevbKnHfvgkPvZHeAIUYO9fbzj2DHprbf8viF1vC?=
 =?us-ascii?Q?ZiWfNiutUcF5CyQq53ZtC7adU2+EjarEHKd1gkK96oxuM4sbXRV9yJ8mMhUr?=
 =?us-ascii?Q?CaBQEmAOkCNztCn33h+0d7uutp8nSq37UqWLT0BqC8VKDfUENkow4+md80qt?=
 =?us-ascii?Q?QF8uDuJe5Hp1GeCbVIRt5YjOw+rTXQ0Zhtt4IHtiK/PHvOowDEtD79OQZISS?=
 =?us-ascii?Q?JjE5bM+sI45P7jVzY4zN6arEj6EAbNxKmAzFHSl8GENjkvtIhh5Int6qvKBF?=
 =?us-ascii?Q?MqLsBgdct8tfQ7nN97ku+0+wCM1EV0OFyDXFyy7HJB8qU8Si+pa1vJbVYzVz?=
 =?us-ascii?Q?MLKySbiF5Net0sCVeRlxCpnQPNv9jCNBD+I7QIfScJrbXXcn/A655LzrjAyU?=
 =?us-ascii?Q?xF/P1bTfN3gLT0ljXhOmCB4rVEHNkm2Vd5jhl/9y9v+yGAFDxI1eEyy7L2lQ?=
 =?us-ascii?Q?UgHtbnxBwTbQtyq0nXbaV2Inhtq8cLHQDIT8qtHLIUg8c2e3lnXPDBI2jRdB?=
 =?us-ascii?Q?atr8cWOekR/yMLwD3NDqZ73Y4L1UyRebb3Rx2MFySSz9ZeX5kDbq5l2tk4xv?=
 =?us-ascii?Q?429UdANwrcp5cY/YSPvhBDd3yrm1ly1OXKWKUc7OsdbbGWgpNRLcXk66rKxI?=
 =?us-ascii?Q?QNmwKzmc6WV1DXvvcMebhuD9/+HeuVsRx5XOufpsT4V6DzMpLG7o9BFgGMVu?=
 =?us-ascii?Q?MeGsF2CAEyFQ4xjBcNKZl7LrXEA3yFcVxCWzz3BTgzBfZHG8prcSKwheIxrB?=
 =?us-ascii?Q?sZGLSb2DR3GgO0k0va4CUIRIrPB+OIv8K+UHG0q0yrIqacvMSyJpe3ggvX+X?=
 =?us-ascii?Q?kKTTDsj+T68Db3yW1WLynkEh70Ubi0pDr7nqV97wygYRujhpBt4cj9/gF5b2?=
 =?us-ascii?Q?RuheOvBMUUI/5Y00LqKm/XxHUsRi2CCtXIbfE2GGc6A5/eNTFcAbSLj34jxm?=
 =?us-ascii?Q?M4JCkgksPOn28e5WVt0gSbnNP6hNVwVBDPgrkGj7m9vz8BQQuDVp/WgVpmnn?=
 =?us-ascii?Q?Acui4XLzB6lGyINvW711azsE2IfF6z8hjwa/8RKA7LejautSlF/moZU3k0JJ?=
 =?us-ascii?Q?o7zUu3ekUUNhKJUrmviVinVvDgUJ37GVhbXTuyCgN4Pgk4g09OC5ErB0EGgY?=
 =?us-ascii?Q?d/FN+ITOsf42GYYkCd44cIC454EISWgqbqucWAk7fSKlE/yy4Lu3/BOhXKBi?=
 =?us-ascii?Q?MCvfVATm/U5hoyKhZASHzfIGP6DRerNIQ/pRNrPkU1Xj5SuzrBN0W7kmQbBD?=
 =?us-ascii?Q?yUPRRoPcpJkf0jT8EMgd1k70QEILLdiK2cL+ulVbfNB/8gljkJOggERbLcur?=
 =?us-ascii?Q?gdhYD/+0DwnWfUuIy/hZQjl+uSkwZs7fRy0Han6JiEX8l8iKHU4JWuJ3UsXx?=
 =?us-ascii?Q?eg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <0E2028FFA1217D4D9E11097DD11F702C@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8d0cd036-cea4-4687-7ac8-08daa0ce8029
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Sep 2022 21:23:20.0099
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 7YKlToVxDeV9RzrPPpvfOrbEFYyFPSr/dB+KHzqeBDvpBbjKo2HPV5BqrEh/dcuxRUc4GDFMuJuFjYFb3voY9w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7200
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Sep 27, 2022 at 11:27:10AM -0700, Jakub Kicinski wrote:
> I know, that's what I expected you'd say :(
> You'd need a reverse parser which is a PITA to do unless you have
> clearly specified bindings.

I think you're underestimating the problem, it's worse than PITA. My A
still hurts and yet I couldn't find any way in which reverse parsing the
bad netlink attribute is in any way practical in iproute2, other than
doing it to prove a point that it's possible.

> I'd rather you kept the code as is than make precedent for adding both
> string and machine readable. If we do that people will try to stay on
> the safe side and always add both.
>
> The machine readable format is carries all the information you need.

Nope, the question "What range?" still isn't answered via the machine
readable format. Just "What integer?".

> It's just the user space is not clever enough to read it which is,
> well, solvable.

You should come work at NXP, we love people who keep a healthy dose of
unnecessary complexity in things :)

Sometimes, "not clever enough" is just fine.=