Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <30026d7b-a736-5660-2e5e-7e9fcef10101@amd.com>
Date:   Tue, 27 Sep 2022 15:45:49 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v5 1/6] x86/sev: Fix calculation of end address based on
 number of pages
Content-Language: en-US
To:     Dave Hansen <dave.hansen@intel.com>, linux-kernel@vger.kernel.org,
        x86@kernel.org
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "Kirill A. Shutemov" <kirill@shutemov.name>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Michael Roth <michael.roth@amd.com>,
        Joerg Roedel <jroedel@suse.de>,
        Andy Lutomirski <luto@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>
References: <20220614120231.48165-1-kirill.shutemov@linux.intel.com>
 <cover.1664298261.git.thomas.lendacky@amd.com>
 <afd222473c7b18ea942e754a6c4df26ed74eedee.1664298261.git.thomas.lendacky@amd.com>
 <51eeb843-204f-5b9d-9f7f-9bf3c22d2c00@intel.com>
From:   Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <51eeb843-204f-5b9d-9f7f-9bf3c22d2c00@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZlZ0TkI1Sy92aC9aRUlqZ2FEN3Y4c0xsKzdsQzIzZVNJOEwvVUR5T2VxakVm?=
 =?utf-8?B?NFZjQ2J1aUFUa0o1UXVXaUxMRVlQd2VKSytvUEx4MlArSklVbERoTTI2SElP?=
 =?utf-8?B?RjZ6MFZzK2hJalNrajF4dU96QzMwNEpsMzRwRG9oT3l3WUpwRE5DU1V1RHlV?=
 =?utf-8?B?enFaLzlNNmJJcVRQTldHdENPRmpxdzdwYkJaVDRCQXhIMHlzeFVDRzZDdnRG?=
 =?utf-8?B?REZLTUhUcGk3ZVRMaVdVSWZQNjBobmE1OG15QzVhVGhTUzFTT09BNytab3Vs?=
 =?utf-8?B?ZVQxZmhZdFQ1NGNQNkZvRnB0UXA5MkEzTnVUcDZRUGwwMXYxbjZWOThQbWIr?=
 =?utf-8?B?NDhPdWQ5TmNxQ3dTMmJkSWorbFZVRXpCZFc5eTNZaWczM2c0YUNEb1piVVNU?=
 =?utf-8?B?cXBwdmw3VDd4ZEJDYXZ3VlFrRXFtVWp2M05iY0xMWTNxcmJxUE5ldy80YmhY?=
 =?utf-8?B?NTR0QlhHdlBhdTZNS25uT1JhczR3R2lNMy82eXJtUUZvdlAydW1ILzlhRUQw?=
 =?utf-8?B?dnhJVDZ0L2huZkdLNXF3OTN1MVhyejV1UGpGVWxUN3ZkRm5Uc2hnY2RNeFI5?=
 =?utf-8?B?ckRDc3hpMDJxYXZOQmhLVktkeU5NU1RiSVQ3YU5wd1JpRXJWeFhISFNHRmxq?=
 =?utf-8?B?Q0xYaTVoKy9KUDNDcno1a0F5VjlXcm5EL0JpdXdWV1BSMlhnUkN0QmFQWmE3?=
 =?utf-8?B?R2ZBM0x5b25zV3hMRVgvQVBCY1hwWSs3Y3EySTNiSTlqWU0rZzFKM1pPUXRh?=
 =?utf-8?B?UUV2MElTQk5zV2lRTUtmM01DTUJaQnIzb0NQdGRRbG9tL3g3N0lzeWdOcCto?=
 =?utf-8?B?Sys3OUpoMnBjaGliRjZMTk53UUJDTjJJWkRzNHVlNEpndDhnUHJCQ1hSMnJq?=
 =?utf-8?B?Z285Zk9qNGZ3Mm9Ka0xsY2Z6MmJEeFQ1RUpWTXJ6dm50N2V5Y3ZZbnJ6KzRL?=
 =?utf-8?B?V2RnUFpPeVhDWnJHdkhucVpkRWZ2NEdCRmg2cnJxdTNyTW92MnNReVBTekRl?=
 =?utf-8?B?d3cvRVE1d2hWRnlERUZWcWZOQXBSbWhQTWV3MTFXWVZCZ1hsUUZjUDMwVXRw?=
 =?utf-8?B?VkgrYUtYTE95eVF6emlUUStxZG1iK05tbnN3ZkVjYXpKeE9MdkxIRXVseTZr?=
 =?utf-8?B?dGJxU3N1dk1rVjZsazZUU3FESlE1R2swRExsMjUzbnBpdmEwN3FxbGx3MU5J?=
 =?utf-8?B?WTRSWDNBVzFrRjlvUGJSVmFZUExSZlBySGZXWjFKT1A0djhLS0doZ2RtaUpm?=
 =?utf-8?B?ZmFGNDFWaDdRVjYxb3JiZ1BsbHdjQ1VaMkM5QTZWVStNeU5PU0paOHFhZE0w?=
 =?utf-8?B?VmJ3VXIvNmllYWVmVzBhalZJcS9VdGtxeDlFMUd4cEJNUnJLZFhnQjFtcmhj?=
 =?utf-8?B?M2ZVdWp2dUVWVHpyakVaVU5jeHluanBHbVYySm9scWg2bXNBdVY2NU1kUVBz?=
 =?utf-8?B?WlQ5RE9TMCs1ZW85ck9RRjBtWHV1V0dDeEFsWTlLVkkrU25NS2JXSHhWcEJN?=
 =?utf-8?B?L1hHeElzOFdFNURpTDhxT1NYdExBVGJGQmdOM1ZaTm0yUWc1Tm9qM0lTUDJp?=
 =?utf-8?B?YzVWT0lOdE1NSUwrZlZZOHhBWXZXTDRjMGZ3NWQ2bHNiTXZnYkNmcW56VG0z?=
 =?utf-8?B?QTNEdUwrRGtqUTl4dk1BdmkwaStqaVJqVy9VTjRibGhaS3E4OC9TVnE5MDRj?=
 =?utf-8?B?SWcva0RWckdFZ0w0b0JPWElEUDV1R3VzblY0UVpTNFU1Mmo1L3VQeGtFNUo5?=
 =?utf-8?B?SzdPYnNQRkZFSVVGOE9qaXNPM3hUcUtzVDVnbEVHNzNmTVY0N1pGK21XQ3FX?=
 =?utf-8?B?cjh2aTk4S1RsSUhQNUNnalNDbnp4Tk42U3NjKzdlTTZEWm1GU0IyejhlWU9z?=
 =?utf-8?B?RHNGdGRFdjJIeDRTQ0hUbjFEa09UN09CMVhhRndMbmNQdXR1U0cxVFZPTXNx?=
 =?utf-8?B?bmZockN3UVovK2RPckwxVlplSnRKYzZRM0Y2a21MM1VjL3o1bVJGdDE4NE0w?=
 =?utf-8?B?c2tqSXg4TU9EMmlsVlIwMWFxZXpaYTBmcmpaaWpRL21ENk5RUGRWTDV4UFBn?=
 =?utf-8?B?dHQybk5ISTBNOTAwWnVmcXlMUGoySlBMZ3huTExMd3NVNmREcGF1TXl0dHJO?=
 =?utf-8?Q?1+30jgP0u6+ZKHQG/3xYDwANc?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7aaa0be6-9aa8-460f-32c5-08daa0c9447b
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 20:45:53.2869
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OYjedV9URQf4r1AzlwFZdooZ6KYlCDs4hNv83yxBO0+OUET2lbPMfNpAO/CSpCh9AIHZ2o0/AUmgfYW8WNOC9Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR12MB5599
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 9/27/22 12:10, Dave Hansen wrote:
> On 9/27/22 10:04, Tom Lendacky wrote:
>> --- a/arch/x86/kernel/sev.c
>> +++ b/arch/x86/kernel/sev.c
>> @@ -649,7 +649,7 @@ static void pvalidate_pages(unsigned long vaddr, unsigned int npages, bool valid
>>   	int rc;
>>   
>>   	vaddr = vaddr & PAGE_MASK;
>> -	vaddr_end = vaddr + (npages << PAGE_SHIFT);
>> +	vaddr_end = vaddr + ((unsigned long)npages << PAGE_SHIFT);
> 
> Could we please just fix the fragile typing that cascaded down to this
> point?
> 
> Shouldn't 'npages' in this interface be a long?

I'll take a look at that.

Thanks,
Tom

> 
>> struct x86_guest {
>>          void (*enc_status_change_prepare)(unsigned long vaddr, int npages, bool enc);
>>          bool (*enc_status_change_finish)(unsigned long vaddr, int npages, bool enc);
>>          bool (*enc_tlb_flush_required)(bool enc);
>>          bool (*enc_cache_flush_required)(void);
>> };