Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     netdev@vger.kernel.org
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
        Rui Sousa <rui.sousa@nxp.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        UNGLinuxDriver@microchip.com,
        Horatiu Vultur <horatiu.vultur@microchip.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Michael Walle <michael@walle.cc>,
        Vinicius Costa Gomes <vinicius.gomes@intel.com>,
        Maxim Kochetkov <fido_max@inbox.ru>,
        Colin Foster <colin.foster@in-advantage.com>,
        Richie Pearn <richard.pearn@nxp.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Vladimir Oltean <olteanv@gmail.com>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>, linux-kernel@vger.kernel.org
Subject: [PATCH v3 net-next 4/8] net: dsa: hellcreek: refactor hellcreek_port_setup_tc() to use switch/case
Date:   Wed, 28 Sep 2022 02:47:42 +0300
Message-Id: <20220927234746.1823648-5-vladimir.oltean@nxp.com>
In-Reply-To: <20220927234746.1823648-1-vladimir.oltean@nxp.com>
References: <20220927234746.1823648-1-vladimir.oltean@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1PcYQF5J7JEpumRhxl74rRWIiR1LlH/4HE5WdOpV8zYk3jD74rrMtMYdE+Ym?=
 =?us-ascii?Q?tgK2c2tBlGLUXML+Mdf2ql8j0exXiI0jk7VVU4wdzhvvR74ecBJ6+jzUcRt3?=
 =?us-ascii?Q?x1hjkAZuhP8gZIMAhcZ+1w+MXewc3OQ00RGWPlKScbClzVaSFdL6I5LuM0+5?=
 =?us-ascii?Q?45EUKgCKJ+WjGIXDzXRWtUaxTwg1AZDlSFTrmkoeDoYffWsa88BrQSi10HTJ?=
 =?us-ascii?Q?iW1wg5KSsVARvIipxuVpk1rDJkujTfHBUamwaAZ9f49iTLxnxuIpoMuErkOB?=
 =?us-ascii?Q?gfS5vweZfaLnQwl4Y4hqn6LesRNyJJqlZq79JRhHiQV8mwVY2jgAbPZiPC1Q?=
 =?us-ascii?Q?onHpxfHEjd1n8Vu5Qs+h3pTPUpUOI8xUNQN8a6l6jUbLkKcH0krWphUPS3VM?=
 =?us-ascii?Q?ieCoOAkw3RBoNwgyOVhejsnvjYNrzsfmhu22KKXSpY73LI3DJsHBvqkfFKiJ?=
 =?us-ascii?Q?RJ4JWdPfGFaygxN6yozHiWuy3g4T5X06fk8VqfmSj2mq0YMP49+bi2mu5/Uj?=
 =?us-ascii?Q?IT3k/Qas839fjLheWezmbFsYTBKwnHHSa9JOR2vEqka7idtKgZsdJioRPe4J?=
 =?us-ascii?Q?a4Ens6yNK5pap+h5mHEY+iqkIb0lRbkGN51Lg1M06+B/MFdNa7YYd05yPxjl?=
 =?us-ascii?Q?PpGq4GZ3tXabPfXizQbutlnIYrCpN4tZwxX5aH4eGVJjaSK/JXBvitg5NKIK?=
 =?us-ascii?Q?+ArjfmN1fyYX5fcOiYz8Mnp+2183vOnuc+1wtt+KE7zfMKP1Z6//DdhQa6qZ?=
 =?us-ascii?Q?frJUxJdtsxmHwlNJx9AAxgdlZZfuXCZiZ8roM5CG1V+ipXR0Q/2wwKcSKUI/?=
 =?us-ascii?Q?ZNN6FKGDg6C5AjQY3q0A1fopCOdVjFP71ityPcrSIOLCmRhA6zU+xLau/08p?=
 =?us-ascii?Q?mhSY7A48+aBy2uorSU7CAmVJaAuOHj7QYs9u6P7Jf4uIAhXsjqiQt3dH4SnD?=
 =?us-ascii?Q?rUryBHABnf+fe3XBn5z/FTPXkEWNrujOj1LDUS2in8Gz1uKDGkTK0LAcdV3V?=
 =?us-ascii?Q?WdJHvyxE8lcsBmrEX4IwCVLD1Ol57wkNPmXk3p0e07n4me4PGrb49bt9Qb0n?=
 =?us-ascii?Q?1sxz788+x+11QBu3npQg9JIWzof5DIayE4+uosqI6AK7Vs9UssJSVfIS3S60?=
 =?us-ascii?Q?KW6pw6fOmxI5AmxatjzbLQLyMHYk6XeJE/de2Tw87kNwG7mQUNVoiYg4OpfQ?=
 =?us-ascii?Q?313GMXpJcrnzxx+t7M0dY4gqBmooFSLTM5qO9/TiNsP6wI/d6KAMlyk2oRYl?=
 =?us-ascii?Q?vbVvhBAJfchyy6i65BC8OjwTu3s92KAqgYNvxbBYeyd0Uwjaxrmv9I2XPNNv?=
 =?us-ascii?Q?0TxUrPWYQe7YvcuuVhdCz+CKZbc7sfn/U53mqOc246YUbKShjJwgsvnBiE6P?=
 =?us-ascii?Q?ThifFbU7wrtM0womRR3tSlpFWuGBhNiaWpu09JLUH1+ui39lD27C2PZPaQxM?=
 =?us-ascii?Q?uQdxQSgxIJTX4fakyWqlNVbtQIauNLwA3z9tyWN24ATmgGRBi6WodMyjRu1X?=
 =?us-ascii?Q?jkqyLFQuDxUb/5DEc7gkEoFrpWTy8UsvQFEGCNUHfJFCDeFKVuyuK2v/fwHR?=
 =?us-ascii?Q?MFlbomWHdhUB6FPn/hYO4YHG6xAIBas0jWHK5Glv4vdvpINbH880hgjQluDF?=
 =?us-ascii?Q?Eg=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c78a1993-5396-4fd5-2ee1-08daa0e2b8af
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 23:48:04.9450
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ywIIgIG6JKQ4xwO2JnqmpovU57Kj+E66b+zqO1lVGD0/Y3jl27vj+T/PT03Y3zMWxsM0U5HYHr12dkEfIxeOtA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9444
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The following patch will need to make this function also respond to
TC_QUERY_BASE, so make the processing more structured around the
tc_setup_type.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
v2->v3: patch is new

 drivers/net/dsa/hirschmann/hellcreek.c | 33 +++++++++++++++++++-------
 1 file changed, 25 insertions(+), 8 deletions(-)

diff --git a/drivers/net/dsa/hirschmann/hellcreek.c b/drivers/net/dsa/hirschmann/hellcreek.c
index eac6ace7c5f9..ab830c8ac1b0 100644
--- a/drivers/net/dsa/hirschmann/hellcreek.c
+++ b/drivers/net/dsa/hirschmann/hellcreek.c
@@ -1809,22 +1809,39 @@ static bool hellcreek_validate_schedule(struct hellcreek *hellcreek,
 	return true;
 }
 
+static int hellcreek_tc_query_caps(struct tc_query_caps_base *base)
+{
+	switch (base->type) {
+	case TC_SETUP_QDISC_TAPRIO: {
+		struct tc_taprio_caps *caps = base->caps;
+
+		caps->supports_queue_max_sdu = true;
+	}
+	default:
+		return -EOPNOTSUPP;
+	}
+}
+
 static int hellcreek_port_setup_tc(struct dsa_switch *ds, int port,
 				   enum tc_setup_type type, void *type_data)
 {
-	struct tc_taprio_qopt_offload *taprio = type_data;
 	struct hellcreek *hellcreek = ds->priv;
 
-	if (type != TC_SETUP_QDISC_TAPRIO)
-		return -EOPNOTSUPP;
+	switch (type) {
+	case TC_SETUP_QDISC_TAPRIO: {
+		struct tc_taprio_qopt_offload *taprio = type_data;
 
-	if (!hellcreek_validate_schedule(hellcreek, taprio))
-		return -EOPNOTSUPP;
+		if (!hellcreek_validate_schedule(hellcreek, taprio))
+			return -EOPNOTSUPP;
 
-	if (taprio->enable)
-		return hellcreek_port_set_schedule(ds, port, taprio);
+		if (taprio->enable)
+			return hellcreek_port_set_schedule(ds, port, taprio);
 
-	return hellcreek_port_del_schedule(ds, port);
+		return hellcreek_port_del_schedule(ds, port);
+	}
+	default:
+		return -EOPNOTSUPP;
+	}
 }
 
 static const struct dsa_switch_ops hellcreek_ds_ops = {
-- 
2.34.1