Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH V2] irqchip: Make irqchip_init() usable on pure ACPI
 systems
To:     Huacai Chen <chenhuacai@loongson.cn>,
        Thomas Gleixner <tglx@linutronix.de>,
        Marc Zyngier <maz@kernel.org>
References: <20220927124557.3246737-1-chenhuacai@loongson.cn>
Cc:     loongarch@lists.linux.dev, linux-kernel@vger.kernel.org,
        Xuefeng Li <lixuefeng@loongson.cn>,
        Huacai Chen <chenhuacai@gmail.com>,
        Jiaxun Yang <jiaxun.yang@flygoat.com>
From:   Tiezhu Yang <yangtiezhu@loongson.cn>
Message-ID: <01b9d198-929a-45ea-2e94-3d0956aee2b7@loongson.cn>
Date:   Wed, 28 Sep 2022 08:20:57 +0800
User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <20220927124557.3246737-1-chenhuacai@loongson.cn>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 09/27/2022 08:45 PM, Huacai Chen wrote:
> Pure ACPI system (e.g., LoongArch) doesn't select OF and OF_IRQ, but it
> still need a non-empty irqchip_init(). So, change the IRQCHIP dependency
> from OF_IRQ to (OF_IRQ || ACPI_GENERIC_GSI), and then define an empty
> inline of_irq_init() in the !CONFIG_OF_IRQ case, so as to make the non-
> empty irqchip_init() be usable on pure ACPI systems.
>
> Without this patch we get such errors:
>
> [    0.000000] NR_IRQS: 576, nr_irqs: 576, preallocated irqs: 16
> [    0.000000] Kernel panic - not syncing: IPI IRQ mapping failed
> [    0.000000] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 6.0.0-rc6+ #2189
> [    0.000000] Hardware name: Loongson Loongson-3A5000-7A1000-1w-CRB/Loongson-LS3A5000-7A1000-1w-CRB, BIOS vUDK2018-LoongArch-V2.0.pre-beta8 08/18/2022
> [    0.000000] Stack : 0000000000000000 9000000000fa4388 900000000140c000 900000000140fb70
> [    0.000000]         0000000000000000 900000000140fb70 90000000012f4aa0 900000000140fa98
> [    0.000000]         900000000140fa0c 900000008140f9ff 0000000000000030 0000000000000005
> [    0.000000]         900000000578f708 0000000004750000 0000000000000000 00000000ffffdfff
> [    0.000000]         0000000000000000 0000000000000000 0000000000000030 000000000000002f
> [    0.000000]         900000000141f000 0000000004750000 9000000001427348 00000000000000b0
> [    0.000000]         90000000012f4aa0 0000000000000004 0000000000000000 9000000001020000
> [    0.000000]         9000000005781b80 9000000005781ba9 0000000000000000 9000000001315e30
> [    0.000000]         900000000129a3b0 9000000000222b64 0000000000000000 00000000000000b0
> [    0.000000]         0000000000000004 0000000000000000 0000000000070000 0000000000000800
> [    0.000000]         ...
> [    0.000000] Call Trace:
> [    0.000000] [<9000000000222b64>] show_stack+0x24/0x124
> [    0.000000] [<9000000000fa4388>] dump_stack_lvl+0x60/0x88
> [    0.000000] [<9000000000f9965c>] panic+0x130/0x2f8
> [    0.000000] [<9000000000fd4324>] init_IRQ+0xa8/0x240
> [    0.000000] [<9000000000fd0b38>] start_kernel+0x488/0x5f0
> [    0.000000] [<9000000000fb10c4>] kernel_entry+0xc4/0xc8
> [    0.000000]
> [    0.000000] ---[ end Kernel panic - not syncing: IPI IRQ mapping failed ]---
>

I am also experiencing the same problem with the latest kernel
on LoongArch, it works well with this patch.

Tested-by: Tiezhu Yang <yangtiezhu@loongson.cn>