Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp1719402rwb; Tue, 27 Sep 2022 17:55:18 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4r/mKhprsvp/RTK/umRv1V5vmq8CmO0Y/HGFj7Ebh428+LGWmTKgm2+5SnPgVC/W4MAoad X-Received: by 2002:a17:903:2282:b0:177:faeb:3606 with SMTP id b2-20020a170903228200b00177faeb3606mr29952458plh.135.1664326517842; Tue, 27 Sep 2022 17:55:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664326517; cv=none; d=google.com; s=arc-20160816; b=fqFl1KVxjGWqeESe2SJT+J4Y0UXX2WLa0TyFK5UdQ+0rSN8xx6EHzCXiFhr1wI+kUz rn/1li2uhtF4ik7jHm4whHe/cOZPpUHkoKOx57hEM7paI/aOMcGd6tEpWEytnzWW8NWo YR9vDzj/eyUw3kKNhg/nDRG3/2A20nj+M5owvKH6UVzvV6yVDqBWqHEN/mXVpxm6hHbP n5HqFhgqqsDF33VjQ094i5gjaUmlvhlg5rIHvQYyVjL/E9fQKtNMXZ3knljOJS3N5DRp mLc7LmWMLUBgLe7Hs8ou2Jqo74wtabFDBbJUIfzVtLYZW6JrRrWM00hSs4GJGRVj7pH+ /jWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=nWLQJvZQ4ylcPdMSF/+VJ3XgCRF1hVaEQ4NdnwDJYAM=; b=iTGXENjHvZ9Crt5Zx+RzvRVOBa8C/DWTZ3um5VW4GVtsIvyuMLWnjtshxhiL+XCIhr 17InPzqw6Ed6350sbuz5q8IELkayw2mRWtR5nJbZ4QFbeO5hGEOADFZGyQALGBXectJc RiNWJluBfevmqo2ERVss0h6nYEfF565lNez+DqoBU14o93n5UfemEKOvCe38GdklCZiM wyr+qQfeUYD/r34KJZQJgSMsBRFzkBJ1LxvgFqTau47TYzCOUDk1tIL7E8PT8TNq2CuL 4u7mXnMeBJraw4LNfZ2TjTjrrhxf6epAb8ouuAjB9sazdbfMuZI53y9LMlgEUiGjlbeB c1Vg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amazon.com header.s=amazon201209 header.b=shab9jAw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lw11-20020a17090b180b00b00202b5053462si400757pjb.161.2022.09.27.17.55.05; Tue, 27 Sep 2022 17:55:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@amazon.com header.s=amazon201209 header.b=shab9jAw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232418AbiI1A2M (ORCPT + 99 others); Tue, 27 Sep 2022 20:28:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232006AbiI1A2J (ORCPT ); Tue, 27 Sep 2022 20:28:09 -0400 Received: from smtp-fw-6002.amazon.com (smtp-fw-6002.amazon.com [52.95.49.90]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25F7E47BB5; Tue, 27 Sep 2022 17:28:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1664324888; x=1695860888; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=nWLQJvZQ4ylcPdMSF/+VJ3XgCRF1hVaEQ4NdnwDJYAM=; b=shab9jAwTZ3+RA5YOCMVzwtIYt+9kfN3VqzwcZRdybmwvFnPc7jDpDfU 7HtuLLVkmxtgLsRemrnHLWt9XxrT2JYBXaucAS39p7Uv9b/tkvLNYD989 AfI2XZ9zEOqMjWCSqXisdKw5gatMKg7BSx+tYkeRtLuMJoE50AP62xwUX w=; X-IronPort-AV: E=Sophos;i="5.93,350,1654560000"; d="scan'208";a="249406928" Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-iad-1e-7dac3c4d.us-east-1.amazon.com) ([10.43.8.6]) by smtp-border-fw-6002.iad6.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2022 00:27:57 +0000 Received: from EX13MTAUWB001.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan3.iad.amazon.com [10.40.163.38]) by email-inbound-relay-iad-1e-7dac3c4d.us-east-1.amazon.com (Postfix) with ESMTPS id C721D81273; Wed, 28 Sep 2022 00:27:54 +0000 (UTC) Received: from EX19D004ANA001.ant.amazon.com (10.37.240.138) by EX13MTAUWB001.ant.amazon.com (10.43.161.249) with Microsoft SMTP Server (TLS) id 15.0.1497.38; Wed, 28 Sep 2022 00:27:54 +0000 Received: from 88665a182662.ant.amazon.com.com (10.43.161.58) by EX19D004ANA001.ant.amazon.com (10.37.240.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1118.12; Wed, 28 Sep 2022 00:27:51 +0000 From: Kuniyuki Iwashima To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , David Ahern CC: Kuniyuki Iwashima , Kuniyuki Iwashima , , , Subject: [PATCH v2 net 0/5] tcp/udp: Fix memory leaks and data races around IPV6_ADDRFORM. Date: Tue, 27 Sep 2022 17:27:36 -0700 Message-ID: <20220928002741.64237-1-kuniyu@amazon.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.43.161.58] X-ClientProxiedBy: EX13D13UWB004.ant.amazon.com (10.43.161.218) To EX19D004ANA001.ant.amazon.com (10.37.240.138) X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This series fixes some memory leaks and data races caused in the same scenario where one thread converts an IPv6 socket into IPv4 with IPV6_ADDRFORM and another accesses the socket concurrently. Note patch 1 and 5 conflict with these commits in net-next, respectively. * 24426654ed3a ("bpf: net: Avoid sk_setsockopt() taking sk lock when called from bpf") * 34704ef024ae ("bpf: net: Change do_tcp_getsockopt() to take the sockptr_t argument") Changes: v2: * Patch 3: * Move inet6_destroy_sock() from sk_prot->destroy() to sk->sk_destruct() and fix CONFIG_IPV6=m build failure * Patch 5: * Add WRITE_ONCE()s in tcp_v6_connect() * Add Reported-by tags and KCSAN log in changelog v1: https://lore.kernel.org/netdev/20220927161209.32939-1-kuniyu@amazon.com/ Kuniyuki Iwashima (5): tcp/udp: Fix memory leak in ipv6_renew_options(). udp: Call inet6_destroy_sock() in setsockopt(IPV6_ADDRFORM). tcp/udp: Call inet6_destroy_sock() in IPv6 sk->sk_destruct(). ipv6: Fix data races around sk->sk_prot. tcp: Fix data races around icsk->icsk_af_ops. include/net/ipv6.h | 1 + include/net/udp.h | 2 +- net/core/sock.c | 6 ++++-- net/ipv4/af_inet.c | 23 ++++++++++++++++------- net/ipv4/tcp.c | 10 ++++++---- net/ipv4/udp.c | 8 ++++++-- net/ipv6/af_inet6.c | 9 ++++++++- net/ipv6/ipv6_sockglue.c | 29 ++++++++++++++--------------- net/ipv6/tcp_ipv6.c | 6 ++++-- net/ipv6/udp.c | 15 ++++++++++++++- 10 files changed, 74 insertions(+), 35 deletions(-) -- 2.30.2