Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp1744492rwb; Tue, 27 Sep 2022 18:22:17 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4sQPDkdPaNwW9dXkQ9r1Z4JZlUvGS+B/YnoQH3kS4bZxj0aD3DyTx4vvrjHi/0BJHdg2pz X-Received: by 2002:a05:6a00:804:b0:544:4e98:3ff3 with SMTP id m4-20020a056a00080400b005444e983ff3mr31708506pfk.36.1664328137542; Tue, 27 Sep 2022 18:22:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664328137; cv=none; d=google.com; s=arc-20160816; b=siPwMKNYch9bul9XmIAtS+LxKI1c4VDfjvx2+Wdcdq3LKulUKu0uh0mjjpf69O0O9r yD9vCXn0wQCjozkS0BbXdqhIqs6U79r6zIK34g38MuQwpiCVbSqnxHU72Me+eG/ImD+U MKD74sdnWxlI1Rul99ZRV4y2tI+cExxWk2BbBFAbDEiUhMNlUjwEN9MA0qaMM9zCzY9Z NygDeeBuPpLryb7fHoAS7jTin7IqszlaSVBWjfso3vzcSYzwZMnBalXzmZzd2OnpS12e y/zEqlGBLlxKWt9YAExGzL0zDmtsAAxEFIlVQmixQs10KqLK2S+fiAG521J5QCUqjVYO 1crw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=NF19G0GHakdi9PoRJpWc5n7cXcIUFzCnv9eq/h2pLEU=; b=W42s/vDy5ZNDkl8Llcd/Awr0qO9ld+L3srej4bImhEHOGWl17NSlUvJw45syPtU6C8 K2QDip+506RROLHRMgxpu7niGk3bhzIsaxM7rgd/++74TbIlY/Cy/PFVAy1xwDcmmdDk D+8s4HGW45yZKS9vOwHSYVRaSCyPLpaN4GSJPeUvc5f/lP2pQYYjC+C2FQYqD1PgTrzp 8HikGF3PZLHQ300A4ZXS8y8uzFiBbRyTJzeIFjNYAepsWCwzpJ7UbqTtXe+EkkRNtibj Jyx/Ic6bnvU1Vtu/UMmJtq/Pcuhk+SkPOcaMb5AjSMQeSN2ncOr38DkyGyy3q8QKu6Yf oSXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XevUr4e3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bd12-20020a170902830c00b00176e70dd154si3060497plb.301.2022.09.27.18.22.06; Tue, 27 Sep 2022 18:22:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XevUr4e3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232195AbiI1BC2 (ORCPT + 99 others); Tue, 27 Sep 2022 21:02:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231899AbiI1BCZ (ORCPT ); Tue, 27 Sep 2022 21:02:25 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 584091DB57D; Tue, 27 Sep 2022 18:02:23 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2796461BEF; Wed, 28 Sep 2022 01:02:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7BC2C433D6; Wed, 28 Sep 2022 01:02:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664326942; bh=NF19G0GHakdi9PoRJpWc5n7cXcIUFzCnv9eq/h2pLEU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=XevUr4e3FCNI6Sp7E0pMrDRbcCzXQs5gpptgPowQY1jDRZftEcieov9BbqUkVjR00 swzRcX+BniaJTQAvMHH07NjwGL2U1t7BtcgLlDKRNO61RBe5+Hmsamp/PArBkvmuh+ W6q7f0rZ9FqQT4pEYg7ZswAR2xd/0WFu9t3Dc8eib9sdU3JaApRTtxOiHFP28D4QCv 7gsDNKdM4EBgkARxgyYXoUbexiUq5p+lDh2mWdi5/gK99uR4+fI7JW3xAEiCL1U9Ck 4IvTxc7pRGlqlwGiLEacyyInl8bt6Ebc1FZjnd2G363ZVAXUj/inXYCIWsgWsXZJY4 0/i/cQ6tkybYg== Date: Tue, 27 Sep 2022 18:02:20 -0700 From: Jakub Kicinski To: Oleksij Rempel Cc: Andrew Lunn , Heiner Kallweit , "David S. Miller" , Eric Dumazet , Paolo Abeni , Russell King , Rob Herring , Krzysztof Kozlowski , Jonathan Corbet , kernel test robot , Bagas Sanjaya , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, David Jander , Luka Perkov , Robert Marko Subject: Re: [PATCH net-next v7 5/7] ethtool: add interface to interact with Ethernet Power Equipment Message-ID: <20220927180220.2169ff2a@kernel.org> In-Reply-To: <20220926112500.990705-6-o.rempel@pengutronix.de> References: <20220926112500.990705-1-o.rempel@pengutronix.de> <20220926112500.990705-6-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 26 Sep 2022 13:24:58 +0200 Oleksij Rempel wrote: > +static int pse_get_pse_attributs(struct net_device *dev, nit: missing e in attributes