Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <240bbb01-1f26-71ee-233a-ad65313ac358@nvidia.com>
Date:   Tue, 27 Sep 2022 18:44:53 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [RFC 2/6] mm/migrate_pages: split unmap_and_move() to _unmap()
 and _move()
Content-Language: en-US
To:     "Huang, Ying" <ying.huang@intel.com>,
        Alistair Popple <apopple@nvidia.com>
Cc:     Yang Shi <shy828301@gmail.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Zi Yan <ziy@nvidia.com>,
        Baolin Wang <baolin.wang@linux.alibaba.com>,
        Oscar Salvador <osalvador@suse.de>,
        Matthew Wilcox <willy@infradead.org>
References: <20220921060616.73086-1-ying.huang@intel.com>
 <20220921060616.73086-3-ying.huang@intel.com>
 <87o7v2lbn4.fsf@nvdebian.thelocal>
 <CAHbLzkpPNbggD+AaT7wFQXkKqCS2cXnq=Xv3m4WuHLMBWGTmpQ@mail.gmail.com>
 <87fsgdllmb.fsf@nvdebian.thelocal>
 <87ill937qe.fsf@yhuang6-desk2.ccr.corp.intel.com>
 <46807002-c42c-1232-0938-5b48050171ee@nvidia.com>
 <CAHbLzkqRyav0fZ5gzaKbkTfGBxkQXTpu0NJz-A9j7UaHhVBxEQ@mail.gmail.com>
 <87pmfgjnpj.fsf@nvdebian.thelocal>
 <87czbg2s3b.fsf@yhuang6-desk2.ccr.corp.intel.com>
From:   John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <87czbg2s3b.fsf@yhuang6-desk2.ccr.corp.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UERXZGhmUEJ3dytsazVzQWpjY0htanNIT2p5RGdsMzU2ZE9LdGlqWlpiMmV4?=
 =?utf-8?B?SUdmTDFEZ3h6TnZMZVozMS9Uc1hwN004bnUxR2M3SmpWTEVEeFlLdmpsRGV0?=
 =?utf-8?B?RHlPQWRoVVF1SEZ3WlVKQm8yaGpOR3Z3aDU0aHlQMmFTWGVxUXZ5eW94ekhi?=
 =?utf-8?B?ZmJUUEQ1SEYramlUbXh3VFVsakdyKzV1bG9lcmZoRWpoRnlEbnA0VEF6Yzlp?=
 =?utf-8?B?Y2FybkN5Q0dpK2J0K2VXSy9ub1BHdHRDMEU3cm5Ed3pOQzdOUS81ekV5U1l4?=
 =?utf-8?B?c2h5bllRS1BnNUs3d0VPbS9CamFVSEpadlpjeEI1OXR5MTBWWVBWdXlqeXNu?=
 =?utf-8?B?MVFNdGUvNkFnMk1PdnRPV01ZdGwrY2thb0NURnZra2FIUlBGMU85K2F3Z3VE?=
 =?utf-8?B?dFIrcktyajRHQ3ZEcDFxMXBhNk1NcEpwYTNiMjhRczQ5YXdjbmI3TmZjbms3?=
 =?utf-8?B?MzFURXpjSU1QelRoalB4cEZCNmVnS25qWXJpTysvM2dwaDlVWTJ6QUlvaUQz?=
 =?utf-8?B?S2pCbStzN01ZWVF1MmZ6QmlKQURkV2FFVUNNOTkyMFNxVyt3MnV1aUtaRnZq?=
 =?utf-8?B?cW9rTVRaZW10Q09qVW95VHpaRVU5YnZBbHNwTUx5dnR4ZDI3ZDVVQmlBdWoz?=
 =?utf-8?B?ZkJrdnFMUXZzeDFuK2tWVnlTaTU1ZXFEZllLTzBMeTh6NXo3TitJcEduRHoy?=
 =?utf-8?B?dHhjbTRsWlBKSFhPSlRDeVd4ZHVNSUsvSUd1NGNDWmJxMmNvdVRVVVkyM2Zr?=
 =?utf-8?B?bVZub2tCOHhPTTg1M3VxWCtBbENaRU1sVU9JZ09KaGhKcGdOYWZ4V2hZSHBk?=
 =?utf-8?B?bFdqK3p2alpZTEIvN3l3UWxQZlVtQXRUMnY5UUdCa3g2WVY3ZTdaZHJONnYw?=
 =?utf-8?B?cC9ick14c3grZzZNSnpvVEI2RXNxUlBlaUdDSkswNDR5L1Z6enhYQTJnQ0RO?=
 =?utf-8?B?TGYvZmMvUG9STkRyTVFVY0hFbVpwamlneTYyK0djUG9UR0VUUHk2V0lSa0Qv?=
 =?utf-8?B?cGwzWG9FRXlMTHNLdmorODlmQ1BORWNXamtJQXFCNjR2TTh5N2J5QWNoNml3?=
 =?utf-8?B?ME9WR0pWZWxnVmZXemcyeERvNm5GREt6QU1YTFluakVxVUlaYzFaOWVERERM?=
 =?utf-8?B?OGViTENlRVJtc0VKWDdwWDBKMEZ3bTNKNXNOWWFFZ0FPYm5QbUpRamZuK2JD?=
 =?utf-8?B?RXRONm1lMkFmT2FNMFcwRXhTZW43Mlk5elBBUjNuSlg1WWNJMzdJdVJwajN5?=
 =?utf-8?B?Mk96UUo1MkE1VUFZemVDSm9UTjJCOStsd3JTYmFPN3p6ZDVRWmVCS09yYTJ1?=
 =?utf-8?B?MmNsQ0wyeU0xeDhROWlNT3MyNmhJZFBGQ0kvL0FqaVFrN2N0U2lZZy9RVCtG?=
 =?utf-8?B?Y21Sbm9LdjVTWDh2WmtKQWtBUGt3eWV2UUg1SEJXNHFtS1hiV2dZY3BoeTdJ?=
 =?utf-8?B?c0RNcWE5NDBwbUMyTVR2SXB6R2FHNGR4RWVrTUJET1duSlBSeDR5Vy8zYlN3?=
 =?utf-8?B?b1NaT2NxV1BsWEhlRVo4NENwS0Y1TXVudUZJRmNyNXdEdkR2UEZSV1hRdzBq?=
 =?utf-8?B?MWU0Z0NQM3hLVExWeFVUTkVHUm9FMktkQlNUOWNYYVB2dFZ2bXB0M3F5Unpw?=
 =?utf-8?B?VnI4VU9nTnVuMi9Fa0lsa3ZIbEVyQUFvWlBpVUFwZkVmeDMzRmNnb3lUZmFn?=
 =?utf-8?B?V0N3emdBNXg2Zk0zZXlZNFp3NldKUFJpYVFFa1NiZFN4enNGTXBYTERwMXNO?=
 =?utf-8?B?ZFN1VHNPYXI4c3NmU1NOWVNlS25GYXF2TEdwS0oxZGN4ZDN1UEFzbGxNM05C?=
 =?utf-8?B?Q3YrdXY3MGo3Vnp6eE00d0ZUR2J4Yk9UeFBCZ0RHelRmR0w4RTcvRFFrQnFo?=
 =?utf-8?B?cU44L0p3cU5QUGUyOVlVaW5XYld4U0hDaFFlUXM4NE9KZ0FlYWI2N1pybVlQ?=
 =?utf-8?B?dzFBYlUxSnFFTmxDOGc1bWYxRXlBNjkxUFlMZC8zc2JIaXE5Q01uTEZ6Yzlm?=
 =?utf-8?B?b1dVS0oxYTdidHhGOXU1bkFmamUwODFjcE0rY0orRlh2NkRBOVhKbnAxSVBU?=
 =?utf-8?B?dDA1T1NGZ2JEYVEzMEhERnZGNlRNQ09wZ2k4MWh2eDZTVDJ2N2dXdWF2SDRI?=
 =?utf-8?Q?YhgunrOzI/XfWv3AtE4AFtlZ+?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5d8442eb-51ce-491d-42a0-08daa0f30b3a
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2022 01:44:56.1428
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Fq3lOF9zuvIENanfY9aZRG/FLYbWCMGab3Gm7aUX6RhzLzYNaZndFqHsN+9w010u9WyqyAy4lFBB1koBxtdjZg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB7067
X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,SPF_HELO_PASS,SPF_NONE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 9/27/22 18:41, Huang, Ying wrote:
>>>> I also agree that we cannot make any rules such as "do not lock > 1 page
>>>> at the same time, elsewhere in the kernel", because it is already
>>>> happening, for example in page-writeback.c, which locks PAGEVEC_SIZE
>>>> (15) pages per batch [1].
>>
>> That's not really the case though. The inner loop of write_cache_page()
>> only ever locks one page at a time, either directly via the
>> unlock_page() on L2338 (those goto's are amazing) or indirectly via
>> (*writepage)() on L2359.
>>
>> So there's no deadlock potential there because unlocking any previously
>> locked page(s) doesn't depend on obtaining the lock for another page.
>> Unless I've missed something?
> 
> Yes.  This is my understanding too after checking ext4_writepage().
> 

Yes, I missed the ".writepage() shall unlock the page" design point. Now
it seems much more reasonable and safer. :)

thanks,

-- 
John Hubbard
NVIDIA