Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Miles Chen <miles.chen@mediatek.com>
To:     <macpaul.lin@mediatek.com>
CC:     <bear.wang@mediatek.com>, <devicetree@vger.kernel.org>,
        <fparent@baylibre.com>, <krzysztof.kozlowski+dt@linaro.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>,
        <linux-mediatek@lists.infradead.org>, <linux-usb@vger.kernel.org>,
        <macpaul@gmail.com>, <matthias.bgg@gmail.com>,
        <miles.chen@mediatek.com>, <pablo.sun@mediatek.com>,
        <robh+dt@kernel.org>, <stable@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: mediatek: mt8195-demo: fix the memory size of
Date:   Wed, 28 Sep 2022 09:47:50 +0800
Message-ID: <20220928014750.17054-1-miles.chen@mediatek.com>
In-Reply-To: <664f3b7d-d629-5af1-cae4-cb5b638a5da1@mediatek.com>
References: <664f3b7d-d629-5af1-cae4-cb5b638a5da1@mediatek.com>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

>On 9/26/22 15:05, Miles Chen wrote:
>> Hi Macpaul,
>> 
>>> The size of device tree node secmon (bl31_secmon_reserved) was
>>> incorrect. It should be increased to 2MiB (0x200000).
>> 
>> 192K should work when the patch(6147314aeedc) was accepted.
>> Does the trusted-firmware-a get larger now, so we need to
>> increase the size to 2MiB?
>> 
>> thanks,
>> Miles
>
>When mt8195-demo.dts sent to the upstream, at that time the size of
>BL31 was small. Because supported functions and modules in BL31 are 
>basic sets when the board was under early development stage.
>
>Now BL31 includes more firmwares of coprocessors and maturer functions
>so the size has grown bigger in real applications. According to the 
>value reported by customers, we think reserved 2MiB for BL31 might be 
>enough for maybe the following 2 or 3 years.

Thanks for your explanation,
please add this to the commit message and submit next version.

With that, feel free to add:
Reviewed-by: Miles Chen <miles.chen@mediatek.com> 

thanks,
Miles