Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4a44bf59-a984-8ac4-c613-a03d74dc6a5a@nvidia.com>
Date:   Tue, 27 Sep 2022 18:56:23 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [RFC 2/6] mm/migrate_pages: split unmap_and_move() to _unmap()
 and _move()
Content-Language: en-US
To:     Yang Shi <shy828301@gmail.com>
Cc:     "Huang, Ying" <ying.huang@intel.com>,
        Alistair Popple <apopple@nvidia.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Zi Yan <ziy@nvidia.com>,
        Baolin Wang <baolin.wang@linux.alibaba.com>,
        Oscar Salvador <osalvador@suse.de>,
        Matthew Wilcox <willy@infradead.org>
References: <20220921060616.73086-1-ying.huang@intel.com>
 <20220921060616.73086-3-ying.huang@intel.com>
 <87o7v2lbn4.fsf@nvdebian.thelocal>
 <CAHbLzkpPNbggD+AaT7wFQXkKqCS2cXnq=Xv3m4WuHLMBWGTmpQ@mail.gmail.com>
 <87fsgdllmb.fsf@nvdebian.thelocal>
 <87ill937qe.fsf@yhuang6-desk2.ccr.corp.intel.com>
 <46807002-c42c-1232-0938-5b48050171ee@nvidia.com>
 <CAHbLzkqRyav0fZ5gzaKbkTfGBxkQXTpu0NJz-A9j7UaHhVBxEQ@mail.gmail.com>
 <87pmfgjnpj.fsf@nvdebian.thelocal>
 <87czbg2s3b.fsf@yhuang6-desk2.ccr.corp.intel.com>
 <240bbb01-1f26-71ee-233a-ad65313ac358@nvidia.com>
 <CAHbLzkpnCTD_c60QPu25hPymCYwLP6fYRMxp1EWmzX0SBF4g1w@mail.gmail.com>
From:   John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <CAHbLzkpnCTD_c60QPu25hPymCYwLP6fYRMxp1EWmzX0SBF4g1w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L2NCdng4Mzd5dk1tM2JBYTYwMzFwQ3NSVFZIYTc4dWVCUHY5NUxvTVplVVFk?=
 =?utf-8?B?SmVCZ0x3WkprU3B4ems1OVluZi81UTl6RjJxNEFuTkRnZjArV1BFYmF4L2hT?=
 =?utf-8?B?U29kVFR0RGFpQ2Jid0h5RmRRTTArQlFZVWxWYlVONjV4VklaYjZRTVZFRGhZ?=
 =?utf-8?B?bmtxUlVJeGl4NG5YaVVQL3lJa2w0ZHhDS3RrVTBkR2dSRHlqZ1RDRk5zS1hr?=
 =?utf-8?B?RVMrK09SWU5pbERWcHk0ajc0dUNtVExrbG5vZjAxMENNeitKSlhyNFJsTEJM?=
 =?utf-8?B?OTVJY25nZWE2ZGtYZGYyem9ucmtWeEtFS0pZRTNvZ1BzL0lpQklucGx2M0cx?=
 =?utf-8?B?TWQxMjN5cGlXN2V2anBlWjZsREVMTkNxQXpQc3JhckxyMWg1elo3YXdIemd0?=
 =?utf-8?B?TnoxUDcwOGRrSnAveXIxNGVPSHU0VW0rT0xJeE9TMlJBR09KU2Z4ZTBBdnlx?=
 =?utf-8?B?R2xxSEc3VlJNbGhaMjhhMUhkV014T3VzajRzcTM2M0ljNnEwcHFRUDB5RFZO?=
 =?utf-8?B?dHF5cTVuNTJSMWRNM0R4bXhtMEZwYktrY2JBT050MUd4U2lNVWwxMTdaYXRx?=
 =?utf-8?B?czA5MEFmcGZ2SEZkVzJPOGVUZitnekhzVXFrMzJIUlkvWEdjV01BNHJnbzNC?=
 =?utf-8?B?TWxVOGlYRW9oSGVnS1ptQzluODVkamUxNnNQV3h5R1VxdHJHa0tHYmR4cmdI?=
 =?utf-8?B?RTZNajhYUkUyU1E4NHNYTCs2T0RSbno1THJSMzd2cWIvcXVvQkJlNkNNWUlp?=
 =?utf-8?B?R0J6RFFLQ3pXYTBxUWtlYXloa2pkNjVWOGhJdTV1UURRSEZ0SFhrK2xlNWZ6?=
 =?utf-8?B?YWs4Z1hiUTVKOU9VQk81ZzdjK1NvOVBtWEVuVlcydlhwcnVqRm1pTlZ6OFlF?=
 =?utf-8?B?STNnMERpMjlsMThJaXQ0YnBUSUlCK3NIZkVxKzlxWEdPUkdyYnVtdjVFT2lC?=
 =?utf-8?B?SEM5ZmFNZy94TXhtaWpseElvbEVFOFlId3krdi9mL2hyL3JQcFh2RHdoMkxJ?=
 =?utf-8?B?SUJCUGxBYWsxSlJkck5WaHR0Znc3QlFKKzQxWjJFUzZMK3VkZzhJSS8rdTJp?=
 =?utf-8?B?aUtScWFPcFJqZjZTOFN6M25GZjhScWdhakErdG40WElWQU5HK2prS1hIOHhE?=
 =?utf-8?B?VTlrTTdoMDk5U1MvaXIwWlZNWnNsTDZMZzhTQUpKNmVpMEREYTZtalpNeGdN?=
 =?utf-8?B?MzMrV2pXSDFCV3ZtdVNtMk1nbE9mV2ZNOUdySkFUbzBGQ1BuNmtvWlY4Y0R2?=
 =?utf-8?B?TDd4L245Q0YzUDdKYllFUlY3WXR6U0tEeHNjanJWWVBXUElqYkxzMWY1UDJk?=
 =?utf-8?B?ZC9XNnM3bmR3ZkM1ZGVOS3lhdjV4NG5hVCsyU2toY3pVanVJOTFQRnFGNm1z?=
 =?utf-8?B?a2dmUytDRVMzRWxpcHNuWFM2REZia3pIUGN4MkNsUFVxdXYvOTJCZ25ESlJI?=
 =?utf-8?B?aFdodURmSkNubnJrdWozYmhXdlA5QVZhTThaUy9iak00SmNweEIwSlpYakJh?=
 =?utf-8?B?SGw1Q3Jia2xVSERwaGFoUGgySWFySkV4cmZUb2MvQjBrTEtmUUkzc2syOG4r?=
 =?utf-8?B?akxTUlk3elRtNE9kUS90ZTdibjhpT3V0ZkR4Z3NHOW5KYy9KSXl1aHBiSzhG?=
 =?utf-8?B?K0pZZWpVcTBMQ21ITjZzY1I5cDVmRGNIUnhaMmQ0WWJsci8rZWk1ME4xZEhR?=
 =?utf-8?B?bWQxQktqVEd5eExZMG5aNWkyRjNsWkUyWWRCMElockovLzlsZ1gzbVFWdDZT?=
 =?utf-8?B?bTBVZWVCYUtYWmlKWTY5cHpZN01FLzVtbE1ZL0xWUFBUM2E5VG1rQm9BeGdn?=
 =?utf-8?B?aHlWUy9uRzl0OTRGRDR0WitYbURvSlpWRjRiK05rQkFLUXVzWlNBSDlFaHlr?=
 =?utf-8?B?YWJKMkorZW9yV1F1Wm1LVW1YVTJHWEpVeXZtbUE5amtjQjJ1NUdXYUM2alZJ?=
 =?utf-8?B?UlFlY211Z0VCcHhTTGRkTmhQa1g4RWsyU0pGUm5Xd25yK2EyZlVwRlpwUXlz?=
 =?utf-8?B?UFl5UnpySFRKVHBBT2E2K3NXSVY2S01vOEp5SzQ3R3YyWXlaNk41bjhzblRQ?=
 =?utf-8?B?RUh5a3Q2c1RCRmNITGlEbFlaUzdqYjh3RDN0a2RhTnh2NE1GUkFDTk9PYS8w?=
 =?utf-8?Q?1ikfRXQI3TZPBTtTVF2AEm/pK?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 52143d58-68c3-493d-ad31-08daa0f4a694
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2022 01:56:25.5134
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YX3uFN0SMf3pYHo0U8061+Fp2O+QkqgFRC1ZBxPaxVUy+Xu6uLEjas+ufuBF5YgWauALLWIg+Cy/5ja2leFmhA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7317
X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 9/27/22 18:49, Yang Shi wrote:
> On Tue, Sep 27, 2022 at 6:45 PM John Hubbard <jhubbard@nvidia.com> wrote:
>>
>> On 9/27/22 18:41, Huang, Ying wrote:
>>>>>> I also agree that we cannot make any rules such as "do not lock > 1 page
>>>>>> at the same time, elsewhere in the kernel", because it is already
>>>>>> happening, for example in page-writeback.c, which locks PAGEVEC_SIZE
>>>>>> (15) pages per batch [1].
>>>>
>>>> That's not really the case though. The inner loop of write_cache_page()
>>>> only ever locks one page at a time, either directly via the
>>>> unlock_page() on L2338 (those goto's are amazing) or indirectly via
>>>> (*writepage)() on L2359.
>>>>
>>>> So there's no deadlock potential there because unlocking any previously
>>>> locked page(s) doesn't depend on obtaining the lock for another page.
>>>> Unless I've missed something?
>>>
>>> Yes.  This is my understanding too after checking ext4_writepage().
>>>
>>
>> Yes, I missed the ".writepage() shall unlock the page" design point. Now
>> it seems much more reasonable and safer. :)
> 
> .writepage is deprecated (see
> https://lore.kernel.org/linux-fsdevel/20220719041311.709250-1-hch@lst.de/),
> write back actually uses .writepages.

write_cache_pages() seems to directly call it, though:

generic_writepages()
  write_cache_pages(__writepage)
    __writepage()
      mapping->a_ops->writepage(page, wbc)

So it seems like it's still alive and well. And in any case, it is definitely
passing one page at a time from write_cache_pages(), right?


 thanks,

-- 
John Hubbard
NVIDIA