Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6ec59a82-8d48-2b72-867b-ba465f655810@os.amperecomputing.com>
Date:   Wed, 28 Sep 2022 10:30:06 +0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.0
Subject: Re: [PATCH] ARM: dts: aspeed: mtjade: Remove gpio-keys entries
Content-Language: en-CA
To:     Joel Stanley <joel@jms.id.au>
Cc:     linux-aspeed@lists.ozlabs.org,
        Phong Vo <phong@os.amperecomputing.com>,
        Open Source Submission <patches@amperecomputing.com>,
        linux-kernel@vger.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Andrew Jeffery <andrew@aj.id.au>,
        linux-arm-kernel@lists.infradead.org,
        Rob Herring <robh+dt@kernel.org>,
        Thang Nguyen <thang@os.amperecomputing.com>,
        devicetree@vger.kernel.org, openbmc@lists.ozlabs.org
References: <20220915080828.2894070-1-quan@os.amperecomputing.com>
From:   Quan Nguyen <quan@os.amperecomputing.com>
In-Reply-To: <20220915080828.2894070-1-quan@os.amperecomputing.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aUp5WWVWbUhUTkFxRS9uQlNZc0Nkc1ErK0JOYldaKzQ5UktpYTRWV3VWOWls?=
 =?utf-8?B?L0hFMktwZXFaSlRwRUtPRUgxNWNpTHFRWUVUN0FDVGtDWDJXYXZwTjMwT2J3?=
 =?utf-8?B?Sk1SRW13dzMvenJ1SjFkUmFJSkdVWDE5L0pxMzFZaUk2Qzk2aGdvSXRDV2o5?=
 =?utf-8?B?Zk1JNTBLT1hkVzVxZmV0aE9VZCtYanVQbU4zOE1DVHZwYTR2ek5Zc1U2Mnl5?=
 =?utf-8?B?cDZjUkhTNTVobzk5UWpvNUYveVE1YTJLeU9oMUpjVVZVSTd1eFZuQ1dtTm84?=
 =?utf-8?B?anczei9QWStpbEpqckozNSt4WTFaWlV0TWxaWXVMYTRxckZUMDFiVWdHcGxG?=
 =?utf-8?B?MnhQbGhkNXNDNXQzM3pleGFRWU1SZDcvT0NKSkl3eFRvOFY1MW9BVmRCNmly?=
 =?utf-8?B?azE4d0M0V3NxN1FXb29xRWk0UUxTalpzaFRFNEZvVW9lQUp1UlZpcmtZOEVG?=
 =?utf-8?B?YStSMjNkY1lkZEJ5S0EyWSsyUUcrSVBYNStDTkRVYUFWQkhOOUZPVHVYVEll?=
 =?utf-8?B?YS9CUThMSW1DSHNtNnJWdjRlWkRsNjFpYWpQSXFZYUlSY3NFY2lxbEZwb09s?=
 =?utf-8?B?KzdXVWxpbGtZWEJBVmtXUmJSM0lFUm8yRnJ6b3ZCOUZJd2VISHk1MGdldFdq?=
 =?utf-8?B?dGhCaE1hMzhaalhzem9XQXRaeHUyeXpTUUpQbFJwRXZla1Bwc09FRVlsdzVX?=
 =?utf-8?B?cjIrOVp2S1NhdHVhV3VENGNUTFB2MXdVYjVIU0t2YnpaRmhaVFBZbU1VZWhB?=
 =?utf-8?B?SlV2RDdLWkp1aWFBOUV6aDlvVDhiT3pPNmlnUXlQQmxIQTYwVUIwdGNpVk0y?=
 =?utf-8?B?RFJuRE1JRWdxNHFaUXlJT2dIbVIyOWszZTNSL1Y3eDhucWlJcmdHUXNYQUtI?=
 =?utf-8?B?ckFMZHc1cmRBTTdyK3llNEExUk81QVlGd1B3THU1UUxBeWZ0SFdET0hYNEFZ?=
 =?utf-8?B?UjJBY3hkSklONjhxNWlTWjJuOUxVbi8xbmlvSjRCbGpock5SRTdpZ0RSSmlw?=
 =?utf-8?B?S285ZkpnWTlmRC9OZkdDcGxDSi9aMTdVamI1VXQ4VTVmaWdJS2tYd1pGWmVW?=
 =?utf-8?B?TDBJYUhGYWFPaHNtcUszTUVHNnUxNml4aitkNjl4K2NtclFVVENWdzVYWVpS?=
 =?utf-8?B?U3VJdFowZWFGK1BuTXNxZjNPaE41V01XdEZjZzlaeXFwOWc3YXUxaTF0Z0w1?=
 =?utf-8?B?Q3dGaDFXZml4NWhqVVdYcWIzcjdEVUplTTVlTVFRN0JUS3FzR092TTMwUHdl?=
 =?utf-8?B?NjFTeUwyZ3RiYWFpK2pkTlgyZU9pWkpvVURSR2lMUzcwUmNmT2Nna2ZZVGJB?=
 =?utf-8?B?VkxRaFVtYlh3eHdBSlRDY2Y2YUtBNU9GNzV0UzJTME5JdWhIaTR6YTNwV1R4?=
 =?utf-8?B?amJQTnV4T2d3OHpHMGVGeUgvRE1zc1BUU1ZEbGRxMWtxRHpVeGFVcDY5ZGFq?=
 =?utf-8?B?cGxLU0dSQk53U0k1U0VZQWhXL3ZDangxcjZvR08xZk11ZzlVQVhFKzk4VWwx?=
 =?utf-8?B?cDhBditzTWFFQkZkRC9yTEw3UStSSzM3UklHT28ydzNJcC8ydHdxSTRKZk1i?=
 =?utf-8?B?NyszTXYxeWxrZWtrZ1BBOUhwL2ZIcFI5T2YvQmhqQ2ZrNGVYVHQ4cVlLRVdP?=
 =?utf-8?B?czg2VUpvTWJocEN1VXRvbFN1Q2dvdWo5b3hyTURwSnRPcG8wU2RWSUZCTXEx?=
 =?utf-8?B?Z2lNYWJScVZLd0lld1UzZUgwbVV5aG52ZWk3RmlHQnNBZ1hxM1B3OWNPR2xI?=
 =?utf-8?B?eVJHWFhEUzl0dnA4andzY0R1di91cUNnbk1MRjhJdjhKMjVCTUJLcm9RNUwy?=
 =?utf-8?B?NlM5M2VYUS9ad1VEN25Hbkt2R2xQTURmV3FuTFRTSmUxVHhxZmhYU1Jnenpv?=
 =?utf-8?B?UDU2NGg2NWpJQVJCNnBQTzUwc1d6YW0xQ2xhRE1GV1A4MkxrK0dIeGRuNUpZ?=
 =?utf-8?B?T0laYjNhWkEzMTdPUG5yUWNvektZWUZKQ2M1bnF1YWJ2Mkc4WENjemRkS3ZG?=
 =?utf-8?B?TW85WlE1YUZqSzZueXRvVzVnQU9aWVZhcElGMGFpM0xhU1lWczNKdit1V3RB?=
 =?utf-8?B?M2t5ZTdYSUIzUFlVYUV3Vy9heDNuOFBDTkFnZWpGODJUN0Z5OWVkdEVEZXcr?=
 =?utf-8?B?UTlJZUNOUlRsZWxLUGZROWFmZmFFN1N1UWJFMy9CQlA5NjVzK2toS1VJNVhp?=
 =?utf-8?Q?2UUABpnwTHLmOT7eN2+a0sI=3D?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c81b0682-11cc-4357-a4a2-08daa101c33d
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR01MB7282.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2022 03:30:17.5543
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2rxqVoWqlZqotU6N8SKCmgcaSUIkMFa20p1vEwn/nfPWHb6K9mktq6huJTD0+PvR4xjwnnMD6aSMUuvmqKnHSge/22vLxOWSM8MapHTBwAQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR01MB6911
X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Thanks Joel,
Would you mind picking the patch to openbmc dev-5.15 branch ?

Thank you,
- Quan

On 15/09/2022 15:08, Quan Nguyen wrote:
> Remove the gpio-keys entries from the Ampere's Mt. Jade BMC device
> tree. The user space applications are going to change from using
> libevdev to libgpiod.
> 
> Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com>
> ---
>   .../arm/boot/dts/aspeed-bmc-ampere-mtjade.dts | 95 -------------------
>   1 file changed, 95 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/aspeed-bmc-ampere-mtjade.dts b/arch/arm/boot/dts/aspeed-bmc-ampere-mtjade.dts
> index 82a6f14a45f0..d127cbcc7998 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-ampere-mtjade.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-ampere-mtjade.dts
> @@ -97,101 +97,6 @@ identify {
>   		};
>   	};
>   
> -	gpio-keys {
> -		compatible = "gpio-keys";
> -
> -		event-shutdown-ack {
> -			label = "SHUTDOWN_ACK";
> -			gpios = <&gpio ASPEED_GPIO(G, 2) GPIO_ACTIVE_LOW>;
> -			linux,code = <ASPEED_GPIO(G, 2)>;
> -		};
> -
> -		event-reboot-ack {
> -			label = "REBOOT_ACK";
> -			gpios = <&gpio ASPEED_GPIO(J, 3) GPIO_ACTIVE_LOW>;
> -			linux,code = <ASPEED_GPIO(J, 3)>;
> -		};
> -
> -		event-s0-overtemp {
> -			label = "S0_OVERTEMP";
> -			gpios = <&gpio ASPEED_GPIO(G, 3) GPIO_ACTIVE_LOW>;
> -			linux,code = <ASPEED_GPIO(G, 3)>;
> -		};
> -
> -		event-s0-hightemp {
> -			label = "S0_HIGHTEMP";
> -			gpios = <&gpio ASPEED_GPIO(J, 0) GPIO_ACTIVE_LOW>;
> -			linux,code = <ASPEED_GPIO(J, 0)>;
> -		};
> -
> -		event-s0-cpu-fault {
> -			label = "S0_CPU_FAULT";
> -			gpios = <&gpio ASPEED_GPIO(J, 1) GPIO_ACTIVE_HIGH>;
> -			linux,code = <ASPEED_GPIO(J, 1)>;
> -		};
> -
> -		event-s0-scp-auth-fail {
> -			label = "S0_SCP_AUTH_FAIL";
> -			gpios = <&gpio ASPEED_GPIO(J, 2) GPIO_ACTIVE_LOW>;
> -			linux,code = <ASPEED_GPIO(J, 2)>;
> -		};
> -
> -		event-s1-scp-auth-fail {
> -			label = "S1_SCP_AUTH_FAIL";
> -			gpios = <&gpio ASPEED_GPIO(Z, 5) GPIO_ACTIVE_LOW>;
> -			linux,code = <ASPEED_GPIO(Z, 5)>;
> -		};
> -
> -		event-s1-overtemp {
> -			label = "S1_OVERTEMP";
> -			gpios = <&gpio ASPEED_GPIO(Z, 6) GPIO_ACTIVE_LOW>;
> -			linux,code = <ASPEED_GPIO(Z, 6)>;
> -		};
> -
> -		event-s1-hightemp {
> -			label = "S1_HIGHTEMP";
> -			gpios = <&gpio ASPEED_GPIO(AB, 0) GPIO_ACTIVE_LOW>;
> -			linux,code = <ASPEED_GPIO(AB, 0)>;
> -		};
> -
> -		event-s1-cpu-fault {
> -			label = "S1_CPU_FAULT";
> -			gpios = <&gpio ASPEED_GPIO(Z, 1) GPIO_ACTIVE_HIGH>;
> -			linux,code = <ASPEED_GPIO(Z, 1)>;
> -		};
> -
> -		event-id {
> -			label = "ID_BUTTON";
> -			gpios = <&gpio ASPEED_GPIO(Q, 5) GPIO_ACTIVE_LOW>;
> -			linux,code = <ASPEED_GPIO(Q, 5)>;
> -		};
> -
> -		event-psu1-vin-good {
> -			label = "PSU1_VIN_GOOD";
> -			gpios = <&gpio ASPEED_GPIO(H, 4) GPIO_ACTIVE_LOW>;
> -			linux,code = <ASPEED_GPIO(H, 4)>;
> -		};
> -
> -		event-psu2-vin-good {
> -			label = "PSU2_VIN_GOOD";
> -			gpios = <&gpio ASPEED_GPIO(H, 5) GPIO_ACTIVE_LOW>;
> -			linux,code = <ASPEED_GPIO(H, 5)>;
> -		};
> -
> -		event-psu1-present {
> -			label = "PSU1_PRESENT";
> -			gpios = <&gpio ASPEED_GPIO(I, 0) GPIO_ACTIVE_LOW>;
> -			linux,code = <ASPEED_GPIO(I, 0)>;
> -		};
> -
> -		event-psu2-present {
> -			label = "PSU2_PRESENT";
> -			gpios = <&gpio ASPEED_GPIO(I, 1) GPIO_ACTIVE_LOW>;
> -			linux,code = <ASPEED_GPIO(I, 1)>;
> -		};
> -
> -	};
> -
>   	gpioA0mux: mux-controller {
>   		compatible = "gpio-mux";
>   		#mux-control-cells = <0>;