Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Raju.Lakkaraju@microchip.com>
To:     <netdev@vger.kernel.org>
CC:     <davem@davemloft.net>, <kuba@kernel.org>,
        <linux-kernel@vger.kernel.org>, <Bryan.Whitehead@microchip.com>,
        <edumazet@google.com>, <pabeni@redhat.com>,
        <UNGLinuxDriver@microchip.com>
Subject: RE: [PATCH net V3] eth: lan743x: reject extts for non-pci11x1x
 devices
Thread-Topic: [PATCH net V3] eth: lan743x: reject extts for non-pci11x1x
 devices
Thread-Index: AQHY0ugp3CL9QYg8yk27N/OV0GDHoa30SaiA
Date:   Wed, 28 Sep 2022 05:06:49 +0000
Message-ID: <BYAPR11MB336659F1711CCC21DF9076629F549@BYAPR11MB3366.namprd11.prod.outlook.com>
References: <20220928031128.123926-1-Raju.Lakkaraju@microchip.com>
In-Reply-To: <20220928031128.123926-1-Raju.Lakkaraju@microchip.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?fCm2vlt83TwgI2wotiPnqan/Vt6IKfDEUDtJ1CRHGl7m/S9Lwt6Ifg2CNClE?=
 =?us-ascii?Q?lYs7AmFb4mTotOGrw2RH+BRhlHHOl9D/DGxSAvyrA+fU1x+F5ipeMYoa/E+0?=
 =?us-ascii?Q?SgZhvcBZ3gXgACxKwVA5CL3Ae4SyXBz3mbFXHOhQsqcOwss7VOY3mv8+Ch9w?=
 =?us-ascii?Q?armQmMBZwPvA2DzHYTG3PRfvDkaT8+9YZmUB3aq2SdiHnO4JzD/HLqDRVbKH?=
 =?us-ascii?Q?eRvBH+G6Tu0CDCgO0Of3bXxYOS5NEbHhB6PYYEkxiygZHgIBWhLKUQZgYCNe?=
 =?us-ascii?Q?O/fmKmKGFPiJcLrHN3c/EbHqgZzZHMBqf8BLeIzDqkzGt4cfAXJlokwAeudM?=
 =?us-ascii?Q?Ypmc7WXL3HafyTTW/AdGAP8YyBoowiNEBwsr5ozfJfUSv5hHsFq6yJ8NGCLI?=
 =?us-ascii?Q?CbpSvt9iuJVDKH7mKRyJavnG+gPk4Aaono1nRSFApcvjW3abByN1U0P3PxI4?=
 =?us-ascii?Q?V9YR/S0dUlYBwQtiZ8/z/6jAvUpoC348+1k7SYjxPiHGQPf/MAo94SHnzhTL?=
 =?us-ascii?Q?sCZsviyjjBg86cFFQ5woYPNUfIHkrwDJjwrPy4kGRy6bHHXLH8VuBQJw8c3X?=
 =?us-ascii?Q?D8mviL+BcvpdzaYSlua4VztGdVL1+d7u2eaTIeSH75AIwKQE0wwytQVvNnPf?=
 =?us-ascii?Q?v0B8KcUuWA9pjj04wSV/lTuiWNOwT7ZejOSC06qWJstIt3bUg5myyLNeCAfO?=
 =?us-ascii?Q?feXlwLyt0sNaYkJegCosYZZhIgsgNok4R3vuIhLL6X9PtRV5BAhwA8BN9Os5?=
 =?us-ascii?Q?2x4wJQw5PaK4A1qBnOPdr3bHFXUVb9kMTaFCKaCGVqRA/2yns/Suvd6L0qf0?=
 =?us-ascii?Q?igqfmd0Dsx8C8CCrIqaY8vpn5/d/x7GcWu5g2/A/oBhw9dv1hKHyn6YA9Zig?=
 =?us-ascii?Q?UgWuZ/DEroHMd+XkHFI6v1YUREKEO0uzuPefiXER+texkGWRxSrTkwTjEULv?=
 =?us-ascii?Q?4DfGlsRVqSySJSHEamD0fudhTrgVIQDJSrwS9lar2tV+6toLGQEV6Sfjlo4+?=
 =?us-ascii?Q?eLmHEjjm+AntjlE16pS0KOippnSeAOook6nJ884s7e3h5O0l82B2GPAwpOJo?=
 =?us-ascii?Q?w3ZvUlqEmc7puwuEUTOc/cNxiMCnNGrRCoJgRB6L8AK2rqkAu/EPz3e0OEn5?=
 =?us-ascii?Q?PI23bOUYrOnBMo592oTPWFP49Egw7vjHDsxEm4RART4w0oRNBlA15ZqufhbT?=
 =?us-ascii?Q?11ZyZd6DyZjoo8eKke1RcXF5Yb1q11NvffogyG4djLzZnM2j+SbGphJGjR14?=
 =?us-ascii?Q?+vHTTUJAWWK61xPXIOysI211+JKTiKSGesQOW+wdnjWgeTiAEUN+bqwsjDXK?=
 =?us-ascii?Q?dt0iSCRDUiLZo2KgAd9DynZlIQ15nrW3vGR1xk33C+4I+w8cbOFkF+RMBoFt?=
 =?us-ascii?Q?fvkQYs0M+3jpukSdTl7ytYBLIHBIyNscVcO/KXhyj7TisyPVcBM79D/5K7ui?=
 =?us-ascii?Q?vNHDxD+h+3jY5v45iCackig72qftlfNtVKpSu4O4cbM5k4XdVsOydbfqzt6P?=
 =?us-ascii?Q?8x8skvXuSCakGu+VGcYaCAUM1vk98F8LBb9zdhLss4KzsBqjH69VDbWTexRX?=
 =?us-ascii?Q?5MkW+S49+5MFFr2r2/8Mj6mV7yXK6yrgmqOpPZTRaNBJUnSGBNOe9d/e9iX2?=
 =?us-ascii?Q?Tg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3366.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: de242fd5-901a-45af-1b02-08daa10f4021
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Sep 2022 05:06:49.8526
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Ak6IKY3/L8uJ5uQ1ppei1amQUvUszG5rQCNEkc9m+Zz0IwZndXkr9Ltw/QqCI0jV8kqPQsCfM+QDA4nx8cQjm0SidrzO+ok4IQdnn1xZAVM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5994
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Generate the patch on "net-next" branch
Please ignore this patch.

Thanks,
Raju

-----Original Message-----
From: Raju Lakkaraju <Raju.Lakkaraju@microchip.com>=20
Sent: 28 September 2022 08:41 AM
To: netdev@vger.kernel.org
Cc: davem@davemloft.net; kuba@kernel.org; linux-kernel@vger.kernel.org; Bry=
an Whitehead - C21958 <Bryan.Whitehead@microchip.com>; edumazet@google.com;=
 pabeni@redhat.com; UNGLinuxDriver <UNGLinuxDriver@microchip.com>
Subject: [PATCH net V3] eth: lan743x: reject extts for non-pci11x1x devices

Remove PTP_PF_EXTTS support for non-PCI11x1x devices since they do not supp=
ort the PTP-IO Input event triggered timestamping mechanisms added

Fixes: 60942c397af6 ("Add support for PTP-IO Event Input External  Timestam=
p
 (extts)")

Signed-off-by: Raju Lakkaraju <Raju.Lakkaraju@microchip.com>
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
---
Changes:                                                                   =
    =20
=3D=3D=3D=3D=3D=3D=3D=3D                                                   =
                    =20
V2 -> V3:
 - Correct the Fixes tag

V1 -> V2:                                                                  =
    =20
 - Repost against net with a Fixes tag=20

 drivers/net/ethernet/microchip/lan743x_ptp.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/net/ethernet/microchip/lan743x_ptp.c b/drivers/net/eth=
ernet/microchip/lan743x_ptp.c
index 6a11e2ceb013..da3ea905adbb 100644
--- a/drivers/net/ethernet/microchip/lan743x_ptp.c
+++ b/drivers/net/ethernet/microchip/lan743x_ptp.c
@@ -1049,6 +1049,10 @@ static int lan743x_ptpci_verify_pin_config(struct pt=
p_clock_info *ptp,
 					   enum ptp_pin_function func,
 					   unsigned int chan)
 {
+	struct lan743x_ptp *lan_ptp =3D
+		container_of(ptp, struct lan743x_ptp, ptp_clock_info);
+	struct lan743x_adapter *adapter =3D
+		container_of(lan_ptp, struct lan743x_adapter, ptp);
 	int result =3D 0;
=20
 	/* Confirm the requested function is supported. Parameter @@ -1057,7 +106=
1,10 @@ static int lan743x_ptpci_verify_pin_config(struct ptp_clock_info *p=
tp,
 	switch (func) {
 	case PTP_PF_NONE:
 	case PTP_PF_PEROUT:
+		break;
 	case PTP_PF_EXTTS:
+		if (!adapter->is_pci11x1x)
+			result =3D -1;
 		break;
 	case PTP_PF_PHYSYNC:
 	default:
--
2.25.1