Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Pawel Laszczak <pawell@cadence.com>
To:     Dongliang Mu <dzm91@hust.edu.cn>,
        Peter Chen <peter.chen@kernel.org>,
        Roger Quadros <rogerq@kernel.org>,
        Aswath Govindraju <a-govindraju@ti.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     Dongliang Mu <mudongliangabcd@gmail.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] usb: cdns3: remove dead code
Thread-Topic: [PATCH] usb: cdns3: remove dead code
Thread-Index: AQHY0bCHte+aLqZnNkqFcyKRL76j+q30ZqHQ
Date:   Wed, 28 Sep 2022 06:40:04 +0000
Message-ID: <BYAPR07MB5381FCC10ABD4F92E47CF6D9DD549@BYAPR07MB5381.namprd07.prod.outlook.com>
References: <20220926135922.24541-1-dzm91@hust.edu.cn>
In-Reply-To: <20220926135922.24541-1-dzm91@hust.edu.cn>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?SD1OZI4sBuEXN4jCdi2m78U2O1ui3h6w98c8jcoTek6jCHhsTKU93FSoOYtv?=
 =?us-ascii?Q?NK4HW2Vr5ybxClIRmHxbSl3E8jjwP63ELdfVrOdys255MMVUvCuSH+YZBzCU?=
 =?us-ascii?Q?vF4vdCqUUfEt0LWUSiYiSLq51QvRfYLxMnGPxiEw1BKXtrmK2L3E4swxLQIU?=
 =?us-ascii?Q?f7GL4DeAh1HmpDDsAVPzyYTz2OW3Nfh32nZuhAqy4ZUlYoyi/9uOj2pse2Gj?=
 =?us-ascii?Q?/qnkOxXB2OBbXwcZPNk7EVIiaw3lC2AmvgGFtyzg/0d8mSMLERIXVl2AlIXp?=
 =?us-ascii?Q?2aOiuvQIOG4U3xpz7/csu66eqjJjv98LkiALIBxzd3Xazdy4TFEMolz9n7ax?=
 =?us-ascii?Q?o6OG7PKW59qg1ElxFpSo5BR7vF2uh0E8ykFCKF2IwON/t9fFiCwx0tds6uTV?=
 =?us-ascii?Q?lSuDAeM//Qf0bYrDwgxEw1Kh6/4diXFPe4YbGwonaHxtFaQ56U4Tpdid7Pia?=
 =?us-ascii?Q?lrNY1y0JDWR4LD55bn9oj+SwyaLXZiT6fMcRA+ePTHwdaHTPZWqUu5wfwFHZ?=
 =?us-ascii?Q?6G+an3hjIyWmLPpBZewczj1Xy+iFUeGWOTYjfcQFhnlY8MXBYKFg79EBRzcN?=
 =?us-ascii?Q?SX/TbWW7uWl7I0ZKZjzRH3Sq3QR3AfbaghrCLbI5iZGhtptuq0+ns5IBawVU?=
 =?us-ascii?Q?4ZXwGEyzb1F0yWreFXf7EndaxZE651fdI8cnJcpu9MiRyuesCyw1jH18GlvB?=
 =?us-ascii?Q?Mr3prSSEsRuYbO64JIGUAHz370bmpef2+8yDUKRlKkh1tJyqMvAcZLlByiHs?=
 =?us-ascii?Q?l3Vrkb+PyVkxxp242kCfasjBdVYw7zNQDJofTgozYzg3G4YHKg48fMFXkNVi?=
 =?us-ascii?Q?GypBwcDECa6E2ftJOaFaq4R03W+eqZFkVwvi1eZu0JD6hxjczY6BStWR7/Km?=
 =?us-ascii?Q?xQon9j1Gs2WjudVcfOQuoMXQaQLeo+yBHbgqMH+vefdmvQFAUnDnlwVJSRlF?=
 =?us-ascii?Q?aXZ8RGNxf869yoBBm7d8eoVoOjvFZ5QEOu49c7Gns7c3r0RpLVlKMAGxPf1F?=
 =?us-ascii?Q?w2YGAnro8ytcfcUK7ELkdCFx9jviDN5f7aTzng25bT/9W4iW7PWMY9SNVgL5?=
 =?us-ascii?Q?vYBNjZVsArZAVWrBBQRZSvGv6Od5+s48OYxvG4cELfu0c6+dWjtc0tItvOgt?=
 =?us-ascii?Q?KEdDsh4bRTTwKxCPQqofdtsuwcSIdKaI7MPI53rSlrIflppWgi7VDAGJnFag?=
 =?us-ascii?Q?rfCcr1vdQfLqw6PYabTyj8xxMSfqf0HBYn8cRKtPR+48cQI/V/oWM8Mfyqto?=
 =?us-ascii?Q?FuholKLh2rf8OCE+qwoj1Qxv2h8v1h8LpY2F/Jt0fVjsuHuxS/DKNdUha5Oz?=
 =?us-ascii?Q?oeC7fQbmg8JwM9gEDDZOujZl1+1zoj7nK2fothYR6/WxaCJnd3Of7qBrQeSG?=
 =?us-ascii?Q?Yvyx5Me41hBCPliNpkcZBLhKNYSB7UV2ybtRzjMqSTE542vnjrytNnJMWUFq?=
 =?us-ascii?Q?Caoh7UqP7L9D+tjv3/ZgB2T/LzXirfN52owt9pjoixxdGU3wI5jo0KYlB5jY?=
 =?us-ascii?Q?zLxvIw/kn14v/XpAkbPmG2nUX+WckXK1YAqZQT5b7sD+yJLNslI5kHtgtxVG?=
 =?us-ascii?Q?WHSDdlZ2FwSmX5HYM2EMyZqCD0d+edv95plrkYSabf8G7CaZ9Oj5VsHG8LtO?=
 =?us-ascii?Q?Dg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: cadence.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR07MB5381.namprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b2122460-3bea-4a88-9fae-08daa11c46ca
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Sep 2022 06:40:04.5030
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 4kKxObFxHDhV+ga6ncigGiiquIi3lOgUb8JmCSQEstQQBTDbXqF4Ffz+F7t42JLODM9QYmIWQl2IS1FGRiVo9ZNw1lt1gSx2YO/gTQDK8vk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR07MB8693
X-Proofpoint-ORIG-GUID: d2DMMSiQLQUb2VJkOHS5CzMByXqfkoK2
X-Proofpoint-GUID: d2DMMSiQLQUb2VJkOHS5CzMByXqfkoK2
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-09-28_02,2022-09-27_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_check_notspam policy=outbound_check score=0
 priorityscore=1501 phishscore=0 impostorscore=0 bulkscore=0 clxscore=1011
 lowpriorityscore=0 mlxlogscore=770 malwarescore=0 mlxscore=0
 suspectscore=0 spamscore=0 adultscore=0 classifier=spam adjust=0
 reason=mlx scancount=1 engine=8.12.0-2209130000
 definitions=main-2209280039
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>
>From: Dongliang Mu <mudongliangabcd@gmail.com>
>
>Smatch reports the following error:
>
>drivers/usb/cdns3/cdns3-plat.c:113 cdns3_plat_probe() warn:
>platform_get_irq() does not return zero
>
>From the document, platform_get_irq_byname_optional only returns
>non-zero value, and negative value on failure.
>
>Fix this by removing the zero value checking.
>
>Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
>---
> drivers/usb/cdns3/cdns3-plat.c | 2 --
> 1 file changed, 2 deletions(-)
>
>diff --git a/drivers/usb/cdns3/cdns3-plat.c b/drivers/usb/cdns3/cdns3-plat=
.c
>index dc068e940ed5..2bc5d094548b 100644
>--- a/drivers/usb/cdns3/cdns3-plat.c
>+++ b/drivers/usb/cdns3/cdns3-plat.c
>@@ -110,8 +110,6 @@ static int cdns3_plat_probe(struct platform_device *pd=
ev)
> 	cdns->wakeup_irq =3D platform_get_irq_byname_optional(pdev, "wakeup");
> 	if (cdns->wakeup_irq =3D=3D -EPROBE_DEFER)
> 		return cdns->wakeup_irq;
>-	else if (cdns->wakeup_irq =3D=3D 0)
>-		return -EINVAL;
>
I think that here we should have:
	else if (cdns->wakeup_irq =3D=3D -ENXIO)
		return -EINVAL;
 because of function:=20
platform_get_irq_byname_optional -> __platform_get_irq_byname returns
irq number (>0),  -EPROBE_DEFFER or -ENXIO


thanks
Pawel

> 	if (cdns->wakeup_irq < 0) {
> 		dev_dbg(dev, "couldn't get wakeup irq\n");
>--
>2.35.1