Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 28 Sep 2022 14:52:42 +0800
From:   Baoquan He <bhe@redhat.com>
To:     Chen Lifu <chenlifu@huawei.com>
Cc:     linux@armlinux.org.uk, akpm@linux-foundation.org, pmladek@suse.com,
        kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] ARM: kexec: Make machine_crash_nonpanic_core()
 static
Message-ID: <YzPvOjGWHxdcGUjh@MiWiFi-R3L-srv>
References: <20220816074250.3991633-1-chenlifu@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220816074250.3991633-1-chenlifu@huawei.com>
Precedence: bulk

On 08/16/22 at 03:42pm, Chen Lifu wrote:
> This symbol is not used outside of the file, so mark it static.
> 
> Fixes the following warning:
> 
> arch/arm/kernel/machine_kexec.c:76:6: warning: symbol 'machine_crash_nonpanic_core' was not declared. Should it be static?
> 
> Signed-off-by: Chen Lifu <chenlifu@huawei.com>

LGTM,

Acked-by: Baoquan He <bhe@redhat.com>

> ---
>  arch/arm/kernel/machine_kexec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/kernel/machine_kexec.c b/arch/arm/kernel/machine_kexec.c
> index f567032a09c0..a2e9ac763a9f 100644
> --- a/arch/arm/kernel/machine_kexec.c
> +++ b/arch/arm/kernel/machine_kexec.c
> @@ -71,11 +71,11 @@ int machine_kexec_prepare(struct kimage *image)
>  
>  void machine_kexec_cleanup(struct kimage *image)
>  {
>  }
>  
> -void machine_crash_nonpanic_core(void *unused)
> +static void machine_crash_nonpanic_core(void *unused)
>  {
>  	struct pt_regs regs;
>  
>  	crash_setup_regs(&regs, get_irq_regs());
>  	printk(KERN_DEBUG "CPU %u will stop doing anything useful since another CPU has crashed\n",
> -- 
> 2.37.1
> 
> 
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
>