Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <552281f4-dc8c-7cd7-32af-fa48de5aa414@foss.st.com>
Date:   Wed, 28 Sep 2022 08:45:54 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] usb: dwc3: st: Fix node's child name
Content-Language: en-US
To:     Felipe Balbi <felipe@balbi.sh>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
CC:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Serge Semin <Sergey.Semin@baikalelectronics.ru>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Jerome Audu <jerome.audu@st.com>
References: <20220926124359.304770-1-patrice.chotard@foss.st.com>
 <87o7v0g860.fsf@balbi.sh>
From:   Patrice CHOTARD <patrice.chotard@foss.st.com>
In-Reply-To: <87o7v0g860.fsf@balbi.sh>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Felipe, Krzysztof

On 9/27/22 17:15, Felipe Balbi wrote:
> 
> <patrice.chotard@foss.st.com> writes:
> 
>> From: Patrice Chotard <patrice.chotard@foss.st.com>
>>
>> Update node's child name from "dwc3" to "usb", this fixes
>> the following issue:
>>
>> [3.773852] usb-st-dwc3 8f94000.dwc3: failed to find dwc3 core node
>>
>> Fixes: 3120910a099b ("ARM: dts: stih407-family: Harmonize DWC USB3 DT nodes name")
>>
>> Reported-by: Jerome Audu <jerome.audu@st.com>
>> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
>> ---
>>  drivers/usb/dwc3/dwc3-st.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/dwc3/dwc3-st.c b/drivers/usb/dwc3/dwc3-st.c
>> index 166b5bde45cb..6c14a79279f9 100644
>> --- a/drivers/usb/dwc3/dwc3-st.c
>> +++ b/drivers/usb/dwc3/dwc3-st.c
>> @@ -251,7 +251,7 @@ static int st_dwc3_probe(struct platform_device *pdev)
>>  	/* Manage SoftReset */
>>  	reset_control_deassert(dwc3_data->rstc_rst);
>>  
>> -	child = of_get_child_by_name(node, "dwc3");
>> +	child = of_get_child_by_name(node, "usb");
> 
> there could be DTBs in the wild which have `dwc3' as the child name. It
> seems to me that you should try both names, instead.
> 

As this patch is already merged, i will submit an additional patch which will 
rely on child's compatible string instead of child's node name, as done in other
dwc3 driver.

Thanks
Patrice