Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp191909rwb; Wed, 28 Sep 2022 01:03:49 -0700 (PDT) X-Google-Smtp-Source: AMsMyM63eBzRlWtLvOWS8MXoo8LVYFDj28zOY4Yi3wf6+Ga2+TlsxrrFR5EpHLDKj2zJZgy2Scl6 X-Received: by 2002:a17:907:2722:b0:77f:c136:62eb with SMTP id d2-20020a170907272200b0077fc13662ebmr25675420ejl.522.1664352229473; Wed, 28 Sep 2022 01:03:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664352229; cv=none; d=google.com; s=arc-20160816; b=lLNcxwf65l9CZtMH151qhMWtsHXmpYHMHU/1V6Fm99PLAAhS2+5Ho4ixDLqdwNLrfg cWnnFy74mBYm9LSWEQh00ZLeUoAbybUKmgaVyJnTTvwZQNRTb464AyyDsgOwnOiTUM+V fIOLcaIfdy4whu8ao1Km38GJiP/Ha6Vir0fodEmBfVQL2+lVVghW5Bzolz3FzDWHsflh HwdH6SepTvqD9uJEIwi0Y11KuERKShv8tAAkJ7fPjlxZSM5X4EIatcwPEEOT9Q6uXEI5 dk6Z/ciQ0Bd/WZRiqUY0gAO/ihQ6iJDUVjTWm9zzHrsyfYQ927AFVMemAS0UJUiWt8Jp FIfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:subject:user-agent:mime-version:date:message-id; bh=hHNlYIX2STpzXM01KYD+B2c1H0VsEFbxrdw1izwknd4=; b=GUYEeR9TIhniSb34vtKkhUBPYuMW5pnVJOE6OIGdT995S3GlygsmVvTYBcHDo4E5tx 5QzeOZgc+6f5jB1gNILivq+II6AmTYLukleVYnzc+jhF2IMqATHNoFxZ4WFMvQBDXH3/ mTi8NUc5s3WwcoB3Z2d6MGX3A6KkoH9bDVBcdEALhMfVMr+5FJiuqmMd7sl2W1x0BDar lHwldqGDu2eLksTR8+hkRmxzM+hU6nLe0yeADsC8rOH9X6Lpn83G1Q2TF3pmFZ9x/A6R TOnPqT+Ft4ZHrZ+u8VO2smC0haOZccRhqo1bPbLdKSa4XbZqPvmxGx42MxcNhqPbI2CU G6XA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hs41-20020a1709073ea900b007828388864dsi4713344ejc.692.2022.09.28.01.03.22; Wed, 28 Sep 2022 01:03:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233815AbiI1H7A (ORCPT + 99 others); Wed, 28 Sep 2022 03:59:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233549AbiI1H6y (ORCPT ); Wed, 28 Sep 2022 03:58:54 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F8EBF370A; Wed, 28 Sep 2022 00:58:53 -0700 (PDT) Received: from fraeml701-chm.china.huawei.com (unknown [172.18.147.200]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4McpkT3r1Sz6H75t; Wed, 28 Sep 2022 15:57:37 +0800 (CST) Received: from lhrpeml500003.china.huawei.com (7.191.162.67) by fraeml701-chm.china.huawei.com (10.206.15.50) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2375.31; Wed, 28 Sep 2022 09:58:50 +0200 Received: from [10.126.175.219] (10.126.175.219) by lhrpeml500003.china.huawei.com (7.191.162.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 28 Sep 2022 08:58:50 +0100 Message-ID: <2b9a216c-dd91-d843-4a84-ac7ec78db853@huawei.com> Date: Wed, 28 Sep 2022 08:58:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v6 5/8] scsi: hisi_sas: use sas_find_attathed_phy_id() instead of open coded To: Jason Yan , , CC: , , , , , , , Jack Wang References: <20220928070130.3657183-1-yanaijie@huawei.com> <20220928070130.3657183-6-yanaijie@huawei.com> From: John Garry In-Reply-To: <20220928070130.3657183-6-yanaijie@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.126.175.219] X-ClientProxiedBy: lhrpeml500003.china.huawei.com (7.191.162.67) To lhrpeml500003.china.huawei.com (7.191.162.67) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/09/2022 08:01, Jason Yan wrote: > The attached phy finding is open coded. Now we can replace it with > sas_find_attached_phy_id(). To keep consistent, the return value of > hisi_sas_dev_found() is also changed to -ENODEV after calling > sas_find_attathed_phy_id() failed. > > Signed-off-by: Jason Yan > Reviewed-by: Jack Wang > Reviewed-by: Damien Le Moal > --- Acked-by: John Garry