Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <cfcc8d22-8efd-8b0b-d24f-cb734f9ef927@linux.ibm.com>
Date:   Wed, 28 Sep 2022 10:24:29 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.13.1
Subject: Re: [PATCH 3/7] s390/qeth: Convert snprintf() to scnprintf()
Content-Language: en-US
To:     Joe Perches <joe@perches.com>, Jules Irenge <jbi.octave@gmail.com>,
        borntraeger@linux.ibm.com
Cc:     svens@linux.ibm.com, linux-s390@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        agordeev@linux.ibm.com
References: <YzHyniCyf+G/2xI8@fedora>
 <5138b5a347b79a5f35b75d0babf5f41dbace879a.camel@perches.com>
From:   Alexandra Winter <wintera@linux.ibm.com>
In-Reply-To: <5138b5a347b79a5f35b75d0babf5f41dbace879a.camel@perches.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 27.09.22 16:27, Joe Perches wrote:
> On Mon, 2022-09-26 at 19:42 +0100, Jules Irenge wrote:
>> Coccinnelle reports a warning
>> Warning: Use scnprintf or sprintf
>> Adding to that, there has been a slow migration from snprintf to scnprintf.
>> This LWN article explains the rationale for this change
>> https: //lwn.net/Articles/69419/
>> Ie. snprintf() returns what *would* be the resulting length,
>> while scnprintf() returns the actual length.
> []
>> diff --git a/drivers/s390/net/qeth_core_sys.c b/drivers/s390/net/qeth_core_sys.c
> []
>> @@ -500,9 +500,9 @@ static ssize_t qeth_hw_trap_show(struct device *dev,
>>  	struct qeth_card *card = dev_get_drvdata(dev);
>>  
>>  	if (card->info.hwtrap)
>> -		return snprintf(buf, 5, "arm\n");
>> +		return scnprintf(buf, 5, "arm\n");
>>  	else
>> -		return snprintf(buf, 8, "disarm\n");
>> +		return scnprintf(buf, 8, "disarm\n");
>>  }
> 
> Use sysfs_emit instead.
> 

Thank you Joe, that sounds like the best way to handle this. 
I propose that I take this onto my ToDo list and test it in the s390 environment.
I will add 
Reported-by: Jules Irenge <jbi.octave@gmail.com>
Suggested-by: Joe Perches <joe@perches.com>