Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp275397rwb; Wed, 28 Sep 2022 02:30:38 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6IDsVJHy8nsglL0EeZoDVT7n6d2V6sFbFapcGvvPazaxeArvzSM9/DZu5LvgU+q7reGCNi X-Received: by 2002:a17:907:320c:b0:77b:6f08:9870 with SMTP id xg12-20020a170907320c00b0077b6f089870mr26547237ejb.249.1664357438140; Wed, 28 Sep 2022 02:30:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664357438; cv=none; d=google.com; s=arc-20160816; b=vY5weaAe9g2taT0n+8ImBCVyU2xOeJjUwKIO561nQJwPaUelBTzen3zid5H/IAg6KK cKu1PtVA9hIGYS+HpzD1SvFqPAGejWVE4aXSSRxZEjiiLtFw+AAlxM47gotgZNwY9kpA 6mqwp8mEjnXWU3jSTyN07jJNRcmaGNh3njmFrku0a3eUHkCqyqHnuqXZtwHdQzSn1idF 9jYMXyuso0EBdPfC2Tv9r5BWI34a3K83+TmFXl2w2uM5epVpLGlmO5qovrYOvoGb2oTb PzMwXA2iYpXTWNIeaeo5CwKd0A+bTgGKv5VLZEDpnQ3PV839UWomQGmw5udRUwHhWD5w HijQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=HsRiuLBSIZ4AJTyP6taQh47+3anujKo8VwqSthOZMus=; b=s0+iuMh+o4AdQ0+++KHg6HCoyeB55E5sXmavRV/VHSLoh5+8negiRT/WEvjSOZq8tP /KODPYIRT3MjiqFGljO4yGaKVFJEWAjNeLEGDpYZddaa0CLZn4RVA9hsFuGaC9dtPuLY 9JSmVJof8S6ob0hWfptV7YwjBFEVdvPS/41lbk5uiMNJSMKSUhn2xYvmIE/f1SYW90Lt c9z9Jz5b68zYdrxh4cFS1Kn69eKJ4Jl6ylN9I21RrX0Su5WXh80R5PMeA71umkmeW8T1 2UIjjkSS0d5MUj1E9kbhbafN8JmYiO9OoU+EBlbQmRzKmcE+176G7q9wwhilpaxqjFCY 61NQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=aLaGroi0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e21-20020a17090658d500b007808f947175si4665203ejs.492.2022.09.28.02.30.11; Wed, 28 Sep 2022 02:30:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=aLaGroi0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233263AbiI1IuN (ORCPT + 99 others); Wed, 28 Sep 2022 04:50:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46796 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233375AbiI1Ita (ORCPT ); Wed, 28 Sep 2022 04:49:30 -0400 Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5EE63D597; Wed, 28 Sep 2022 01:49:19 -0700 (PDT) Received: by mail-pg1-x52a.google.com with SMTP id v4so11607931pgi.10; Wed, 28 Sep 2022 01:49:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=HsRiuLBSIZ4AJTyP6taQh47+3anujKo8VwqSthOZMus=; b=aLaGroi0OkO9MdK6+JBr2wA9wTPUulYbYWxZ3aq09VWOOOkrwZKAhW33DrNu8wzCA6 rScwT/lr6caIO4so6LtAcoTFam8XGizxrj5x/rxJBeqIEzZPsRb0VBLRso3fYAE+S6F4 Csg+VsVwAbSi/hp4sq0RbTa9RetyFiJOCd9dqqoBsoXNfmQfqr6sFHDkhGpuTQT2gBA1 2PVLkgAW+xEQ4tzwNF5DDJnvTRzAtwDQzW7UMKttbMWdD+XnOGI7blXo6brdAwJZL+OB lkUZOhCSE/HmcXRSkIMcvnTdMckzhjmZqXvfK9DOxyJiVaSrYcfkbq34cWwDfunVCTVX vTHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=HsRiuLBSIZ4AJTyP6taQh47+3anujKo8VwqSthOZMus=; b=29UQejwpxe+Yqtd2iHD8XEOO5gLokX333vkGUBSDpOfJOuMWEj1lf7mmdkZmFuiWKO QtG54tjfRvTSBUy7eE2D2Eh+uVabGB0eT0xmL3LLT2ePSidPQXNPIkV7oxceYXS8z6Xk Boaojl6Gax2lIUkwibog1cTVa8VSVVD6jSr2wol19gUv3IxaBCyhZnaztH6/horRkTvd EGbeKzUIcz8gUFfr54hCAA0akJAyvbw2khDKS60XZ4KJme0EKTbz6fL0EQBUOeLCpn4s comNHynAl18yvCrNNtgKYfYz/EMUpj+yqAr/Js37b6RKEMaR8QIArNuiPcUD9w8dvqyC tktw== X-Gm-Message-State: ACrzQf3mzW12nRtPsIhGVva1yds/0nNa8JGzkXsUvhIHKv3gE+K2p3IW 5qb0izXG+8wEyDHe5Mq4K5FJdj/fb6o= X-Received: by 2002:a05:6a00:1493:b0:546:2856:6d08 with SMTP id v19-20020a056a00149300b0054628566d08mr33617512pfu.84.1664354958891; Wed, 28 Sep 2022 01:49:18 -0700 (PDT) Received: from localhost.localdomain (125-228-123-29.hinet-ip.hinet.net. [125.228.123.29]) by smtp.gmail.com with ESMTPSA id t1-20020a17090a024100b00200461cfa99sm780456pje.11.2022.09.28.01.49.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Sep 2022 01:49:18 -0700 (PDT) From: Potin Lai To: Pavel Machek Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, Joel Stanley , Patrick Williams , Potin Lai , Potin Lai Subject: [PATCH 1/1] leds: pca955x: fix return value checking of smbus block read Date: Wed, 28 Sep 2022 16:47:09 +0800 Message-Id: <20220928084709.1822312-1-potin.lai.pt@gmail.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In i2c_smbus_read_i2c_block_data(), it returns negtive value for error code, otherwise returns data length of reading. Change the if statement to "if (err < 0)" to indicate the real error returned by i2c_smbus_read_i2c_block_data(). Signed-off-by: Potin Lai --- drivers/leds/leds-pca955x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/leds/leds-pca955x.c b/drivers/leds/leds-pca955x.c index cf0a9fe20086a..cba9876b11872 100644 --- a/drivers/leds/leds-pca955x.c +++ b/drivers/leds/leds-pca955x.c @@ -689,7 +689,7 @@ static int pca955x_probe(struct i2c_client *client) err = i2c_smbus_read_i2c_block_data(client, 0x10 | (pca955x_num_input_regs(chip->bits) + 4), nls, ls1); - if (err) + if (err < 0) return err; for (i = 0; i < nls; ++i) -- 2.31.1