Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 28 Sep 2022 11:46:28 +0300
From:   Ido Schimmel <idosch@nvidia.com>
To:     netdev@kapio-technology.com
Cc:     Vladimir Oltean <olteanv@gmail.com>, davem@davemloft.net,
        kuba@kernel.org, netdev@vger.kernel.org,
        Florian Fainelli <f.fainelli@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Hauke Mehrtens <hauke@hauke-m.de>,
        Woojung Huh <woojung.huh@microchip.com>,
        UNGLinuxDriver@microchip.com, Sean Wang <sean.wang@mediatek.com>,
        Landen Chao <Landen.Chao@mediatek.com>,
        DENG Qingfang <dqfext@gmail.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Ivan Vecera <ivecera@redhat.com>,
        Roopa Prabhu <roopa@nvidia.com>,
        Nikolay Aleksandrov <razor@blackwall.org>,
        Shuah Khan <shuah@kernel.org>,
        Christian Marangi <ansuelsmth@gmail.com>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Yuwei Wang <wangyuweihx@gmail.com>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org,
        bridge@lists.linux-foundation.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v5 net-next 6/6] selftests: forwarding: add test of
 MAC-Auth Bypass to locked port tests
Message-ID: <YzQJ5MRSL/ShRSgP@shredder>
References: <20220908112044.czjh3xkzb4r27ohq@skbuf>
 <152c0ceadefbd742331c340bec2f50c0@kapio-technology.com>
 <20220911001346.qno33l47i6nvgiwy@skbuf>
 <15ee472a68beca4a151118179da5e663@kapio-technology.com>
 <Yx73FOpN5uhPQhFl@shredder>
 <086704ce7f323cc1b3cca78670b42095@kapio-technology.com>
 <Yyq6BnUfctLeerqE@shredder>
 <7a4549d645f9bbbf41e814f087eb07d1@kapio-technology.com>
 <YzPwwuCe0HkJpkQe@shredder>
 <0c6b93c828d9b52346ddb3d445446734@kapio-technology.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <0c6b93c828d9b52346ddb3d445446734@kapio-technology.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YfrkhFCOE877aDZIHsyF2fTrqTkTQhEnb093Hv6wIVpktPw9p1io1bCmScZW?=
 =?us-ascii?Q?MdbqyM7rjF7IwGpjd2qGMYsjUPBpTAs5uR1b0UMeo3iypJ56jL9uRE01Dnpn?=
 =?us-ascii?Q?He49ipv3UoOmzg9aBxbBMZ4VHqA+Bbsue70fRWtj0T09BD+i7me52qL53FvA?=
 =?us-ascii?Q?v4m3kKB2g685HQuMoHADL9DgCpyvhXzhi+BjbKf6RAumGEO97WQvJQRVmlVZ?=
 =?us-ascii?Q?EEX07UQWDQbJV/+zZb5oZ+UiGpL7RT6OoQy6Gfszs4ilwe3J8eJXyKWhNGx3?=
 =?us-ascii?Q?m93gQrLYGGm8mFWmgE4NfFKF4loi1dmvUcgqEhefUgcIHsYRZo3lOIBlpNr+?=
 =?us-ascii?Q?oxF4i3FsVXNZ7wN4J/Y1VakYEG4l1PxgN4+koVVcDOeVG9VDfYkkX8CF56DH?=
 =?us-ascii?Q?HS4GRsEIxlZKvLZ0PEG7r7jPQSf4n2d+JJP59Hdb2r0ybUWwZUVZyD0DM7Oq?=
 =?us-ascii?Q?JVB/Y/03/FbOKBpdbWBtFGmeyJvljwrunZ6h6BnTOswtqISC+VlMLRc5iI0R?=
 =?us-ascii?Q?RMJrsEmvwtpknFGvKKuhWMeTKDb2kO0Cp9hzsMP1xikNsUpb7ob7PCduSm2l?=
 =?us-ascii?Q?z9O/Sp6ejHhUolrv+Nv4kCrvPyPGhheNCguEjox/OL7+FdMkbHtDAhHpZQrI?=
 =?us-ascii?Q?eRoNmwekmb9rQ10a25Zwxed7fKXrxmSRpzwlDanZH0hOf3c1RMd5tKMm/3t5?=
 =?us-ascii?Q?/KGr1hDo01zeMdBL2RspaE+94GGKZZafYK8P7k+hFPG3RNMHtamolBzNnDCM?=
 =?us-ascii?Q?FdQjxP0woK9f8Y9N9/WhNLlHoW/Ig7SIYQjL265ShbLLPAuw6UIMN1diVVxb?=
 =?us-ascii?Q?CpyROQuIb6dlK+/C11v41S49UhEdH5HisbM2DvEUDZyfVOs/E5mcTOVBKdvo?=
 =?us-ascii?Q?yglYoSI5zEGw8lvrJ5zo7O6BXrS2a2kLhrrO4vRadzHlElWkMfKKJbakvfxi?=
 =?us-ascii?Q?dWMf0MkyLlvIUIhrIIeXF7lcuUHh0aDk8mIclGYMkNhWYSRoYxW0L8kZL95Y?=
 =?us-ascii?Q?ufNLBita+5hpoP33JBERRTnuxQv4ZbcsAjMDNIyCRPKVjQRKKpiqVLt4HCkA?=
 =?us-ascii?Q?DIe0zG1YcssmeebpN5icXUBsszmmzXYCHddplyYk47IHbm3nRJLgoCKx2xec?=
 =?us-ascii?Q?rUMm2HQeKQLkb9jXNI2vmDGbCimMtxhsoZD4oNhxSs12edBUmqWFP89UL7JQ?=
 =?us-ascii?Q?D2zmfP5kuQLsJmCNc0CRwubp1lH4VJ4Ep9ZCNSdalynSIskuh1qGCtIC0iwk?=
 =?us-ascii?Q?Pxy5pQxITXiNmumvHr4M/QklOxK1xL67W4hK9KJUr7Mt8hDIFw0eXkMp8py6?=
 =?us-ascii?Q?+T9db7DNEFGLl6lB8i2w1WUQJwm8+SQNC0Tiikry6fOmlarlSsv8bqTmYRUz?=
 =?us-ascii?Q?R/1m4XSmSgs5EMkXgv7BjEkvPdWoA+ren4QOueJ20Ss66JoPdb1q9dtQQZHS?=
 =?us-ascii?Q?SQyTGlgxITfRlLeCaZuEhIIjKAf7Q4gzepWZD0ownDB1sUwAkYBrGohz+nXs?=
 =?us-ascii?Q?M5msCHJJVYc2NQxnBRzxw66d8EhifJCQGu8xChQR/DKlwpDER4/abmi064w4?=
 =?us-ascii?Q?hniuXqKzalwZDT9tL3IiUcCA+GlSPuHvXEImRcaD?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f00b164b-1fa6-447d-95dc-08daa12df32e
X-MS-Exchange-CrossTenant-AuthSource: CY5PR12MB6179.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2022 08:46:35.3894
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vGgdJj3HifIRN8zBTzcsg9XSXP3E58/hzFZ2SZOOwsojNuGZyJu/nNtHcc1dexnmmoE4aHjoyTT56CqtzFu54A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6021
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Sep 28, 2022 at 09:47:42AM +0200, netdev@kapio-technology.com wrote:
> On 2022-09-28 08:59, Ido Schimmel wrote:
> 
> > Why not found? This works:
> > 
> >  # bridge fdb add 00:11:22:33:44:55 dev br0 self local
> >  $ bridge fdb get 00:11:22:33:44:55 br br0
> 
> With:
>  # bridge fdb replace 00.11.22.33.44.55 dev $swpX static
> 
> fdb_find_rcu() will not find the entry added with 'dev br0' above, and will
> thus add a new entry afaik.

It needs "master" keyword:

 $ bridge fdb get 00:11:22:33:44:55 br br0
 Error: Fdb entry not found.
 # bridge fdb add 00:11:22:33:44:55 dev br0 self local
 $ bridge fdb get 00:11:22:33:44:55 br br0
 00:11:22:33:44:55 dev br0 master br0 permanent
 # bridge fdb replace 00:11:22:33:44:55 dev dummy10 master static
 $ bridge fdb get 00:11:22:33:44:55 br br0
 00:11:22:33:44:55 dev dummy10 master br0 static

"master" means manipulate the FDB of the master device. Therefore, the
replace command manipulates the FDB of br0.

"self" (which is the default [1]) means manipulate the FDB of the device
itself. In case of br0 it means manipulate the FDB of the bridge device.
For physical devices it usually translates to manipulating the unicast
address filter list.

[1] https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/tree/bridge/fdb.c#n511