Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     netdev@vger.kernel.org
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
        Rui Sousa <rui.sousa@nxp.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        UNGLinuxDriver@microchip.com,
        Horatiu Vultur <horatiu.vultur@microchip.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Michael Walle <michael@walle.cc>,
        Vinicius Costa Gomes <vinicius.gomes@intel.com>,
        Maxim Kochetkov <fido_max@inbox.ru>,
        Colin Foster <colin.foster@in-advantage.com>,
        Richie Pearn <richard.pearn@nxp.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Vladimir Oltean <olteanv@gmail.com>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>, linux-kernel@vger.kernel.org
Subject: [PATCH v4 net-next 4/8] net: dsa: hellcreek: refactor hellcreek_port_setup_tc() to use switch/case
Date:   Wed, 28 Sep 2022 12:52:00 +0300
Message-Id: <20220928095204.2093716-5-vladimir.oltean@nxp.com>
In-Reply-To: <20220928095204.2093716-1-vladimir.oltean@nxp.com>
References: <20220928095204.2093716-1-vladimir.oltean@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?S0Tg/W/R3Wyqrm3Pn/HQJEv4zYXKuiqBU1zaeZbmiDr5UwD4q+dBKqIc5fZA?=
 =?us-ascii?Q?7k8dfVUN2P4Kv2mky0EwQ6pDjjqNWG8Fd1sRj35lWRCeVBw1BV5NybH0Ep/T?=
 =?us-ascii?Q?YaklM9G32nS7Rir7EkfbVd5TPesbncYVfiRalt5NmHZptWlXpUsD2jMQujk5?=
 =?us-ascii?Q?GcMWhb+LMHJhCvgkM+qBufQ05U4bd4PDDKGfP2C6tPZw8nCdgoXNcxDf/5mm?=
 =?us-ascii?Q?EgWmotCJd0ELY8d67XUIZkW3nwm/V1W2MwraAy1iRTZTcNQJG4mekLwTLkT2?=
 =?us-ascii?Q?stHjrDmvnlFTDkmQQ3drYeaq1iAnxARjV6jM13sryXGLiTWdRAsdHGeC79Nn?=
 =?us-ascii?Q?AEXTqIaQd344ItIhwpdbyyDN2kXZOBbqennmbj1i3qUl2OMDfXhIeuIsvmRW?=
 =?us-ascii?Q?594E/Kl3HuT7zN7XM+9tRiQ1kfRmFONUzJp/tZv2mykReqFEBZFrJAmbI0zO?=
 =?us-ascii?Q?1eLPilLOPzMEwzrJOdcuecqm1yNXNzE7wiF0kwtyWj1J3A6Kbju3mVokV8FZ?=
 =?us-ascii?Q?9gcoajvyAdFYYzqViUxYemtpCm2utSn3RGkeF/y06neHYjorbcog/UjNc3Pz?=
 =?us-ascii?Q?y6s9oFi9Uo89ueb/arFcas9Kf115hJ3tSwvJs2RhkJJ3mnXeWC9Y21p7CneY?=
 =?us-ascii?Q?NLlE7dp1Q1pyE0yJiEnGc+VEb+kOP1eB9yE1J6Qi+ibGtUGQwm5DNTPnHAEe?=
 =?us-ascii?Q?9nxvn6avmn9qbK5sfXK+jSY3Z5IoAjdCLKxYGf06DBZQ4EkhgIxh8Kc4nm/I?=
 =?us-ascii?Q?ItY7NEeUcV52Af61Fhb10LNp3fmr0++2/CbeRk+XouSVjXswi8DEjYCxq08Z?=
 =?us-ascii?Q?XcqAO+mRYGEMHVn/qfzHWeizNqMXec8Wr1DUdQZ2HfT7UyI8tWgOv4O8Sz4r?=
 =?us-ascii?Q?XLCvPB9kFkn1pu4+tnkGZx5UreZ+80U89nLXiEblrHfO5rXjuy5zNi7scH4i?=
 =?us-ascii?Q?FR3iR2xcOFiXCrS4YK1D9ID6eeOMAhqb+B8KTxPO63mF4jgOcDIwSIEvS4hs?=
 =?us-ascii?Q?pbVuoz1jRmZ942017cns+DHPzXFq030vW+twLHV+F++wmzlKNTX9I9jehLGC?=
 =?us-ascii?Q?XFWlr6/Pe6s8TmYNFOXAandgYeltwPFhmV0NayqRU7kKhfXtT/Io1zozK0Mn?=
 =?us-ascii?Q?IcBZ4VTNwGl5TXIA+ZF1j4AOjxX+eEwUNXHwqdJN+WXfTZzX03xP22BWGxPE?=
 =?us-ascii?Q?eRtQgGrqMtyxIgYkzNq5U3k5Z9pO3mlm5euBJnc7EmMLinL24fiz3Sw1JoSs?=
 =?us-ascii?Q?/N80tOTqbWfwp5zLVl7GIgktHRf5qG0rIwzJgVNBPeL4AU0P5SW+5V4sYHTC?=
 =?us-ascii?Q?wFJuSu3rFs6oiOnsQ6M80H7ILlaxeF1zn1E2WdyueaVHhN6TVmiPaRueLBlD?=
 =?us-ascii?Q?jvvuC8q95NBq/Kk5TG1PK0kRYEROgMpnCx84ONnVLSsD1KgWMkTqCghiqnoQ?=
 =?us-ascii?Q?9gc3J1zEdHZeQeB2eH9EK7XlwbRPuyZSSL+ZF/+lB3mY3DK0C3nPd5a5rQjL?=
 =?us-ascii?Q?LNJABLDmBMgeXdJud5RbhBRZ/zHZ92JIF6/hSoTqKrelsdy+Kd0aHLl7GWbb?=
 =?us-ascii?Q?QyqQUy3Yn1Tdo6lD2TJkqVgVDuIS7ZMz3ELENY5pynO1ZzEXIeW/8JQ/LkRu?=
 =?us-ascii?Q?fg=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 95354c07-7ef1-4e8f-e89e-08daa1372502
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2022 09:52:24.4598
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: B/uBlX/LmJFg6g70uBzqXDEOOmXYLp1wbB9M3A7jVplEzlEtIeez9BvPZUUWYXTAx+6Iv9KL9c/SWv7TS0DLVw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7752
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The following patch will need to make this function also respond to
TC_QUERY_BASE, so make the processing more structured around the
tc_setup_type.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
v2->v3:
- patch is new
v3->v4:
- fix broken patch splitting (hellcreek_tc_query_caps should not have
  been introduced here)

 drivers/net/dsa/hirschmann/hellcreek.c | 20 ++++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)

diff --git a/drivers/net/dsa/hirschmann/hellcreek.c b/drivers/net/dsa/hirschmann/hellcreek.c
index eac6ace7c5f9..19e61d4112b3 100644
--- a/drivers/net/dsa/hirschmann/hellcreek.c
+++ b/drivers/net/dsa/hirschmann/hellcreek.c
@@ -1812,19 +1812,23 @@ static bool hellcreek_validate_schedule(struct hellcreek *hellcreek,
 static int hellcreek_port_setup_tc(struct dsa_switch *ds, int port,
 				   enum tc_setup_type type, void *type_data)
 {
-	struct tc_taprio_qopt_offload *taprio = type_data;
 	struct hellcreek *hellcreek = ds->priv;
 
-	if (type != TC_SETUP_QDISC_TAPRIO)
-		return -EOPNOTSUPP;
+	switch (type) {
+	case TC_SETUP_QDISC_TAPRIO: {
+		struct tc_taprio_qopt_offload *taprio = type_data;
 
-	if (!hellcreek_validate_schedule(hellcreek, taprio))
-		return -EOPNOTSUPP;
+		if (!hellcreek_validate_schedule(hellcreek, taprio))
+			return -EOPNOTSUPP;
 
-	if (taprio->enable)
-		return hellcreek_port_set_schedule(ds, port, taprio);
+		if (taprio->enable)
+			return hellcreek_port_set_schedule(ds, port, taprio);
 
-	return hellcreek_port_del_schedule(ds, port);
+		return hellcreek_port_del_schedule(ds, port);
+	}
+	default:
+		return -EOPNOTSUPP;
+	}
 }
 
 static const struct dsa_switch_ops hellcreek_ds_ops = {
-- 
2.34.1